Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow streams on index table #6827

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Allow streams on index table #6827

merged 1 commit into from
Jul 18, 2024

Conversation

CyberROFL
Copy link
Member

@CyberROFL CyberROFL commented Jul 18, 2024 •
edited
Loading

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

...

@CyberROFL CyberROFL requested a review from ijon July 18, 2024 13:54
@CyberROFL CyberROFL self-assigned this Jul 18, 2024
@CyberROFL CyberROFL marked this pull request as ready for review July 18, 2024 13:55
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 18, 2024 •
edited
Loading

⚪ 2024-07-18 13:57:37 UTC Pre-commit check for e8644f7 has started.
⚪ 2024-07-18 14:00:48 UTC Build+Tests linux-x86_64-release-clang14 is running...
🟢 2024-07-18 14:39:23 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 18, 2024 •
edited
Loading

⚪ 2024-07-18 13:57:57 UTC Pre-commit check for e8644f7 has started.
⚪ 2024-07-18 14:01:01 UTC Build+Tests linux-x86_64-relwithdebinfo is running...
🟢 2024-07-18 16:24:32 UTC Build successful.
🔴 2024-07-18 16:28:53 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39559 34319 0 5 5221 14

🟢 2024-07-18 16:29:32 UTC ydbd size 8.0 GiB changed* by -46.4 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: ebee36a merge: e8644f7 diff diff %
ydbd size 8 642 786 480 Bytes 8 642 738 920 Bytes -46.4 KiB -0.001%
ydbd stripped size 470 543 136 Bytes 470 535 168 Bytes -7.8 KiB -0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 18, 2024 •
edited
Loading

⚪ 2024-07-18 13:57:58 UTC Pre-commit check for e8644f7 has started.
⚪ 2024-07-18 14:00:56 UTC Build+Tests linux-x86_64-release-asan is running...
🟢 2024-07-18 16:28:08 UTC Build successful.
🔴 2024-07-18 16:31:06 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11030 10437 0 92 325 176

🟢 2024-07-18 16:31:55 UTC ydbd size 5.2 GiB changed* by -95.5 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: ebee36a merge: e8644f7 diff diff %
ydbd size 5 547 148 464 Bytes 5 547 050 624 Bytes -95.5 KiB -0.002%
ydbd stripped size 1 195 359 792 Bytes 1 195 339 248 Bytes -20.1 KiB -0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

ijon
ijon approved these changes Jul 18, 2024
View reviewed changes
ydb/core/tx/schemeshard/schemeshard__operation_part.cpp
Comment on lines +103 to +104
ISubOperation::TPtr CascadeDropTableChildren(TVector<ISubOperation::TPtr>& result, const TOperationId& id, const TPath& table) {
for (const auto& [childName, childPathId] : table.Base()->GetChildren()) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Для порядка не надо проверить, что table это (строчная) таблица, а не ColumnStore или директория?

@CyberROFL CyberROFL merged commit b4dd540 into ydb-platform:main Jul 18, 2024
10 of 14 checks passed
@CyberROFL CyberROFL deleted the stream-on-index-table branch July 18, 2024 16:43
This was referenced Jul 19, 2024
Merged
Merged
Merged
Merged
Merged
Merged
CyberROFL added a commit to CyberROFL/ydb that referenced this pull request Jul 26, 2024
@CyberROFL
Allow streams on index table (ydb-platform#6827)
42b6cd6
@CyberROFL CyberROFL mentioned this pull request Jul 26, 2024
Closed
CyberROFL added a commit to CyberROFL/ydb that referenced this pull request Jul 26, 2024
@CyberROFL
Allow streams on index table (ydb-platform#6827)
bc978cc
@CyberROFL CyberROFL mentioned this pull request Jul 26, 2024
Merged
CyberROFL added a commit to CyberROFL/ydb that referenced this pull request Jul 26, 2024
@CyberROFL
Allow streams on index table (ydb-platform#6827)
28bd906
@CyberROFL CyberROFL mentioned this pull request Jul 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ijon ijon ijon approved these changes

@dcherednik dcherednik Awaiting requested review from dcherednik

Assignees

@CyberROFL CyberROFL

Labels
not-for-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CyberROFL @ijon