You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add commit redo size check for successfully ignited operations as a precaution measure to avoid infinite loop of schemeshard hitting local tx commit redo size limit, restarting, attempting to propose persisted operation again, hitting commit redo size limit again, restarting and so on.
This could happen with inherently massive operations such as copy-tables used as a starting step of database export/backup.
Coping large number of tables with huge number of partitions can result in so large TTxOperationPropose local transaction that its size would hit the limit imposed by the tablet executor. Tablet violating that limit is considered broken and will be immediately stopped. See ydb/core/tablet_flat/flat_executor.cpp, NTabletFlatExecutor::TExecutor::ExecuteTransaction().
KIKIMR-21751
Changelog entry
...
Changelog category
New feature
Experimental feature
Improvement
Performance improvement
Bugfix
Backward incompatible change
Documentation (changelog entry is not required)
Not for changelog (changelog entry is not required)
⚪ 2024-07-18 20:22:37 UTC Pre-commit check for a809519 has started.
⚪ 2024-07-18 20:22:39 UTC Build linux-x86_64-release-asan is running...
🔴 2024-07-18 21:33:33 UTC Build failed. see the build logs.
🔴 2024-07-18 21:35:00 UTC Tests run skipped.
⚪ 2024-07-18 20:23:48 UTC Pre-commit check for a809519 has started.
⚪ 2024-07-18 20:23:50 UTC Build linux-x86_64-release-clang14 is running...
🔴 2024-07-18 21:30:49 UTC Build failed. see the build logs.
⚪ 2024-07-18 20:24:02 UTC Pre-commit check for a809519 has started.
⚪ 2024-07-18 20:24:05 UTC Build linux-x86_64-relwithdebinfo is running...
🔴 2024-07-18 21:40:26 UTC Build failed. see the build logs.
🔴 2024-07-18 21:41:56 UTC Tests run skipped.
⚪ 2024-07-20 12:08:43 UTC Pre-commit check for a809519 has started.
⚪ 2024-07-20 12:08:47 UTC Build linux-x86_64-release-asan is running...
🔴 2024-07-20 13:20:56 UTC Build failed. see the build logs.
🔴 2024-07-20 13:22:24 UTC Tests run skipped.
⚪ 2024-07-20 12:08:46 UTC Pre-commit check for a809519 has started.
⚪ 2024-07-20 12:08:48 UTC Build linux-x86_64-release-clang14 is running...
🔴 2024-07-20 13:16:16 UTC Build failed. see the build logs.
⚪ 2024-07-20 12:11:20 UTC Pre-commit check for a809519 has started.
⚪ 2024-07-20 12:11:23 UTC Build linux-x86_64-relwithdebinfo is running...
🔴 2024-07-20 13:30:33 UTC Build failed. see the build logs.
🔴 2024-07-20 13:32:05 UTC Tests run skipped.
…form#6760)
Add commit redo size check for successfully ignited operations as a precaution measure to avoid infinite loop of schemeshard hitting local tx commit redo size limit, restarting, attempting to propose persisted operation again, hitting commit redo size limit again, restarting and so on.
This could happen with inherently massive operations such as copy-tables used as a starting step of database export/backup.
Coping large number of tables with huge number of partitions can result in so large TTxOperationPropose local transaction that its size would hit the limit imposed by the tablet executor. Tablet violating that limit is considered broken and will be immediately stopped.
See ydb/core/tablet_flat/flat_executor.cpp, NTabletFlatExecutor::TExecutor::ExecuteTransaction().
KIKIMR-21751
⚪ 2024-07-20 19:16:38 UTC Pre-commit check for 0d1cb58 has started.
⚪ 2024-07-20 19:16:40 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-07-20 20:22:48 UTC Build successful.
⚪ 2024-07-20 20:24:29 UTC Tests are running...
🔴 2024-07-20 21:47:18 UTC Some tests failed, follow the links below.
⚪ 2024-07-20 19:16:52 UTC Pre-commit check for 0d1cb58 has started.
⚪ 2024-07-20 19:16:54 UTC Build linux-x86_64-release-asan is running...
🟢 2024-07-20 20:38:20 UTC Build successful.
⚪ 2024-07-20 20:40:09 UTC Tests are running...
🔴 2024-07-20 22:40:44 UTC Some tests failed, follow the links below.
⚪ 2024-07-20 19:16:52 UTC Pre-commit check for 0d1cb58 has started.
⚪ 2024-07-20 19:16:55 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-07-20 20:38:08 UTC Build successful.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
github-actions
bot
removed
the
rebase-and-check
ijon
force-pushed
the
merge/24-2/fix-schemeshard-reject-too-massive-operations
branch
from
merged ebee36a from main
Add commit redo size check for successfully ignited operations as a precaution measure to avoid infinite loop of schemeshard hitting local tx commit redo size limit, restarting, attempting to propose persisted operation again, hitting commit redo size limit again, restarting and so on.
This could happen with inherently massive operations such as copy-tables used as a starting step of database export/backup.
Coping large number of tables with huge number of partitions can result in so large TTxOperationPropose local transaction that its size would hit the limit imposed by the tablet executor. Tablet violating that limit is considered broken and will be immediately stopped. See ydb/core/tablet_flat/flat_executor.cpp, NTabletFlatExecutor::TExecutor::ExecuteTransaction().
KIKIMR-21751
Changelog entry
...
Changelog category
Additional information
...