Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alter index is not supported for vector index #7005

Merged
merged 3 commits into from
Jul 25, 2024
Merged

Alter index is not supported for vector index #7005

merged 3 commits into from
Jul 25, 2024

Conversation

azevaykin
Copy link
Collaborator

@azevaykin azevaykin commented Jul 23, 2024 •
edited
Loading

Changelog entry

Disable ALTER INDEX for vector index
https://ydb.tech/docs/en/yql/reference/syntax/alter_table#alter-index

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

...

@azevaykin azevaykin requested a review from MBkkt July 23, 2024 14:36
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 23, 2024 •
edited
Loading

⚪ 2024-07-23 14:37:08 UTC Pre-commit check for 3fdcdbf has started.
⚪ 2024-07-23 14:39:52 UTC Build+Tests linux-x86_64-release-asan is running...
🟢 2024-07-23 16:43:45 UTC Build successful.
🔴 2024-07-23 16:46:53 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10823 10239 0 90 322 172

🟡 2024-07-23 16:47:41 UTC ydbd size 5.2 GiB changed* by +127.2 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 9564ab2 merge: 3fdcdbf diff diff %
ydbd size 5 555 927 872 Bytes 5 556 058 104 Bytes +127.2 KiB +0.002%
ydbd stripped size 1 196 753 840 Bytes 1 196 775 664 Bytes +21.3 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 23, 2024 •
edited
Loading

⚪ 2024-07-23 14:37:35 UTC Pre-commit check for 3fdcdbf has started.
⚪ 2024-07-23 14:40:24 UTC Build+Tests linux-x86_64-release-clang14 is running...
🟢 2024-07-23 14:50:34 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 23, 2024 •
edited
Loading

⚪ 2024-07-23 14:39:54 UTC Pre-commit check for 3fdcdbf has started.
⚪ 2024-07-23 14:42:38 UTC Build+Tests linux-x86_64-relwithdebinfo is running...
🟢 2024-07-23 16:30:23 UTC Build successful.
🔴 2024-07-23 16:35:42 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39495 34202 0 4 5278 11

🟢 2024-07-23 16:36:20 UTC ydbd size 8.1 GiB changed* by +57.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 9564ab2 merge: 3fdcdbf diff diff %
ydbd size 8 652 439 080 Bytes 8 652 498 208 Bytes +57.7 KiB +0.001%
ydbd stripped size 471 045 088 Bytes 471 048 224 Bytes +3.1 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@azevaykin azevaykin force-pushed the VectorIndexDisableAutoPartitioning branch from c36350e to f73b75b Compare July 24, 2024 05:38
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 24, 2024 •
edited
Loading

⚪ 2024-07-24 05:40:25 UTC Pre-commit check for 5b12c61 has started.
🔴 2024-07-24 05:43:14 UTC Test run completed, no test results found for commit f73b75b.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 24, 2024 •
edited
Loading

⚪ 2024-07-24 05:40:40 UTC Pre-commit check for 5b12c61 has started.
🔴 2024-07-24 05:43:34 UTC Test run completed, no test results found for commit f73b75b.

@github-actions GitHub Actions
Copy link

⚪ 2024-07-24 05:41:58 UTC Pre-commit check for 5b12c61 has started.

@azevaykin azevaykin force-pushed the VectorIndexDisableAutoPartitioning branch from f73b75b to 2e255c2 Compare July 24, 2024 05:47
@azevaykin azevaykin changed the title Disable ALTER INDEX for vector index Vector index contains several impl tables Jul 24, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 24, 2024 •
edited
Loading

⚪ 2024-07-24 07:13:09 UTC Pre-commit check for f2024e1 has started.
⚪ 2024-07-24 07:16:01 UTC Build+Tests linux-x86_64-relwithdebinfo is running...
🔴 2024-07-24 07:22:16 UTC Build failed. see the logs.
🔴 2024-07-24 07:22:19 UTC Test run completed, no test results found for commit 2e255c2.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 24, 2024 •
edited
Loading

⚪ 2024-07-24 07:13:16 UTC Pre-commit check for f2024e1 has started.
⚪ 2024-07-24 07:16:09 UTC Build+Tests linux-x86_64-release-clang14 is running...
🔴 2024-07-24 07:23:59 UTC Build failed. see the logs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 24, 2024 •
edited
Loading

⚪ 2024-07-24 07:13:35 UTC Pre-commit check for f2024e1 has started.
⚪ 2024-07-24 07:16:25 UTC Build+Tests linux-x86_64-release-asan is running...
🔴 2024-07-24 07:21:34 UTC Build failed. see the logs.
🔴 2024-07-24 07:21:37 UTC Test run completed, no test results found for commit 2e255c2.

MBkkt
MBkkt reviewed Jul 24, 2024
View reviewed changes
Copy link
Collaborator

@MBkkt MBkkt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you can add some tests for describe vector index?

Because it looks like rpc_describe didn't support vector index before this changes

MBkkt
MBkkt previously approved these changes Jul 24, 2024
View reviewed changes
Copy link
Collaborator

@MBkkt MBkkt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test in the second PR

@azevaykin azevaykin changed the title Vector index contains several impl tables Alter index is not supported for vector index Jul 24, 2024
@azevaykin
Copy link
Collaborator Author

azevaykin commented Jul 24, 2024 •
edited
Loading

Maybe you can add some tests for describe vector index?

Because it looks like rpc_describe didn't support vector index before this changes

fa955aba25eb78926cc6f28a7cb08e2774389c37

@azevaykin azevaykin requested a review from MBkkt July 24, 2024 10:27
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 24, 2024 •
edited
Loading

⚪ 2024-07-24 10:29:11 UTC Pre-commit check for 7e03c38 has started.
⚪ 2024-07-24 10:32:23 UTC Check linux-x86_64-release-asan is running...
⚫ 2024-07-24 10:59:28 UTC Check cancelled

MBkkt
MBkkt previously approved these changes Jul 24, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 24, 2024 •
edited
Loading

⚪ 2024-07-24 10:30:13 UTC Pre-commit check for 7e03c38 has started.
⚪ 2024-07-24 10:33:03 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-07-24 10:51:43 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 24, 2024 •
edited
Loading

⚪ 2024-07-24 10:30:17 UTC Pre-commit check for 7e03c38 has started.
⚪ 2024-07-24 10:33:14 UTC Check linux-x86_64-relwithdebinfo is running...
⚫ 2024-07-24 10:59:06 UTC Check cancelled

@azevaykin azevaykin force-pushed the VectorIndexDisableAutoPartitioning branch 2 times, most recently from 7551f12 to f4d888c Compare July 24, 2024 10:58
@azevaykin azevaykin requested a review from MBkkt July 24, 2024 11:01
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 24, 2024 •
edited
Loading

⚪ 2024-07-24 11:03:34 UTC Pre-commit check for 1e60a17 has started.
⚪ 2024-07-24 11:06:27 UTC Check linux-x86_64-release-asan is running...
⚫ 2024-07-24 12:13:19 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 24, 2024 •
edited
Loading

⚪ 2024-07-24 11:03:42 UTC Pre-commit check for 1e60a17 has started.
⚪ 2024-07-24 11:06:39 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-07-24 11:13:02 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 24, 2024 •
edited
Loading

⚪ 2024-07-24 11:05:10 UTC Pre-commit check for 1e60a17 has started.
⚪ 2024-07-24 11:08:01 UTC Check linux-x86_64-relwithdebinfo is running...
⚫ 2024-07-24 12:13:19 UTC Check cancelled

@azevaykin azevaykin force-pushed the VectorIndexDisableAutoPartitioning branch from f4d888c to 350355e Compare July 24, 2024 12:12
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 24, 2024 •
edited
Loading

⚪ 2024-07-24 12:18:28 UTC Pre-commit check for 66fafa5 has started.
⚪ 2024-07-24 12:21:22 UTC Check linux-x86_64-relwithdebinfo is running...
🔴 2024-07-24 14:19:26 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39505 34216 0 1 5274 14

⚪ 2024-07-24 14:24:02 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟢 2024-07-24 14:31:39 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12 (only retried tests) 5 0 0 0 7

🟢 2024-07-24 14:36:24 UTC Build successful.
🔴 2024-07-24 14:37:05 UTC ydbd size 8.1 GiB changed* by +2.8 MiB, which is >= 2.0 MiB vs main: Alert

ydbd size dash main: 48a86ec merge: 66fafa5 diff diff %
ydbd size 8 652 588 944 Bytes 8 655 477 376 Bytes +2.8 MiB +0.033%
ydbd stripped size 471 059 072 Bytes 471 215 552 Bytes +152.8 KiB +0.033%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 24, 2024 •
edited
Loading

⚪ 2024-07-24 12:18:29 UTC Pre-commit check for 66fafa5 has started.
⚪ 2024-07-24 12:21:22 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-07-24 12:47:40 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 24, 2024 •
edited
Loading

⚪ 2024-07-24 12:18:55 UTC Pre-commit check for 66fafa5 has started.
⚪ 2024-07-24 12:21:54 UTC Check linux-x86_64-release-asan is running...
🔴 2024-07-24 14:51:05 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10829 10225 0 102 329 173

🟢 2024-07-24 14:52:32 UTC Build successful.
🟡 2024-07-24 14:53:28 UTC ydbd size 5.2 GiB changed* by +138.8 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 1def359 merge: 66fafa5 diff diff %
ydbd size 5 558 078 952 Bytes 5 558 221 128 Bytes +138.8 KiB +0.003%
ydbd stripped size 1 197 262 512 Bytes 1 197 290 352 Bytes +27.2 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@azevaykin azevaykin merged commit f36b8b5 into ydb-platform:main Jul 25, 2024
10 of 12 checks passed
@azevaykin azevaykin deleted the VectorIndexDisableAutoPartitioning branch July 25, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gridnevvvit gridnevvvit gridnevvvit approved these changes

@MBkkt MBkkt MBkkt approved these changes

Assignees
No one assigned
Labels
not-for-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@azevaykin @gridnevvvit @MBkkt