-
Notifications
You must be signed in to change notification settings - Fork 559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete unsupported special column DELETE_FLAG #7068
Delete unsupported special column DELETE_FLAG #7068
Conversation
⚪ |
⚪ |
⚪ |
78d74a0
to
3d4777b
Compare
⚪
|
⚪
|
3d4777b
to
eca368d
Compare
eca368d
to
0d36d10
Compare
⚪
|
⚪
|
@@ -53,6 +53,7 @@ namespace NKikimr::NOlap { | |||
enum class ENormalizerSequentialId : ui32 { | |||
Granules = 1, | |||
Chunks, | |||
DeleteUnsupportedSpecialColumns, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
добавление должно идти последовательно. это SequentialId
на этом построена схема запуска новых
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Но у нас же падение в следующем нормализаторе.
@@ -98,6 +98,8 @@ TString TIndexInfo::GetColumnName(ui32 id, bool required) const { | |||
return SPEC_COL_PLAN_STEP; | |||
} else if (ESpecialColumn(id) == ESpecialColumn::TX_ID) { | |||
return SPEC_COL_TX_ID; | |||
} else if (ESpecialColumn(id) == ESpecialColumn::DELETE_FLAG) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
здесь я бы не добавлял. может не упасть там где надо
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
В каком случае?
|
||
using TKeyBatch = std::vector<TKey>; | ||
|
||
std::optional<std::vector<TKeyBatch>> KeysToDelete(NTabletFlatExecutor::TTransactionContext& txc, size_t maxBatchSize) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const size_t
} | ||
|
||
ui64 GetSize() const override { | ||
return 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
а это точно правильно?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
поправил
⚪
|
⚪
|
)" This reverts commit 1cbae05.
Add special column DELETE_FLAG for forward compatibility with 24.3