Delete unsupported special column DELETE_FLAG #7068
Conversation
|
⚪ |
|
⚪ |
|
⚪ |
zverevgeny
force-pushed
the
7049_delete_flag
branch
from
78d74a0
to
3d4777b
Compare
|
⚪
|
|
⚪
|
zverevgeny
force-pushed
the
7049_delete_flag
branch
from
3d4777b
to
eca368d
Compare
zverevgeny
force-pushed
the
7049_delete_flag
branch
from
eca368d
to
0d36d10
Compare
zverevgeny
changed the title
|
⚪
|
|
⚪
|
| @@ -53,6 +53,7 @@ namespace NKikimr::NOlap { | |||
| enum class ENormalizerSequentialId : ui32 { | |||
| Granules = 1, | |||
| Chunks, | |||
| DeleteUnsupportedSpecialColumns, | |||
There was a problem hiding this comment.
добавление должно идти последовательно. это SequentialId
на этом построена схема запуска новых
There was a problem hiding this comment.
Но у нас же падение в следующем нормализаторе.
| @@ -98,6 +98,8 @@ TString TIndexInfo::GetColumnName(ui32 id, bool required) const { | |||
| return SPEC_COL_PLAN_STEP; | |||
| } else if (ESpecialColumn(id) == ESpecialColumn::TX_ID) { | |||
| return SPEC_COL_TX_ID; | |||
| } else if (ESpecialColumn(id) == ESpecialColumn::DELETE_FLAG) { | |||
There was a problem hiding this comment.
здесь я бы не добавлял. может не упасть там где надо
There was a problem hiding this comment.
В каком случае?
|
|
||
| using TKeyBatch = std::vector<TKey>; | ||
|
|
||
| std::optional<std::vector<TKeyBatch>> KeysToDelete(NTabletFlatExecutor::TTransactionContext& txc, size_t maxBatchSize) { |
| } | ||
|
|
||
| ui64 GetSize() const override { | ||
| return 0; |
There was a problem hiding this comment.
а это точно правильно?
|
⚪
|
|
⚪
|
)" This reverts commit 1cbae05.
Add special column DELETE_FLAG for forward compatibility with 24.3