Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix block device size calculcation code #7341

Merged

Conversation

alexvru
Copy link
Collaborator

@alexvru alexvru commented Aug 1, 2024

Changelog entry

Fix block device size calculcation code

Changelog category

  • Bugfix

Additional information

For some devices ioctl BLKDEVSIZE did not work, so this new method was introduced to fix that problem.

@github-actions github-actions bot added the bugfix label Aug 1, 2024
Copy link

github-actions bot commented Aug 1, 2024

2024-08-01 07:29:40 UTC Pre-commit check for baf2640 has started.
2024-08-01 07:32:42 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-01 07:38:05 UTC Build successful.

Copy link

github-actions bot commented Aug 1, 2024

2024-08-01 07:30:07 UTC Pre-commit check for baf2640 has started.
2024-08-01 07:33:18 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-01 09:42:09 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10832 10778 0 18 23 13

🟢 2024-08-01 09:43:26 UTC Build successful.
🟢 2024-08-01 09:43:54 UTC ydbd size 5.4 GiB changed* by -112 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: ae8c7f9 merge: baf2640 diff diff %
ydbd size 5 841 311 496 Bytes 5 841 311 384 Bytes -112 Bytes -0.000%
ydbd stripped size 1 463 911 024 Bytes 1 463 910 960 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Aug 1, 2024

2024-08-01 07:32:06 UTC Pre-commit check for baf2640 has started.
2024-08-01 07:35:10 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-08-01 09:51:55 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39564 34242 0 4 5306 12

2024-08-01 09:56:28 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟢 2024-08-01 10:04:50 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
18 (only retried tests) 10 0 0 0 8

🟢 2024-08-01 10:08:17 UTC Build successful.
🟢 2024-08-01 10:08:54 UTC ydbd size 8.1 GiB changed* by +448 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: ae8c7f9 merge: baf2640 diff diff %
ydbd size 8 672 037 176 Bytes 8 672 037 624 Bytes +448 Bytes +0.000%
ydbd stripped size 472 047 784 Bytes 472 047 784 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@alexvru alexvru merged commit b08c9a5 into ydb-platform:main Aug 1, 2024
11 of 13 checks passed
@alexvru alexvru deleted the pdisk/fix-blkdev-size-calculation branch August 1, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants