Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stable-24-2: Enable COUNT in view queries (#6820) #7501

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

jepett0
Copy link
Collaborator

@jepett0 jepett0 commented Aug 6, 2024

Enables aggregate functions inside views by:

  • providing ModuleResolver from KQP host to CompileExpr function
  • repeating ExpandApplyForLambdas transformation step when rewriting a read from a view

Based on #6820, but does not contain TKqpTranslationSettingsBuilder, because it does not exist in stable-24-2. However, the fix is enough which can be proved by the added unit tests.

Copy link

github-actions bot commented Aug 6, 2024

2024-08-06 13:15:56 UTC Pre-commit check for 9e84639 has started.
2024-08-06 13:15:59 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-08-06 14:36:30 UTC Build successful.

Copy link

github-actions bot commented Aug 6, 2024

2024-08-06 13:17:37 UTC Pre-commit check for 9e84639 has started.
2024-08-06 13:17:40 UTC Build linux-x86_64-release-asan is running...
🟢 2024-08-06 14:16:11 UTC Build successful.
2024-08-06 14:17:55 UTC Tests are running...
🔴 2024-08-06 16:08:56 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9214 9113 0 15 47 39

Copy link

github-actions bot commented Aug 6, 2024

2024-08-06 13:18:42 UTC Pre-commit check for 9e84639 has started.
2024-08-06 13:18:45 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-08-06 14:24:10 UTC Build successful.
2024-08-06 14:25:54 UTC Tests are running...
🔴 2024-08-06 15:54:21 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9649 9575 0 2 34 38

@jepett0 jepett0 marked this pull request as ready for review August 7, 2024 06:19
@jepett0 jepett0 requested a review from a team as a code owner August 7, 2024 06:19
@jepett0 jepett0 changed the title Enable COUNT in view queries Enable COUNT in view queries (#6820) Aug 7, 2024
@jepett0 jepett0 changed the title Enable COUNT in view queries (#6820) stable-24-2: Enable COUNT in view queries (#6820) Aug 7, 2024
@jepett0 jepett0 merged commit 2d3a63b into ydb-platform:stable-24-2 Aug 7, 2024
5 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants