Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove templates.h #8746

Merged
merged 7 commits into from
Sep 10, 2024
Merged

Conversation

maximyurchuk
Copy link
Collaborator

@maximyurchuk maximyurchuk commented Sep 4, 2024

Changelog entry

Some of the classes are unused, one of them are used in only one place

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

...

Copy link

github-actions bot commented Sep 4, 2024

2024-09-04 14:27:51 UTC Pre-commit check linux-x86_64-release-asan for 90252b8 has started.
2024-09-04 14:31:53 UTC ya make is running...
🔴 2024-09-04 16:31:55 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11396 11319 0 21 27 29

🟢 2024-09-04 16:32:56 UTC Build successful.
🟢 2024-09-04 16:33:27 UTC ydbd size 5.5 GiB changed* by -320 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 0ba24ba merge: 90252b8 diff diff %
ydbd size 5 957 884 688 Bytes 5 957 884 368 Bytes -320 Bytes -0.000%
ydbd stripped size 1 490 148 432 Bytes 1 490 148 368 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 4, 2024

2024-09-04 14:28:21 UTC Pre-commit check linux-x86_64-release-clang14 for 90252b8 has started.
2024-09-04 14:32:29 UTC ya make is running...
🟢 2024-09-04 15:07:10 UTC Build successful.

Copy link

github-actions bot commented Sep 4, 2024

2024-09-04 14:28:58 UTC Pre-commit check linux-x86_64-relwithdebinfo for 90252b8 has started.
2024-09-04 14:33:39 UTC ya make is running...
🟡 2024-09-04 16:12:51 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
40633 35183 0 29 5403 18

2024-09-04 16:16:26 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-09-04 16:25:59 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
54 (only retried tests) 35 0 4 0 15

2024-09-04 16:26:07 UTC ya make is running... (failed tests rerun, try 3)
🟢 2024-09-04 16:34:08 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
24 (only retried tests) 10 0 0 0 14

🟢 2024-09-04 16:34:15 UTC Build successful.
🟢 2024-09-04 16:34:53 UTC ydbd size 8.3 GiB changed* by +16.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 0ba24ba merge: 90252b8 diff diff %
ydbd size 8 922 756 352 Bytes 8 922 773 312 Bytes +16.6 KiB +0.000%
ydbd stripped size 481 976 840 Bytes 481 976 840 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 5, 2024

2024-09-05 08:54:18 UTC Pre-commit check linux-x86_64-release-clang14 for e9c688d has started.
2024-09-05 08:57:21 UTC ya make is running...
🔴 2024-09-05 09:00:40 UTC Build failed. see the logs.

Copy link

github-actions bot commented Sep 5, 2024

2024-09-05 08:54:24 UTC Pre-commit check linux-x86_64-relwithdebinfo for e9c688d has started.
2024-09-05 08:57:24 UTC ya make is running...
2024-09-05 09:44:43 UTC Check cancelled

Copy link

github-actions bot commented Sep 5, 2024

2024-09-05 08:54:39 UTC Pre-commit check linux-x86_64-release-asan for e9c688d has started.
2024-09-05 08:57:42 UTC ya make is running...
2024-09-05 09:44:33 UTC Check cancelled

Copy link

github-actions bot commented Sep 5, 2024

2024-09-05 09:46:17 UTC Pre-commit check linux-x86_64-release-asan for 833ad12 has started.
2024-09-05 09:49:25 UTC ya make is running...
2024-09-05 11:56:45 UTC Check cancelled

Copy link

github-actions bot commented Sep 5, 2024

2024-09-05 09:47:53 UTC Pre-commit check linux-x86_64-release-clang14 for 833ad12 has started.
2024-09-05 09:50:56 UTC ya make is running...
🟢 2024-09-05 10:22:44 UTC Build successful.

Copy link

github-actions bot commented Sep 5, 2024

2024-09-05 09:50:33 UTC Pre-commit check linux-x86_64-relwithdebinfo for 833ad12 has started.
2024-09-05 09:53:34 UTC ya make is running...
🟡 2024-09-05 11:24:11 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
40644 35193 0 8 5415 28

2024-09-05 11:27:58 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-09-05 11:38:02 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
48 (only retried tests) 30 0 1 0 17

2024-09-05 11:38:10 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-09-05 11:45:03 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
24 (only retried tests) 6 0 1 0 17

🟢 2024-09-05 11:45:10 UTC Build successful.
🟡 2024-09-05 11:45:48 UTC ydbd size 8.4 GiB changed* by +753.0 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 732bf12 merge: 833ad12 diff diff %
ydbd size 9 001 104 776 Bytes 9 001 875 840 Bytes +753.0 KiB +0.009%
ydbd stripped size 486 652 968 Bytes 486 657 000 Bytes +3.9 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 5, 2024

2024-09-05 12:40:56 UTC Pre-commit check linux-x86_64-release-clang14 for 37c2faa has started.
2024-09-05 12:44:20 UTC ya make is running...
🟢 2024-09-05 13:16:36 UTC Build successful.

Copy link

github-actions bot commented Sep 5, 2024

2024-09-05 12:43:41 UTC Pre-commit check linux-x86_64-relwithdebinfo for 37c2faa has started.
2024-09-05 12:48:06 UTC ya make is running...
🟡 2024-09-05 14:15:20 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
40648 35200 0 7 5419 22

2024-09-05 14:18:53 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-09-05 14:29:48 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
45 (only retried tests) 26 0 1 0 18

2024-09-05 14:29:57 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-09-05 14:42:04 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
24 (only retried tests) 5 0 1 0 18

🟢 2024-09-05 14:42:11 UTC Build successful.
🟡 2024-09-05 14:42:53 UTC ydbd size 8.4 GiB changed* by +523.5 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: f499f08 merge: 37c2faa diff diff %
ydbd size 8 999 784 520 Bytes 9 000 320 624 Bytes +523.5 KiB +0.006%
ydbd stripped size 486 649 608 Bytes 486 649 544 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 5, 2024

2024-09-05 12:50:17 UTC Pre-commit check linux-x86_64-release-asan for 37c2faa has started.
2024-09-05 12:54:10 UTC ya make is running...
🔴 2024-09-05 14:55:45 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11407 11324 0 25 28 30

🟢 2024-09-05 14:56:45 UTC Build successful.
🟡 2024-09-05 14:57:18 UTC ydbd size 5.6 GiB changed* by +312.2 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: f499f08 merge: 37c2faa diff diff %
ydbd size 6 017 842 536 Bytes 6 018 162 248 Bytes +312.2 KiB +0.005%
ydbd stripped size 1 507 089 904 Bytes 1 507 089 648 Bytes -256 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@maximyurchuk maximyurchuk added the rebase-and-check Rebase PR with the current main and check label Sep 6, 2024
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current main and check label Sep 6, 2024
Copy link

github-actions bot commented Sep 6, 2024

2024-09-06 11:00:12 UTC Pre-commit check linux-x86_64-release-asan for 6e9baef has started.
2024-09-06 11:03:21 UTC ya make is running...
🔴 2024-09-06 13:16:48 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11425 11302 0 54 35 34

🟢 2024-09-06 13:17:58 UTC Build successful.
🟡 2024-09-06 13:18:31 UTC ydbd size 5.6 GiB changed* by +312.2 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 4782b8a merge: 6e9baef diff diff %
ydbd size 6 028 980 992 Bytes 6 029 300 704 Bytes +312.2 KiB +0.005%
ydbd stripped size 1 509 663 536 Bytes 1 509 663 280 Bytes -256 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 6, 2024

2024-09-06 11:02:21 UTC Pre-commit check linux-x86_64-release-clang14 for 6e9baef has started.
2024-09-06 11:05:27 UTC ya make is running...
🟢 2024-09-06 11:37:45 UTC Build successful.

Copy link

github-actions bot commented Sep 6, 2024

2024-09-06 11:03:26 UTC Pre-commit check linux-x86_64-relwithdebinfo for 6e9baef has started.
2024-09-06 11:06:48 UTC ya make is running...
🟡 2024-09-06 12:40:43 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
40664 35144 0 69 5427 24

2024-09-06 12:44:24 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-09-06 12:54:28 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
107 (only retried tests) 89 0 0 0 18

🟢 2024-09-06 12:54:35 UTC Build successful.
🟡 2024-09-06 12:55:35 UTC ydbd size 8.4 GiB changed* by +523.5 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 4782b8a merge: 6e9baef diff diff %
ydbd size 9 013 371 016 Bytes 9 013 907 120 Bytes +523.5 KiB +0.006%
ydbd stripped size 487 291 688 Bytes 487 291 624 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

static typename ColumnType::Type GetDefaultValue(SFINAE::general) {
return typename ColumnType::Type();
static typename ColumnType::Type GetDefaultValue() {
if constexpr (NDetail::HasDefault<ColumnType>::value) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, it would be much easier to use "requires" statement for that

if constexpr (NDetail::HasDefault<ColumnType>::value) {
return ColumnType::Default;
}
else {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't write "else" on a new line

Copy link

github-actions bot commented Sep 9, 2024

2024-09-09 09:24:07 UTC Pre-commit check linux-x86_64-relwithdebinfo for e37b77e has started.
2024-09-09 09:27:19 UTC ya make is running...
🟡 2024-09-09 10:59:52 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
40682 35207 0 14 5430 31

2024-09-09 11:03:35 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-09-09 11:13:45 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
55 (only retried tests) 32 0 5 0 18

2024-09-09 11:13:54 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-09-09 11:25:51 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
28 (only retried tests) 6 0 5 0 17

🟢 2024-09-09 11:25:58 UTC Build successful.
🟡 2024-09-09 11:26:40 UTC ydbd size 8.4 GiB changed* by +536.5 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 68c8f3f merge: e37b77e diff diff %
ydbd size 9 017 352 288 Bytes 9 017 901 696 Bytes +536.5 KiB +0.006%
ydbd stripped size 487 429 128 Bytes 487 429 064 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 9, 2024

2024-09-09 09:25:51 UTC Pre-commit check linux-x86_64-release-clang14 for e37b77e has started.
2024-09-09 09:30:02 UTC ya make is running...
🟢 2024-09-09 10:01:38 UTC Build successful.

Copy link

github-actions bot commented Sep 9, 2024

2024-09-09 09:26:40 UTC Pre-commit check linux-x86_64-release-asan for e37b77e has started.
2024-09-09 09:29:50 UTC ya make is running...
🔴 2024-09-09 11:42:05 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11430 11299 0 44 47 40

🟢 2024-09-09 11:43:03 UTC Build successful.
🟡 2024-09-09 11:43:40 UTC ydbd size 5.6 GiB changed* by +311.9 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 68c8f3f merge: e37b77e diff diff %
ydbd size 6 032 161 600 Bytes 6 032 480 960 Bytes +311.9 KiB +0.005%
ydbd stripped size 1 510 169 648 Bytes 1 510 169 456 Bytes -192 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@maximyurchuk maximyurchuk added the rebase-and-check Rebase PR with the current main and check label Sep 9, 2024
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current main and check label Sep 9, 2024
Copy link

github-actions bot commented Sep 9, 2024

2024-09-09 12:32:41 UTC Pre-commit check linux-x86_64-release-clang14 for 012d343 has started.
2024-09-09 12:35:39 UTC ya make is running...
🟢 2024-09-09 13:05:10 UTC Build successful.

Copy link

github-actions bot commented Sep 9, 2024

2024-09-09 12:37:11 UTC Pre-commit check linux-x86_64-relwithdebinfo for 012d343 has started.
2024-09-09 12:41:31 UTC ya make is running...
🟡 2024-09-09 14:13:17 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
40674 35209 0 12 5428 25

2024-09-09 14:16:50 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-09-09 14:27:18 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
52 (only retried tests) 28 0 5 0 19

2024-09-09 14:27:27 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-09-09 14:36:09 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
30 (only retried tests) 6 0 5 0 19

🟢 2024-09-09 14:36:15 UTC Build successful.
🟡 2024-09-09 14:36:55 UTC ydbd size 8.4 GiB changed* by +536.5 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: d7a78d0 merge: 012d343 diff diff %
ydbd size 9 017 351 232 Bytes 9 017 900 640 Bytes +536.5 KiB +0.006%
ydbd stripped size 487 427 464 Bytes 487 427 400 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 9, 2024

2024-09-09 12:41:45 UTC Pre-commit check linux-x86_64-release-asan for 012d343 has started.
2024-09-09 12:45:52 UTC ya make is running...
🔴 2024-09-09 14:49:05 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11426 11311 0 36 46 33

🟢 2024-09-09 14:50:07 UTC Build successful.
🟡 2024-09-09 14:50:43 UTC ydbd size 5.6 GiB changed* by +311.9 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: d7a78d0 merge: 012d343 diff diff %
ydbd size 6 032 166 104 Bytes 6 032 485 448 Bytes +311.9 KiB +0.005%
ydbd stripped size 1 510 171 088 Bytes 1 510 170 896 Bytes -192 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@maximyurchuk maximyurchuk added the rebase-and-check Rebase PR with the current main and check label Sep 9, 2024
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current main and check label Sep 9, 2024
Copy link

github-actions bot commented Sep 9, 2024

2024-09-09 15:43:29 UTC Pre-commit check linux-x86_64-release-asan for abf98ec has started.
2024-09-09 15:47:30 UTC ya make is running...
🔴 2024-09-09 17:42:32 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11425 11334 0 28 30 33

🟢 2024-09-09 17:43:32 UTC Build successful.
🟡 2024-09-09 17:44:03 UTC ydbd size 5.6 GiB changed* by +311.8 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: d22f086 merge: abf98ec diff diff %
ydbd size 6 036 482 440 Bytes 6 036 801 736 Bytes +311.8 KiB +0.005%
ydbd stripped size 1 511 083 248 Bytes 1 511 082 992 Bytes -256 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 9, 2024

2024-09-09 15:54:21 UTC Pre-commit check linux-x86_64-release-clang14 for abf98ec has started.
2024-09-09 15:57:47 UTC ya make is running...
🟢 2024-09-09 16:30:06 UTC Build successful.

Copy link

github-actions bot commented Sep 9, 2024

2024-09-09 15:58:20 UTC Pre-commit check linux-x86_64-relwithdebinfo for abf98ec has started.
2024-09-09 16:01:21 UTC ya make is running...
🟡 2024-09-09 17:28:52 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
40687 35205 0 20 5438 24

2024-09-09 17:32:42 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-09-09 17:44:54 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
61 (only retried tests) 33 0 2 8 18

2024-09-09 17:45:02 UTC ya make is running... (failed tests rerun, try 3)
🟢 2024-09-09 17:52:40 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
31 (only retried tests) 14 0 0 0 17

🟢 2024-09-09 17:52:47 UTC Build successful.
🟡 2024-09-09 17:53:24 UTC ydbd size 8.4 GiB changed* by +536.5 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: d22f086 merge: abf98ec diff diff %
ydbd size 9 023 440 064 Bytes 9 023 989 472 Bytes +536.5 KiB +0.006%
ydbd stripped size 487 701 480 Bytes 487 701 416 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@maximyurchuk maximyurchuk merged commit 2570267 into ydb-platform:main Sep 10, 2024
16 of 22 checks passed
@shnikd shnikd mentioned this pull request Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants