Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reporting of initial VDisk status to SysView #8853

Conversation

alexvru
Copy link
Collaborator

@alexvru alexvru commented Sep 6, 2024

Changelog entry

Fix reporting of initial VDisk status to SysView

Changelog category

  • Bugfix

Additional information

Fixed reporting mechanism for just-created VDisks and just-loaded BSC to prevent false-positives in system views.

@github-actions github-actions bot added the bugfix label Sep 6, 2024
Copy link

github-actions bot commented Sep 6, 2024

2024-09-06 10:46:41 UTC Pre-commit check linux-x86_64-release-asan for cba0670 has started.
2024-09-06 10:49:31 UTC ya make is running...
2024-09-06 11:27:27 UTC Check cancelled

Copy link

github-actions bot commented Sep 6, 2024

2024-09-06 10:46:56 UTC Pre-commit check linux-x86_64-release-clang14 for cba0670 has started.
2024-09-06 10:49:50 UTC ya make is running...
🟢 2024-09-06 11:05:28 UTC Build successful.

Copy link

github-actions bot commented Sep 6, 2024

2024-09-06 10:50:49 UTC Pre-commit check linux-x86_64-relwithdebinfo for cba0670 has started.
2024-09-06 10:53:48 UTC ya make is running...
2024-09-06 11:27:33 UTC Check cancelled

@alexvru alexvru force-pushed the bsdc/fix-initial-vdisk-status-sys-view-reporting branch from 6f4c89c to e0d5d95 Compare September 6, 2024 11:26
Copy link

github-actions bot commented Sep 6, 2024

2024-09-06 11:29:51 UTC Pre-commit check linux-x86_64-release-clang14 for 561dc03 has started.
2024-09-06 11:32:33 UTC ya make is running...
🟢 2024-09-06 11:39:14 UTC Build successful.

Copy link

github-actions bot commented Sep 6, 2024

2024-09-06 11:34:07 UTC Pre-commit check linux-x86_64-release-asan for 561dc03 has started.
2024-09-06 11:36:58 UTC ya make is running...
🔴 2024-09-06 13:19:35 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10292 10195 0 34 34 29

🟢 2024-09-06 13:20:37 UTC Build successful.
🟢 2024-09-06 13:21:08 UTC ydbd size 5.6 GiB changed* by +9.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 5977654 merge: 561dc03 diff diff %
ydbd size 6 028 980 384 Bytes 6 028 990 024 Bytes +9.4 KiB +0.000%
ydbd stripped size 1 509 663 344 Bytes 1 509 664 944 Bytes +1.6 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 6, 2024

2024-09-06 11:39:05 UTC Pre-commit check linux-x86_64-relwithdebinfo for 561dc03 has started.
2024-09-06 11:42:18 UTC ya make is running...
🟡 2024-09-06 12:45:23 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14907 13453 0 65 1364 25

2024-09-06 12:46:42 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-09-06 12:56:52 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
98 (only retried tests) 79 0 0 0 19

🟢 2024-09-06 12:56:59 UTC Build successful.
🟢 2024-09-06 12:57:38 UTC ydbd size 8.4 GiB changed* by +18.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 5977654 merge: 561dc03 diff diff %
ydbd size 9 013 370 168 Bytes 9 013 388 552 Bytes +18.0 KiB +0.000%
ydbd stripped size 487 291 560 Bytes 487 292 264 Bytes +704 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@alexvru alexvru self-assigned this Sep 6, 2024
@alexvru alexvru enabled auto-merge (squash) September 6, 2024 13:05
@alexvru alexvru merged commit 11a2cb4 into ydb-platform:main Sep 6, 2024
10 of 12 checks passed
@alexvru alexvru deleted the bsdc/fix-initial-vdisk-status-sys-view-reporting branch September 6, 2024 13:41
vporyadke pushed a commit to vporyadke/ydb that referenced this pull request Sep 9, 2024
vporyadke added a commit that referenced this pull request Sep 9, 2024
@shnikd shnikd mentioned this pull request Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants