Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show tests with max RSS #8888

Merged
merged 5 commits into from
Sep 9, 2024

Conversation

maximyurchuk
Copy link
Collaborator

@maximyurchuk maximyurchuk commented Sep 6, 2024

Changelog entry

Added tool to analize report.json result

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

Example is here: https://storage.yandexcloud.net/ydb-gh-logs/ydb-platform/ydb/PR-check/10742818645/ya-x86-64/try_1/summary_report.txt

Copy link

github-actions bot commented Sep 6, 2024

2024-09-06 16:58:28 UTC Pre-commit check linux-x86_64-release-asan for a2ab5d6 has started.
2024-09-06 17:01:54 UTC ya make is running...
🟢 2024-09-06 17:01:59 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2024-09-06 17:02:05 UTC Build successful.

Copy link

github-actions bot commented Sep 6, 2024

2024-09-06 17:01:04 UTC Pre-commit check linux-x86_64-release-clang14 for a2ab5d6 has started.
2024-09-06 17:03:22 UTC ya make is running...
🟢 2024-09-06 17:03:29 UTC Build successful.

Copy link

github-actions bot commented Sep 6, 2024

2024-09-06 17:01:19 UTC Pre-commit check linux-x86_64-relwithdebinfo for a2ab5d6 has started.
2024-09-06 17:03:46 UTC ya make is running...
🟢 2024-09-06 17:03:52 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2024-09-06 17:03:57 UTC Build successful.

Copy link

github-actions bot commented Sep 6, 2024

2024-09-06 17:12:22 UTC Pre-commit check linux-x86_64-release-clang14 for 15da610 has started.
2024-09-06 17:14:37 UTC ya make is running...
🟢 2024-09-06 17:14:46 UTC Build successful.

Copy link

github-actions bot commented Sep 6, 2024

2024-09-06 17:14:38 UTC Pre-commit check linux-x86_64-relwithdebinfo for 15da610 has started.
2024-09-06 17:16:33 UTC Check cancelled

Copy link

github-actions bot commented Sep 6, 2024

2024-09-06 17:14:47 UTC Pre-commit check linux-x86_64-release-asan for 15da610 has started.
2024-09-06 17:16:33 UTC Check cancelled

Copy link

github-actions bot commented Sep 6, 2024

2024-09-06 17:18:05 UTC Pre-commit check linux-x86_64-release-asan for 29c2ce8 has started.
2024-09-06 17:20:20 UTC ya make is running...
🟢 2024-09-06 17:20:25 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2024-09-06 17:20:30 UTC Build successful.

Copy link

github-actions bot commented Sep 6, 2024

2024-09-06 17:18:06 UTC Pre-commit check linux-x86_64-release-clang14 for 29c2ce8 has started.
2024-09-06 17:20:26 UTC ya make is running...
🟢 2024-09-06 17:20:32 UTC Build successful.

Copy link

github-actions bot commented Sep 6, 2024

2024-09-06 17:19:44 UTC Pre-commit check linux-x86_64-relwithdebinfo for 29c2ce8 has started.
2024-09-06 17:23:18 UTC ya make is running...
🟢 2024-09-06 17:23:23 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2024-09-06 17:23:28 UTC Build successful.

Copy link

github-actions bot commented Sep 6, 2024

2024-09-06 17:44:56 UTC Pre-commit check linux-x86_64-release-asan for 1ac07b9 has started.
2024-09-06 17:48:11 UTC ya make is running...
🟢 2024-09-06 17:48:16 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2024-09-06 17:48:21 UTC Build successful.

Copy link

github-actions bot commented Sep 6, 2024

2024-09-06 17:45:04 UTC Pre-commit check linux-x86_64-relwithdebinfo for 1ac07b9 has started.
2024-09-06 17:47:24 UTC ya make is running...
🟢 2024-09-06 17:47:29 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2024-09-06 17:47:34 UTC Build successful.

Copy link

github-actions bot commented Sep 6, 2024

2024-09-06 17:45:07 UTC Pre-commit check linux-x86_64-release-clang14 for 1ac07b9 has started.
2024-09-06 17:47:29 UTC ya make is running...
🟢 2024-09-06 17:47:35 UTC Build successful.

nikitka
nikitka previously approved these changes Sep 9, 2024
summary_path = sys.argv[2]

with open(report_path) as f:
obj = json.loads(f.read())
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

json.load(f)

Copy link
Collaborator Author

@maximyurchuk maximyurchuk Sep 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

with open (summary_path, "w") as f:
f.write("RSS usage by tests, sorted\n\n")
for rss, path in all:
f.write("{} {:.2f} GiB \n".format(path, rss))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think path.strip() is better to use here, because the variable can end with space.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also whitespace before newline character is redundant.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think path.strip() is better to use here, because the variable can end with space.

Don't get it. If path has trailing space it either a bug in ya make, either done purposely, so we have to keep spaces

Also whitespace before newline character is redundant.

Done

import json

if __name__ == "__main__":
report_path = sys.argv[1]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better to use argparse even if we have only two arguments here. Because with argparse.FileType we can pass - for stdin/stdout.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, done

Copy link

github-actions bot commented Sep 9, 2024

2024-09-09 09:37:05 UTC Pre-commit check linux-x86_64-release-clang14 for ba5c9c0 has started.
2024-09-09 09:39:30 UTC ya make is running...
🟢 2024-09-09 09:39:38 UTC Build successful.

Copy link

github-actions bot commented Sep 9, 2024

2024-09-09 09:37:16 UTC Pre-commit check linux-x86_64-release-asan for ba5c9c0 has started.
2024-09-09 09:39:40 UTC ya make is running...
🟢 2024-09-09 09:39:45 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2024-09-09 09:39:50 UTC Build successful.

Copy link

github-actions bot commented Sep 9, 2024

2024-09-09 09:38:34 UTC Pre-commit check linux-x86_64-relwithdebinfo for ba5c9c0 has started.
2024-09-09 09:40:59 UTC ya make is running...
🟢 2024-09-09 09:41:05 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2024-09-09 09:41:10 UTC Build successful.

@maximyurchuk maximyurchuk marked this pull request as ready for review September 9, 2024 09:58
@maximyurchuk maximyurchuk merged commit ba80e77 into ydb-platform:main Sep 9, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants