move redirects to base class #8934

adameat · 2024-09-09T09:41:17Z

Changelog entry

move redirects to base class, solve problem with redirects in serverless databases

Changelog category

Improvement
Bugfix
Not for changelog (changelog entry is not required)

github-actions · 2024-09-09T09:42:58Z

⚪ 2024-09-09 09:42:57 UTC Pre-commit check linux-x86_64-release-clang14 for 09b2657 has started.
⚪ 2024-09-09 09:47:23 UTC ya make is running...
⚫ 2024-09-09 09:52:14 UTC Check cancelled

github-actions · 2024-09-09T09:45:02Z

⚪ 2024-09-09 09:45:01 UTC Pre-commit check linux-x86_64-relwithdebinfo for 09b2657 has started.
⚪ 2024-09-09 09:47:45 UTC ya make is running...
⚫ 2024-09-09 09:52:15 UTC Check cancelled

github-actions · 2024-09-09T09:45:04Z

⚪ 2024-09-09 09:45:04 UTC Pre-commit check linux-x86_64-release-asan for 09b2657 has started.
⚪ 2024-09-09 09:48:01 UTC ya make is running...
⚫ 2024-09-09 09:52:17 UTC Check cancelled

…ess databases

github-actions · 2024-09-09T09:54:24Z

⚪ 2024-09-09 09:54:24 UTC Pre-commit check linux-x86_64-release-clang14 for a14bf6e has started.
⚪ 2024-09-09 09:57:05 UTC ya make is running...
🟢 2024-09-09 10:03:15 UTC Build successful.

github-actions · 2024-09-09T09:54:47Z

⚪ 2024-09-09 09:54:47 UTC Pre-commit check linux-x86_64-release-asan for a14bf6e has started.
⚪ 2024-09-09 09:57:39 UTC ya make is running...
🔴 2024-09-09 11:32:45 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
9914	9822	0	35	28	29

🟢 2024-09-09 11:33:36 UTC Build successful.
🟢 2024-09-09 11:34:08 UTC ydbd size 5.6 GiB changed* by +23.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `68c8f3f`	merge: `a14bf6e`	diff	diff %
ydbd size	6 032 161 600 Bytes	6 032 185 872 Bytes	+23.7 KiB	+0.000%
ydbd stripped size	1 510 169 648 Bytes	1 510 171 568 Bytes	+1.9 KiB	+0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-09-09T09:54:52Z

⚪ 2024-09-09 09:54:51 UTC Pre-commit check linux-x86_64-relwithdebinfo for a14bf6e has started.
⚪ 2024-09-09 09:57:36 UTC ya make is running...
🟡 2024-09-09 11:06:02 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
14362	12956	0	7	1366	33

⚪ 2024-09-09 11:07:20 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-09-09 11:25:36 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
44 (only retried tests)	21	0	5	0	18

⚪ 2024-09-09 11:25:44 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-09-09 11:34:22 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
28 (only retried tests)	6	0	5	0	17

🟢 2024-09-09 11:34:29 UTC Build successful.
🟢 2024-09-09 11:35:17 UTC ydbd size 8.4 GiB changed* by +42.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `68c8f3f`	merge: `a14bf6e`	diff	diff %
ydbd size	9 017 352 288 Bytes	9 017 396 256 Bytes	+42.9 KiB	+0.000%
ydbd stripped size	487 429 128 Bytes	487 427 720 Bytes	-1.4 KiB	-0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

antonkovalenko

solve problem with redirects in serverless databases

could you please describe the problem, how was it reproduced?

adameat · 2024-09-09T10:15:55Z

solve problem with redirects in serverless databases

could you please describe the problem, how was it reproduced?

serverless databases generate unnecessary redirects. they can't be seen, but they only affect performance.

github-actions · 2024-09-09T11:54:42Z

⚪ 2024-09-09 11:54:41 UTC Pre-commit check linux-x86_64-release-clang14 for 49c6a0e has started.
⚪ 2024-09-09 11:57:31 UTC ya make is running...
🟢 2024-09-09 12:03:53 UTC Build successful.

github-actions · 2024-09-09T11:56:25Z

⚪ 2024-09-09 11:56:25 UTC Pre-commit check linux-x86_64-release-asan for 49c6a0e has started.
⚪ 2024-09-09 11:59:19 UTC ya make is running...
🔴 2024-09-09 13:35:32 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
9918	9806	0	42	39	31

🟢 2024-09-09 13:36:29 UTC Build successful.
🟢 2024-09-09 13:37:01 UTC ydbd size 5.6 GiB changed* by +23.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `d7a78d0`	merge: `49c6a0e`	diff	diff %
ydbd size	6 032 166 104 Bytes	6 032 190 376 Bytes	+23.7 KiB	+0.000%
ydbd stripped size	1 510 171 088 Bytes	1 510 173 008 Bytes	+1.9 KiB	+0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-09-09T11:58:21Z

⚪ 2024-09-09 11:58:20 UTC Pre-commit check linux-x86_64-relwithdebinfo for 49c6a0e has started.
⚪ 2024-09-09 12:01:52 UTC ya make is running...
🟡 2024-09-09 12:59:59 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
14358	12942	0	24	1367	25

⚪ 2024-09-09 13:01:26 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-09-09 13:11:39 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
60 (only retried tests)	37	0	5	0	18

⚪ 2024-09-09 13:11:47 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-09-09 13:19:06 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
28 (only retried tests)	6	0	5	0	17

🟢 2024-09-09 13:19:12 UTC Build successful.
🟢 2024-09-09 13:19:56 UTC ydbd size 8.4 GiB changed* by +42.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `d7a78d0`	merge: `49c6a0e`	diff	diff %
ydbd size	9 017 351 232 Bytes	9 017 395 208 Bytes	+42.9 KiB	+0.000%
ydbd stripped size	487 427 464 Bytes	487 426 056 Bytes	-1.4 KiB	-0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-09-10T05:44:39Z

⚪ 2024-09-10 05:44:38 UTC Pre-commit check linux-x86_64-release-asan for 0fe6bb3 has started.

github-actions · 2024-09-10T05:44:41Z

⚪ 2024-09-10 05:44:41 UTC Pre-commit check linux-x86_64-release-clang14 for 0fe6bb3 has started.

github-actions · 2024-09-10T05:45:35Z

⚪ 2024-09-10 05:45:34 UTC Pre-commit check linux-x86_64-relwithdebinfo for 0fe6bb3 has started.

github-actions · 2024-09-10T06:41:41Z

⚪ 2024-09-10 06:41:40 UTC Pre-commit check linux-x86_64-relwithdebinfo for e9d0de5 has started.
⚪ 2024-09-10 06:44:26 UTC ya make is running...
🟡 2024-09-10 08:06:07 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
14363	12957	0	6	1374	26

⚪ 2024-09-10 08:07:19 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-09-10 08:18:35 UTC Tests successful.

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
49 (only retried tests)	29	0	0	0	20

🟢 2024-09-10 08:18:41 UTC Build successful.
🟢 2024-09-10 08:19:16 UTC ydbd size 8.4 GiB changed* by -23.5 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash	main: `2570267`	merge: `e9d0de5`	diff	diff %
ydbd size	9 024 250 480 Bytes	9 024 226 416 Bytes	-23.5 KiB	-0.000%
ydbd stripped size	487 707 240 Bytes	487 701 992 Bytes	-5.1 KiB	-0.001%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-09-10T06:41:44Z

⚪ 2024-09-10 06:41:43 UTC Pre-commit check linux-x86_64-release-asan for e9d0de5 has started.
⚪ 2024-09-10 06:44:40 UTC ya make is running...
🔴 2024-09-10 08:58:20 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
9938	9784	0	69	49	36

🟢 2024-09-10 08:59:13 UTC Build successful.
🟢 2024-09-10 08:59:50 UTC ydbd size 5.6 GiB changed* by +23.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `dd142f6`	merge: `e9d0de5`	diff	diff %
ydbd size	6 036 912 800 Bytes	6 036 937 072 Bytes	+23.7 KiB	+0.000%
ydbd stripped size	1 511 084 976 Bytes	1 511 086 896 Bytes	+1.9 KiB	+0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-09-10T06:42:00Z

⚪ 2024-09-10 06:41:59 UTC Pre-commit check linux-x86_64-release-clang14 for e9d0de5 has started.
⚪ 2024-09-10 06:44:52 UTC ya make is running...
🟢 2024-09-10 07:24:05 UTC Build successful.

adameat requested a review from a team as a code owner September 9, 2024 09:41

github-actions bot added the improvement label Sep 9, 2024

adameat enabled auto-merge (squash) September 9, 2024 09:50

alexvru previously approved these changes Sep 9, 2024

View reviewed changes

move redirects to base class, solve problem with redirects in serverl…

24ae4fc

…ess databases

adameat dismissed alexvru’s stale review via 24ae4fc September 9, 2024 09:51

adameat force-pushed the common-redirects branch from ddd010d to 24ae4fc Compare September 9, 2024 09:51

alexvru approved these changes Sep 9, 2024

View reviewed changes

antonkovalenko reviewed Sep 9, 2024

View reviewed changes

antonkovalenko approved these changes Sep 9, 2024

View reviewed changes

adameat added the rebase-and-check Rebase PR with the current main and check label Sep 9, 2024

github-actions bot removed the rebase-and-check Rebase PR with the current main and check label Sep 9, 2024

adameat added the rebase-and-check Rebase PR with the current main and check label Sep 10, 2024

github-actions bot removed the rebase-and-check Rebase PR with the current main and check label Sep 10, 2024

adameat added the rebase-and-check Rebase PR with the current main and check label Sep 10, 2024

github-actions bot removed the rebase-and-check Rebase PR with the current main and check label Sep 10, 2024

adameat merged commit e5a8411 into ydb-platform:main Sep 10, 2024
18 of 27 checks passed

GrigoriyPA mentioned this pull request Sep 10, 2024

YQ-3653 added resource pools classifiers validations #9037

Merged

shnikd mentioned this pull request Sep 11, 2024

Long name domain test #9096

Closed

StekPerepolnen mentioned this pull request Sep 17, 2024

doc hc api images source #9376

Merged

adameat added a commit to adameat/ydb that referenced this pull request Oct 1, 2024

move redirects to base class (ydb-platform#8934)

50ae5d1

adameat added a commit to adameat/ydb that referenced this pull request Oct 4, 2024

move redirects to base class (ydb-platform#8934)

9cd9a27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

move redirects to base class #8934

move redirects to base class #8934

adameat commented Sep 9, 2024

github-actions bot commented Sep 9, 2024 •

edited

Loading

github-actions bot commented Sep 9, 2024 •

edited

Loading

github-actions bot commented Sep 9, 2024 •

edited

Loading

github-actions bot commented Sep 9, 2024 •

edited

Loading

github-actions bot commented Sep 9, 2024 •

edited

Loading

github-actions bot commented Sep 9, 2024 •

edited

Loading

antonkovalenko left a comment

adameat commented Sep 9, 2024

github-actions bot commented Sep 9, 2024 •

edited

Loading

github-actions bot commented Sep 9, 2024 •

edited

Loading

github-actions bot commented Sep 9, 2024 •

edited

Loading

github-actions bot commented Sep 10, 2024

github-actions bot commented Sep 10, 2024

github-actions bot commented Sep 10, 2024

github-actions bot commented Sep 10, 2024 •

edited

Loading

github-actions bot commented Sep 10, 2024 •

edited

Loading

github-actions bot commented Sep 10, 2024 •

edited

Loading

move redirects to base class #8934

move redirects to base class #8934

Conversation

adameat commented Sep 9, 2024

Changelog entry

Changelog category

github-actions bot commented Sep 9, 2024 • edited Loading

github-actions bot commented Sep 9, 2024 • edited Loading

github-actions bot commented Sep 9, 2024 • edited Loading

github-actions bot commented Sep 9, 2024 • edited Loading

github-actions bot commented Sep 9, 2024 • edited Loading

github-actions bot commented Sep 9, 2024 • edited Loading

antonkovalenko left a comment

Choose a reason for hiding this comment

adameat commented Sep 9, 2024

github-actions bot commented Sep 9, 2024 • edited Loading

github-actions bot commented Sep 9, 2024 • edited Loading

github-actions bot commented Sep 9, 2024 • edited Loading

github-actions bot commented Sep 10, 2024

github-actions bot commented Sep 10, 2024

github-actions bot commented Sep 10, 2024

github-actions bot commented Sep 10, 2024 • edited Loading

github-actions bot commented Sep 10, 2024 • edited Loading

github-actions bot commented Sep 10, 2024 • edited Loading

github-actions bot commented Sep 9, 2024 •

edited

Loading

github-actions bot commented Sep 9, 2024 •

edited

Loading

github-actions bot commented Sep 9, 2024 •

edited

Loading

github-actions bot commented Sep 9, 2024 •

edited

Loading

github-actions bot commented Sep 9, 2024 •

edited

Loading

github-actions bot commented Sep 9, 2024 •

edited

Loading

github-actions bot commented Sep 9, 2024 •

edited

Loading

github-actions bot commented Sep 9, 2024 •

edited

Loading

github-actions bot commented Sep 9, 2024 •

edited

Loading

github-actions bot commented Sep 10, 2024 •

edited

Loading

github-actions bot commented Sep 10, 2024 •

edited

Loading

github-actions bot commented Sep 10, 2024 •

edited

Loading