Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CLI max partitions default #8944

Merged
merged 1 commit into from
Sep 9, 2024
Merged

Fix CLI max partitions default #8944

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions ydb/public/lib/ydb_cli/commands/ydb_service_topic.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,8 +304,7 @@ namespace {

config.Opts->AddLongOption("auto-partitioning-max-partitions-count", "Maximum number of partitions for topic")
.Optional()
.StoreResult(&MaxActivePartitions_)
.DefaultValue(1);
.StoreResult(&MaxActivePartitions_);
AddAutoPartitioning(config, false);
}

Expand All @@ -329,7 +328,11 @@ namespace {
GetAutoPartitioningUpUtilizationPercent() ? *GetAutoPartitioningUpUtilizationPercent() : 0,
GetAutoPartitioninDownUtilizationPercent() ? *GetAutoPartitioninDownUtilizationPercent() : 0);

settings.PartitioningSettings(MinActivePartitions_, MaxActivePartitions_, autoscaleSettings);
ui32 finalMaxActivePartitions = MaxActivePartitions_.Defined() ? *MaxActivePartitions_
: autoscaleSettings.GetStrategy() != NTopic::EAutoPartitioningStrategy::Disabled ? MinActivePartitions_ + 50
: MinActivePartitions_;

settings.PartitioningSettings(MinActivePartitions_, finalMaxActivePartitions, autoscaleSettings);
settings.PartitionWriteBurstBytes(PartitionWriteSpeedKbps_ * 1_KB);
settings.PartitionWriteSpeedBytesPerSecond(PartitionWriteSpeedKbps_ * 1_KB);

Expand Down
3 changes: 1 addition & 2 deletions ydb/public/lib/ydb_cli/commands/ydb_service_topic.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,8 +71,7 @@ namespace NYdb::NConsoleClient {
ui64 RetentionPeriodHours_;
ui64 RetentionStorageMb_;
ui32 MinActivePartitions_;
ui32 MaxActivePartitions_;

TMaybe<ui32> MaxActivePartitions_;
ui32 PartitionWriteSpeedKbps_;
};

Expand Down