Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditionally compile the code that uses AWS to pass windows build #8966

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

jepett0
Copy link
Collaborator

@jepett0 jepett0 commented Sep 9, 2024

This commit (#8823) breaks:

  1. windows build in arcadia
  2. RTMR tests in arcadia

This PR fixes the first problem (broken windows build). The second problem cannot be fixed in GitHub and must be fixed in the next import to arcadia/contrib PR. (The fix is ready.)

Copy link

github-actions bot commented Sep 9, 2024

2024-09-09 14:21:31 UTC Pre-commit check linux-x86_64-release-asan for 0c61db8 has started.
2024-09-09 14:25:37 UTC ya make is running...
🔴 2024-09-09 16:15:11 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11335 11233 0 31 33 38

🟢 2024-09-09 16:16:12 UTC Build successful.
🟡 2024-09-09 16:16:44 UTC ydbd size 5.6 GiB changed* by +140.1 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: b9760d3 merge: 0c61db8 diff diff %
ydbd size 6 032 475 280 Bytes 6 032 618 752 Bytes +140.1 KiB +0.002%
ydbd stripped size 1 510 238 960 Bytes 1 510 261 808 Bytes +22.3 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@@ -1,5 +1,15 @@
LIBRARY(run)

IF (OS_WINDOWS)
CFLAGS(
-DKIKIMR_DISABLE_S3_OPS
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought that KIKIMR_DISABLE_S3_OPS flag would be inherited from ydb/apps/ydbd/ya.make. However, this was not the case in my tests, so I included it here.

Copy link

github-actions bot commented Sep 9, 2024

2024-09-09 14:33:41 UTC Pre-commit check linux-x86_64-relwithdebinfo for 0c61db8 has started.
2024-09-09 14:37:50 UTC ya make is running...
🟡 2024-09-09 15:40:16 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15955 14556 0 4 1365 30

2024-09-09 15:41:44 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-09-09 15:52:02 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
44 (only retried tests) 24 0 0 0 20

🟢 2024-09-09 15:52:09 UTC Build successful.
🟢 2024-09-09 15:52:46 UTC ydbd size 8.4 GiB changed* by -64 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 4d73159 merge: 0c61db8 diff diff %
ydbd size 9 017 890 560 Bytes 9 017 890 496 Bytes -64 Bytes -0.000%
ydbd stripped size 487 442 888 Bytes 487 442 888 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 9, 2024

2024-09-09 14:35:42 UTC Pre-commit check linux-x86_64-release-clang14 for 0c61db8 has started.
2024-09-09 14:38:54 UTC ya make is running...
🟢 2024-09-09 14:45:15 UTC Build successful.

@jepett0 jepett0 marked this pull request as ready for review September 9, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants