Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix concurrent rw hash map #9008

Merged
merged 2 commits into from
Sep 10, 2024

Conversation

alexd65536
Copy link
Collaborator

Changelog category

  • Bugfix

Copy link

github-actions bot commented Sep 10, 2024

2024-09-10 11:24:48 UTC Pre-commit check linux-x86_64-release-asan for b5d7130 has started.
2024-09-10 11:24:58 UTC Artifacts will be uploaded here
2024-09-10 11:28:05 UTC ya make is running...
🔴 2024-09-10 13:51:25 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11537 11281 0 91 74 91

🟢 2024-09-10 13:52:28 UTC Build successful.
🟢 2024-09-10 13:53:09 UTC ydbd size 5.6 GiB changed* by +5.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: f11c0b2 merge: b5d7130 diff diff %
ydbd size 6 037 343 296 Bytes 6 037 348 408 Bytes +5.0 KiB +0.000%
ydbd stripped size 1 511 159 472 Bytes 1 511 160 944 Bytes +1.4 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

snaury
snaury previously approved these changes Sep 10, 2024
Copy link

github-actions bot commented Sep 10, 2024

2024-09-10 11:25:57 UTC Pre-commit check linux-x86_64-release-clang14 for b5d7130 has started.
2024-09-10 11:26:06 UTC Artifacts will be uploaded here
2024-09-10 11:29:07 UTC ya make is running...
🟢 2024-09-10 12:12:06 UTC Build successful.

Copy link

github-actions bot commented Sep 10, 2024

2024-09-10 11:27:03 UTC Pre-commit check linux-x86_64-relwithdebinfo for b5d7130 has started.
2024-09-10 11:27:14 UTC Artifacts will be uploaded here
2024-09-10 11:30:15 UTC ya make is running...
🟡 2024-09-10 13:10:29 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
40807 35219 0 60 5460 68

2024-09-10 13:14:02 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-09-10 13:26:19 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
165 (only retried tests) 44 0 53 14 54

2024-09-10 13:26:27 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-09-10 13:38:33 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
127 (only retried tests) 7 0 53 14 53

🟢 2024-09-10 13:38:41 UTC Build successful.
🟢 2024-09-10 13:39:33 UTC ydbd size 8.4 GiB changed* by +32 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: f11c0b2 merge: b5d7130 diff diff %
ydbd size 9 024 522 640 Bytes 9 024 522 672 Bytes +32 Bytes +0.000%
ydbd stripped size 487 708 840 Bytes 487 709 096 Bytes +256 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@alexd65536 alexd65536 changed the title fix concurrent hash map fix concurrent rw hash map Sep 10, 2024
@github-actions github-actions bot added bugfix and removed bugfix labels Sep 10, 2024
Copy link

github-actions bot commented Sep 10, 2024

2024-09-10 14:16:24 UTC Pre-commit check linux-x86_64-release-clang14 for 13bab15 has started.
2024-09-10 14:16:35 UTC Artifacts will be uploaded here
2024-09-10 14:19:39 UTC ya make is running...
🟢 2024-09-10 14:33:22 UTC Build successful.

Copy link

github-actions bot commented Sep 10, 2024

2024-09-10 14:17:42 UTC Pre-commit check linux-x86_64-relwithdebinfo for 13bab15 has started.
2024-09-10 14:17:54 UTC Artifacts will be uploaded here
2024-09-10 14:20:52 UTC ya make is running...
🟡 2024-09-10 17:02:50 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
41047 35330 0 7 5675 35

2024-09-10 17:07:31 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-09-10 17:17:50 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
292 (only retried tests) 202 0 0 7 83

🟢 2024-09-10 17:17:59 UTC Build successful.
🟢 2024-09-10 17:18:39 UTC ydbd size 8.4 GiB changed* by +75.3 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: ce3201c merge: 13bab15 diff diff %
ydbd size 9 026 362 848 Bytes 9 026 439 968 Bytes +75.3 KiB +0.001%
ydbd stripped size 487 745 192 Bytes 487 750 952 Bytes +5.6 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 10, 2024

2024-09-10 14:18:36 UTC Pre-commit check linux-x86_64-release-asan for 13bab15 has started.
2024-09-10 14:20:01 UTC Artifacts will be uploaded here
2024-09-10 14:22:58 UTC ya make is running...
🔴 2024-09-10 16:02:49 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11764 11615 0 18 36 95

🟢 2024-09-10 16:04:00 UTC Build successful.
🟢 2024-09-10 16:04:31 UTC ydbd size 5.6 GiB changed* by +33.2 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: ce3201c merge: 13bab15 diff diff %
ydbd size 6 038 719 744 Bytes 6 038 753 776 Bytes +33.2 KiB +0.001%
ydbd stripped size 1 511 295 472 Bytes 1 511 299 824 Bytes +4.2 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@alexd65536 alexd65536 merged commit 9e26730 into ydb-platform:main Sep 10, 2024
10 of 12 checks passed
@alexd65536 alexd65536 deleted the fix_concurrent_hash branch September 10, 2024 17:52
alexd65536 added a commit to alexd65536/ydb that referenced this pull request Sep 10, 2024
alexd65536 added a commit to alexd65536/ydb that referenced this pull request Sep 10, 2024
alexd65536 added a commit that referenced this pull request Sep 11, 2024
alexd65536 added a commit that referenced this pull request Sep 11, 2024
@shnikd shnikd mentioned this pull request Sep 11, 2024
alexd65536 added a commit to alexd65536/ydb that referenced this pull request Sep 12, 2024
ulya-sidorina pushed a commit to ulya-sidorina/ydb that referenced this pull request Sep 12, 2024
alexd65536 added a commit that referenced this pull request Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants