Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support cancel after in rate limiter #9348

Merged

Conversation

UgnineSirdis
Copy link
Collaborator

Changelog entry

There is a problem in handling operation_timeout parameter during rate limiter request. The ways how in works causes race, when rate limiter can reply OK (and spend resource), but RPC timeout will say to the user that request timeouted.
It is much better to support more safe cancel_after parameter < operation_timeout. In this case response will be consistent with quoter service.

Changelog category

  • New feature

Additional information

...

Copy link

github-actions bot commented Sep 17, 2024

2024-09-17 08:09:06 UTC Pre-commit check linux-x86_64-release-clang14 for 6376757 has started.
2024-09-17 08:09:32 UTC Artifacts will be uploaded here
2024-09-17 08:12:37 UTC ya make is running...
🟢 2024-09-17 08:21:40 UTC Build successful.

Copy link

github-actions bot commented Sep 17, 2024

2024-09-17 08:09:55 UTC Pre-commit check linux-x86_64-release-asan for 6376757 has started.
2024-09-17 08:09:59 UTC Artifacts will be uploaded here
2024-09-17 08:12:55 UTC ya make is running...
🔴 2024-09-17 10:06:29 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
17175 16809 0 37 52 277

🟢 2024-09-17 10:07:56 UTC Build successful.
🟢 2024-09-17 10:08:34 UTC ydbd size 5.6 GiB changed* by +39.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: e8c3843 merge: 6376757 diff diff %
ydbd size 6 045 182 944 Bytes 6 045 223 472 Bytes +39.6 KiB +0.001%
ydbd stripped size 1 513 004 272 Bytes 1 513 011 696 Bytes +7.2 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 17, 2024

2024-09-17 08:09:56 UTC Pre-commit check linux-x86_64-relwithdebinfo for 6376757 has started.
2024-09-17 08:10:00 UTC Artifacts will be uploaded here
2024-09-17 08:12:54 UTC ya make is running...
🟡 2024-09-17 09:26:05 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
79586 65530 0 1 14024 31

2024-09-17 09:33:56 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-09-17 09:41:18 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
269 (only retried tests) 175 0 0 7 87

🟢 2024-09-17 09:41:29 UTC Build successful.
🟢 2024-09-17 09:42:12 UTC ydbd size 8.4 GiB changed* by +53.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: e8c3843 merge: 6376757 diff diff %
ydbd size 9 030 321 240 Bytes 9 030 376 128 Bytes +53.6 KiB +0.001%
ydbd stripped size 488 727 624 Bytes 488 730 824 Bytes +3.1 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@UgnineSirdis UgnineSirdis merged commit a430757 into ydb-platform:main Sep 19, 2024
11 of 13 checks passed
UgnineSirdis added a commit to UgnineSirdis/ydb that referenced this pull request Sep 19, 2024
@shnikd shnikd mentioned this pull request Sep 19, 2024
igormunkin added a commit to igormunkin/ydb that referenced this pull request Sep 26, 2024
There was a typo in mrrun sources, introduced in ydb-platform#9348.
@UgnineSirdis UgnineSirdis deleted the rate-limiter-cancel-after branch October 7, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants