Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Views: throw a human-readable error in case of a missing WITH (security_invoker = true) #9320 #9783

Merged

Conversation

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

@jepett0 jepett0 marked this pull request as ready for review September 26, 2024 15:04
@jepett0 jepett0 requested a review from a team as a code owner September 26, 2024 15:04
fomichev3000
fomichev3000 previously approved these changes Sep 27, 2024
Copy link

github-actions bot commented Sep 27, 2024

2024-09-27 06:59:19 UTC Pre-commit check for 284ff2f has started.
2024-09-27 07:02:01 UTC Build linux-x86_64-release-asan is running...
🟢 2024-09-27 07:48:03 UTC Build successful.
2024-09-27 07:48:18 UTC Tests are running...
🔴 2024-09-27 09:51:55 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13208 13080 0 27 54 47

🔴 2024-09-27 09:52:38 UTC ydbd size 5.6 GiB changed* by +2.1 MiB, which is >= 2.0 MiB vs stable-24-3: Alert

ydbd size dash stable-24-3: 13c2d99 merge: 284ff2f diff diff %
ydbd size 5 958 953 984 Bytes 5 961 137 920 Bytes +2.1 MiB +0.037%
ydbd stripped size 1 491 760 896 Bytes 1 491 881 088 Bytes +117.4 KiB +0.008%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 27, 2024

2024-09-27 06:59:57 UTC Pre-commit check for 284ff2f has started.
2024-09-27 07:02:42 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-09-27 07:48:13 UTC Build successful.

Copy link

github-actions bot commented Sep 27, 2024

2024-09-27 07:00:34 UTC Pre-commit check for 284ff2f has started.
2024-09-27 07:03:22 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-09-27 08:12:24 UTC Build successful.
2024-09-27 08:12:41 UTC Tests are running...
🔴 2024-09-27 10:25:51 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
74282 60810 0 7 13422 43

🟡 2024-09-27 10:26:35 UTC ydbd size 8.2 GiB changed* by +151.2 KiB, which is >= 100.0 KiB vs stable-24-3: Warning

ydbd size dash stable-24-3: f4c79be merge: 284ff2f diff diff %
ydbd size 8 802 729 232 Bytes 8 802 884 064 Bytes +151.2 KiB +0.002%
ydbd stripped size 480 027 208 Bytes 480 041 704 Bytes +14.2 KiB +0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@jepett0 jepett0 merged commit 2829d1a into ydb-platform:stable-24-3 Sep 27, 2024
8 of 12 checks passed
uzhastik pushed a commit to uzhastik/ydb that referenced this pull request Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants