separate-projections-poc: MigrationProjectionCache #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lavrukov
force-pushed
the
separate-projections-poc
branch
4 times, most recently
from
145fb89
to
17e56a5
Compare
lavrukov
commented
Jun 2, 2024
| @@ -494,55 +494,6 @@ default <IN> void bulkUpsert(BulkMapper<IN> mapper, List<IN> input, BulkParams p | |||
| TransactionLocal getTransactionLocal(); | |||
| } | |||
|
|
|||
| public static class CheckingQueryExecutor implements QueryExecutor { | |||
There was a problem hiding this comment.
It doesn't work. I gave birth to this, I will kill it
lavrukov
commented
Jun 2, 2024
| @@ -494,55 +494,6 @@ default <IN> void bulkUpsert(BulkMapper<IN> mapper, List<IN> input, BulkParams p | |||
| TransactionLocal getTransactionLocal(); | |||
| } | |||
|
|
|||
| public static class CheckingQueryExecutor implements QueryExecutor { | |||
There was a problem hiding this comment.
It doesn't work, I gave birth to this, I will kill it
lavrukov
commented
Jun 2, 2024
| public class TransactionLocal { | ||
| private final Map<Supplier<?>, Object> singletons = new IdentityHashMap<>(); |
There was a problem hiding this comment.
I think that this singletons is made for case when in tx wasn't any query. But this objects is lightwave, maybe we can do it without singletons? Else I have to do some painful refactoring for this feature ;(
lavrukov
force-pushed
the
separate-projections-poc
branch
from
17e56a5
to
c9b0228
Compare
This was
linked to
issues
Jun 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.