API: Return error when Mirrors globaly disabled and like to create one (

go-gitea#11757) * API: return an error when Mirrors globaly disabled * keep it consistent with UI Co-authored-by: John Olheiser <[email protected]> Co-authored-by: John Olheiser <[email protected]>
ydelafollye · Jul 31, 2020 · f92edf7 · f92edf7
1 parent 6757c0d
commit f92edf7
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/routers/api/v1/repo/migrate.go b/routers/api/v1/repo/migrate.go
@@ -113,12 +113,16 @@ func Migrate(ctx *context.APIContext, form auth.MigrateRepoForm) {
 		gitServiceType = api.GithubService
 	}
 
+	if form.Mirror && setting.Repository.DisableMirrors {
+		ctx.Error(http.StatusForbidden, "MirrorsGlobalDisabled", fmt.Errorf("the site administrator has disabled mirrors"))
+	}
+
 	var opts = migrations.MigrateOptions{
 		CloneAddr:      remoteAddr,
 		RepoName:       form.RepoName,
 		Description:    form.Description,
 		Private:        form.Private || setting.Repository.ForcePrivate,
-		Mirror:         form.Mirror && !setting.Repository.DisableMirrors,
+		Mirror:         form.Mirror,
 		AuthUsername:   form.AuthUsername,
 		AuthPassword:   form.AuthPassword,
 		Wiki:           form.Wiki,