-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove hard-coded configs in favour of env variables #848
Open
maximilianoertel
wants to merge
297
commits into
main
Choose a base branch
from
ref/project-config
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-composables-create-orgs
…-composables-create-orgs
maximilianoertel
changed the base branch from
main
to
ref/318/query-composables
October 10, 2024 21:27
maximilianoertel
force-pushed
the
ref/project-config
branch
from
October 10, 2024 21:32
b464e1d
to
4d5099e
Compare
maximilianoertel
changed the base branch from
ref/318/query-composables
to
ref/318/query-composables-fetch-error
October 10, 2024 21:33
maximilianoertel
changed the base branch from
ref/318/query-composables-fetch-error
to
ref/318/query-composables-update
October 10, 2024 21:40
maximilianoertel
changed the base branch from
ref/318/query-composables-update
to
main
October 10, 2024 21:41
maximilianoertel
changed the base branch from
main
to
ref/318/query-composables-update
October 10, 2024 21:41
Co-authored-by: Kyle Montville <[email protected]>
Co-authored-by: Kyle Montville <[email protected]>
This reverts commit 4fa5c46.
…mposables-fetch-error
maximilianoertel
changed the base branch from
ref/318/query-composables-update
to
ref/318/query-composables-fetch-error
October 10, 2024 22:01
Base automatically changed from
ref/318/query-composables-fetch-error
to
ref/318/query-composables
October 11, 2024 16:38
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR removes hardcoded Firebase configuration values from the codebase and replaces them with environment variables. This change provides improved security by preventing accidental exposure of sensitive data and allows for easier configuration management across different deployment environments.
Additionally, this PR removes the
.firebaserc
configuration file, following Google's recommendation to exclude it from public repositories to prevent accidental exposure of sensitive information.Key highlights
env-configs
directory..env
file format supported by Vite at the root of the project..env.example
file is provided at the root, serving as a source of truth for supported environment variables.Given the changes in how environment configurations are handled, this PR also restructures the npm commands available on the repo. More specifically, it removes all
dev
andbuild
command variants in favor of two simplenpm run dev
andnpm run build
commands. This is done to avoid accidentally running the command with the wrong environment configuration and better support forks and alternative environments such as ROAR Clinic or Levante.Should you wish to execute a dev or production build with an alternative env configuration, it is recommended to use the
--mode
flag, for examplenpm run build -- --mode production
which would use the.env.production
config.This approach promotes better separation of concerns, improves maintainability, and enhances the overall security posture of the application.
Types of changes
Checklist
Justification of missing checklist items
n/a
Further comments
n/a