Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ROAR package versions #852

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix ROAR package versions #852

wants to merge 1 commit into from

Conversation

richford
Copy link
Contributor

@richford richford commented Oct 4, 2024

Proposed changes

This PR fixes ROAR package versions and bumps ROAR-SWR

Types of changes

What types of changes does this pull request introduce?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (non-breaking change that does not add functionality but makes code cleaner or more efficient)
  • Documentation Update
  • Tests (new or updated tests)
  • Style (changes to code styling)
  • CI (continuous integration changes)
  • Repository Maintenance
  • Other (please describe below)

Checklist

  • I have read the guidelines for contributing.
  • The changes in this PR are as small as they can be. They represent one and only one fix or enhancement.
  • Linting checks pass with my changes.
  • Any existing unit tests pass with my changes.
  • Any existing end-to-end tests pass with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • If this PR fixes an existing issue, I have added a unit or end-to-end test that will detect if this issue reoccurs.
  • I have added JSDoc comments as appropriate.
  • I have added the necessary documentation to the roar-docs repository.
  • I have shared this PR on the roar-pr-reviews channel (if I have access)
  • I have linked relevant issues (if any)

Justification of missing checklist items

Further comments

@richford richford requested a review from a team as a code owner October 4, 2024 19:56
@Emily-ejag Emily-ejag added bug Something isn't working task-update labels Oct 4, 2024
Copy link

github-actions bot commented Oct 4, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 0.98% 73 / 7426
🔵 Statements 0.9% 74 / 8159
🔵 Functions 0.77% 14 / 1806
🔵 Branches 0.44% 20 / 4453
File CoverageNo changed files found.
Generated in workflow #575 for commit 01cf53a by the Vitest Coverage Report Action

Copy link

github-actions bot commented Oct 4, 2024

Visit the preview URL for this PR (updated for commit 01cf53a):

https://roar-staging--pr852-enh-fix-package-vers-1nqk0jrd.web.app

(expires Fri, 11 Oct 2024 20:04:06 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2631e9c58fd0104ecbfddd72a62245ddac467460

Copy link

cypress bot commented Oct 4, 2024

roar-dashboard-e2e    Run #7859

Run Properties:  status check failed Failed #7859  •  git commit 01cf53a3d7: E2E Tests for PR 852 "Fix ROAR package versions" from commit "01cf53a3d766af7cf2...
Project roar-dashboard-e2e
Branch Review enh/fix-package-versions
Run status status check failed Failed #7859
Run duration 27m 23s
Commit git commit 01cf53a3d7: E2E Tests for PR 852 "Fix ROAR package versions" from commit "01cf53a3d766af7cf2...
Committer Adam Richie-Halford
View all properties for this run ↗︎

Test results
Tests that failed  Failures 6
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 26
View all changes introduced in this branch ↗︎

Tests for review

Failed  playSWR.cy.js • 1 failed test

View Output

Test Artifacts
ROAR - Word Play Through > Plays Word with Clever auth Test Replay Screenshots
Failed  playCVA.cy.js • 1 failed test

View Output

Test Artifacts
ROAR - Written Vocabulary Playthrough > Plays CVA with Clever auth Test Replay Screenshots
Failed  playMorphology.cy.js • 1 failed test

View Output

Test Artifacts
ROAR - Written Vocabulary Play Through > Plays Written Vocabulary with Clever auth Test Replay Screenshots
Failed  playVocab.cy.js • 2 failed tests

View Output

Test Artifacts
ROAR - Vocabulary Play Through > Plays Vocabulary with username auth Test Replay Screenshots
ROAR - Vocabulary Play Through > Plays Vocabulary with Clever auth Test Replay Screenshots
Failed  es-tests/playWord-ES.cy.js • 1 failed test

View Output

Test Artifacts
ROAR - Palabra Play Through > Plays Word Test Replay Screenshots

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working task-update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants