-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggested changes for parent sign up e2e test #857
Merged
Emily-ejag
merged 3 commits into
e2e/signup-code-invitation
from
signup-code-invitation-suggested-changes
Oct 8, 2024
Merged
Suggested changes for parent sign up e2e test #857
Emily-ejag
merged 3 commits into
e2e/signup-code-invitation
from
signup-code-invitation-suggested-changes
Oct 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Visit the preview URL for this PR (updated for commit 80af032): https://roar-staging--pr857-signup-code-invitati-b3sqclzx.web.app (expires Tue, 15 Oct 2024 18:31:35 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 2631e9c58fd0104ecbfddd72a62245ddac467460 |
roar-dashboard-e2e Run #7929
Run Properties:
|
Project |
roar-dashboard-e2e
|
Run status |
Passed #7929
|
Run duration | 06m 11s |
Commit |
80af03294e: E2E Tests for PR 857 "Suggested changes for parent sign up e2e test" from commit...
|
Committer | Kyle |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
14
|
Emily-ejag
approved these changes
Oct 8, 2024
Emily-ejag
added a commit
that referenced
this pull request
Oct 11, 2024
* just adding simple test until I can run local * Progress on Invite Users * completing test * uncommenting other orgs * modifying some comments * adding some try catch for the github actions * change to baseUrl * changing .env.example.test * Suggested changes for parent sign up e2e test (#857) * suggested changes for parent sign up e2e test * update workflow with new secrets * remove unncessary then() * updating commands --------- Co-authored-by: Kyle Montville <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Suggested changes to parent sign up code end-to-end test.
Suggestions:
Types of changes
What types of changes does this pull request introduce?
Checklist
Justification of missing checklist items
Further comments