Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing Syntax name on game tabs #858

Merged
merged 4 commits into from
Oct 11, 2024
Merged

Changing Syntax name on game tabs #858

merged 4 commits into from
Oct 11, 2024

Conversation

Emily-ejag
Copy link
Contributor

@Emily-ejag Emily-ejag commented Oct 8, 2024 •
edited
Loading

Proposed changes

Types of changes

What types of changes does this pull request introduce?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (non-breaking change that does not add functionality but makes code cleaner or more efficient)
  • Documentation Update
  • Tests (new or updated tests)
  • Style (changes to code styling)
  • CI (continuous integration changes)
  • Repository Maintenance
  • Other (please describe below)

Checklist

  • I have read the guidelines for contributing.
  • The changes in this PR are as small as they can be. They represent one and only one fix or enhancement.
  • Linting checks pass with my changes.
  • Any existing unit tests pass with my changes.
  • Any existing end-to-end tests pass with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • If this PR fixes an existing issue, I have added a unit or end-to-end test that will detect if this issue reoccurs.
  • I have added JSDoc comments as appropriate.
  • I have added the necessary documentation to the roar-docs repository.
  • I have shared this PR on the roar-pr-reviews channel (if I have access)
  • I have linked relevant issues (if any)

Justification of missing checklist items

Further comments

@Emily-ejag Emily-ejag requested a review from a team as a code owner October 8, 2024 20:05
@Emily-ejag Emily-ejag self-assigned this Oct 8, 2024
@Emily-ejag Emily-ejag added impact: low This is a nice feature to have but low impact on the overall project effort: low Not much effort needed to resolve this issue design-alignment labels Oct 8, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 8, 2024 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 0.98% 73 / 7436
🔵 Statements 0.9% 74 / 8170
🔵 Functions 0.76% 14 / 1825
🔵 Branches 0.45% 20 / 4410
File CoverageNo changed files found.
Generated in workflow #680 for commit 1fee2c6 by the Vitest Coverage Report Action

@cypress Cypress
Copy link

cypress bot commented Oct 8, 2024 •
edited
Loading

roar-dashboard-e2e    Run #8212

Run Properties:  status check passed Passed #8212  •  git commit 1fee2c6ea2: E2E Tests for PR 858 "Changing Syntax name on game tabs" from commit "1fee2c6ea2...
Project roar-dashboard-e2e
Run status status check passed Passed #8212
Run duration 03m 22s
Commit git commit 1fee2c6ea2: E2E Tests for PR 858 "Changing Syntax name on game tabs" from commit "1fee2c6ea2...
Committer Emily Arteaga
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 13

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 8, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit 1fee2c6):

https://roar-staging--pr858-fix-syntax-name-c6o0xj29.web.app

(expires Fri, 18 Oct 2024 16:42:21 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2631e9c58fd0104ecbfddd72a62245ddac467460

ksmontville
ksmontville previously approved these changes Oct 9, 2024
View reviewed changes
richford
richford requested changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@richford richford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we also change in src/translations/en/en-componentTranslations.json and in cypress/e2e/pre-release-tests/testOpenAdministrations.cy.js?

@Emily-ejag
Copy link
Contributor Author

Shouldn't we also change in src/translations/en/en-componentTranslations.json and in cypress/e2e/pre-release-tests/testOpenAdministrations.cy.js?

Done

@kellyel
Copy link
Collaborator

kellyel commented Oct 9, 2024

Do we want to stylize Roar as ROAR? ROAR - Syntax vs Roar - Syntax. We use the all-caps stylizing in other places in the project.

@Emily-ejag
Copy link
Contributor Author

Do we want to stylize Roar as ROAR? ROAR - Syntax vs Roar - Syntax. We use the all-caps stylizing in other places in the project.

Good point, I will change them

@Emily-ejag Emily-ejag merged commit 5a08dfc into main Oct 11, 2024
24 checks passed
@Emily-ejag Emily-ejag deleted the fix/syntax-name branch October 11, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richford richford richford approved these changes

@kellyel kellyel kellyel approved these changes

@ksmontville ksmontville Awaiting requested review from ksmontville

Assignees

@Emily-ejag Emily-ejag

Labels
design-alignment effort: low Not much effort needed to resolve this issue impact: low This is a nice feature to have but low impact on the overall project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Emily-ejag @kellyel @richford @ksmontville