-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust E2E tests for project configuration changes #863
Open
maximilianoertel
wants to merge
43
commits into
ref/project-config-ci
Choose a base branch
from
ref/project-config-ci-e2e
base: ref/project-config-ci
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Adjust E2E tests for project configuration changes #863
maximilianoertel
wants to merge
43
commits into
ref/project-config-ci
from
ref/project-config-ci-e2e
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roar-dashboard-e2e Run #8266
Run Properties:
|
Project |
roar-dashboard-e2e
|
Run status |
Failed #8266
|
Run duration | 01m 29s |
Commit |
0aa1b0e380: Adjust E2E tests for project configuration changes (#863)
|
Committer | Maximilian Oertel |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
3
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
0
|
Tests for review
NavBar.cy.js • 1 failed test
Test | Artifacts | |
---|---|---|
An uncaught error was detected outside of a test |
Test Replay
Screenshots
|
slots/FilterBar.cy.js • 1 failed test
Test | Artifacts | |
---|---|---|
An uncaught error was detected outside of a test |
Test Replay
Screenshots
|
RoarDataTable.cy.js • 1 failed test
Test | Artifacts | |
---|---|---|
An uncaught error was detected outside of a test |
Test Replay
Screenshots
|
maximilianoertel
force-pushed
the
ref/project-config-ci
branch
from
October 10, 2024 22:02
72adebc
to
48ea7fe
Compare
maximilianoertel
force-pushed
the
ref/project-config-ci-e2e
branch
from
October 10, 2024 22:04
0a1244c
to
a7e55ec
Compare
maximilianoertel
changed the title
ref/project-config-ci-e2e
Adjust E2E tests for project configuration changes
Oct 10, 2024
maximilianoertel
force-pushed
the
ref/project-config-ci-e2e
branch
from
October 11, 2024 20:59
8220eca
to
3a09730
Compare
maximilianoertel
force-pushed
the
ref/project-config-ci-e2e
branch
from
October 14, 2024 10:29
69b3ddd
to
6465d58
Compare
maximilianoertel
force-pushed
the
ref/project-config-ci-e2e
branch
from
October 14, 2024 13:31
6465d58
to
b8a18ff
Compare
maximilianoertel
force-pushed
the
ref/project-config-ci-e2e
branch
from
October 14, 2024 15:39
c982d63
to
8620452
Compare
maximilianoertel
changed the base branch from
ref/project-config-ci
to
ref/project-config
October 14, 2024 23:11
maximilianoertel
changed the base branch from
ref/project-config
to
ref/project-config-ci
October 14, 2024 23:11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR introduces a series of changes to our E2E tests in order to mostly improve compatibility with the introduced changes related to environment configuration.
Key highlights
CYPRESS_
to follow the Cypress naming practices (docs).env.test
file are parsed bydotenvx
and only variables containing the prefix are loaded into Cypress. Mimicking Cypress's native behaviour, the prefix is stripped before injecting the variables.Additionally, this PR also improves the
login
command by introducing both a redirect assertion and additional validation to ensure the login was successful.Finally, this PR removes (almost) all arbitrary timeouts and refactors both failing and flaky tests. This is mostly achieved by improving selectors, restructuring tests and introducing
waitFor
to await page loads in certain cases. The latter should hopefully be a temporary solution until application performance is improved.Types of changes
Checklist
Justification of missing checklist items
Further comments