-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix administration selection #884
Merged
maximilianoertel
merged 14 commits into
ref/318/query-composables
from
ref/318/query-composables-admin-selection
Oct 14, 2024
Merged
Fix administration selection #884
maximilianoertel
merged 14 commits into
ref/318/query-composables
from
ref/318/query-composables-admin-selection
Oct 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maximilianoertel
changed the base branch from
ref/318/query-composables
to
main
October 14, 2024 20:38
maximilianoertel
changed the base branch from
main
to
ref/318/query-composables
October 14, 2024 20:39
Visit the preview URL for this PR (updated for commit 56f3fca): https://roar-staging--pr884-ref-318-query-compos-63ymn491.web.app (expires Mon, 21 Oct 2024 20:48:25 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 2631e9c58fd0104ecbfddd72a62245ddac467460 |
roar-dashboard-e2e Run #8326
Run Properties:
|
Project |
roar-dashboard-e2e
|
Run status |
Passed #8326
|
Run duration | 03m 45s |
Commit |
56f3fca52c: E2E Tests for PR 884 "Fix administration selection" from commit "56f3fca52c36fb7...
|
Committer | Maximilian Oertel |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
14
|
…es-admin-selection
richford
approved these changes
Oct 14, 2024
Emily-ejag
approved these changes
Oct 14, 2024
maximilianoertel
merged commit Oct 14, 2024
aa1173f
into
ref/318/query-composables
21 of 22 checks passed
maximilianoertel
deleted the
ref/318/query-composables-admin-selection
branch
October 14, 2024 21:18
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR fixes the administration selection following completed assessments.
Types of changes
Checklist
Justification of missing checklist items
n/a
Further comments
n/a
Ref https://github.com/yeatmanlab/roar/issues/318
Fixes #873