Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix administration selection #884

Conversation

maximilianoertel
Copy link
Collaborator

@maximilianoertel maximilianoertel commented Oct 14, 2024

Proposed changes

This PR fixes the administration selection following completed assessments.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (non-breaking change that does not add functionality but makes code cleaner or more efficient)
  • Documentation Update
  • Tests (new or updated tests)
  • Style (changes to code styling)
  • CI (continuous integration changes)
  • Repository Maintenance
  • Other

Checklist

  • I have read the guidelines for contributing.
  • The changes in this PR are as small as they can be. They represent one and only one fix or enhancement.
  • Linting checks pass with my changes.
  • Any existing unit tests pass with my changes.
  • Any existing end-to-end tests pass with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • If this PR fixes an existing issue, I have added a unit or end-to-end test that will detect if this issue reoccurs.
  • I have added JSDoc comments as appropriate.
  • I have added the necessary documentation to the roar-docs repository.
  • I have shared this PR on the roar-pr-reviews channel (if I have access)
  • I have linked relevant issues (if any)

Justification of missing checklist items

n/a

Further comments

n/a

Ref https://github.com/yeatmanlab/roar/issues/318
Fixes #873

@maximilianoertel maximilianoertel requested a review from a team as a code owner October 14, 2024 20:36
@maximilianoertel maximilianoertel changed the base branch from ref/318/query-composables to main October 14, 2024 20:38
@maximilianoertel maximilianoertel changed the base branch from main to ref/318/query-composables October 14, 2024 20:39
Copy link

github-actions bot commented Oct 14, 2024

Visit the preview URL for this PR (updated for commit 56f3fca):

https://roar-staging--pr884-ref-318-query-compos-63ymn491.web.app

(expires Mon, 21 Oct 2024 20:48:25 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2631e9c58fd0104ecbfddd72a62245ddac467460

Copy link

cypress bot commented Oct 14, 2024

roar-dashboard-e2e    Run #8326

Run Properties:  status check passed Passed #8326  •  git commit 56f3fca52c: E2E Tests for PR 884 "Fix administration selection" from commit "56f3fca52c36fb7...
Project roar-dashboard-e2e
Run status status check passed Passed #8326
Run duration 03m 45s
Commit git commit 56f3fca52c: E2E Tests for PR 884 "Fix administration selection" from commit "56f3fca52c36fb7...
Committer Maximilian Oertel
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 14

Copy link

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 5.07% 390 / 7679
🔵 Statements 4.97% 421 / 8454
🔵 Functions 6.09% 115 / 1888
🔵 Branches 2.42% 110 / 4532
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/pages/HomeParticipant.vue 0% 0% 0% 0% 111-115, 117, 119-120, 123-127, 125, 125-126, 129-130, 132-134, 133, 133, 136-138, 137, 137, 140-141, 147-149, 155-157, 159-161, 160, 160, 163, 163, 163-164, 164, 170-172, 174-176, 178-180, 179, 182-184, 183, 186-189, 187, 187-188, 192-196, 198-208, 202-206, 203-205, 207, 210-212, 214-217, 219, 221-223, 225-263, 226, 228-229, 231, 233-249, 234, 236-243, 237, 239-242, 240-241, 245-248, 246-247, 252-258, 253-257, 254-256, 259-263, 260-262, 267-271, 273-277, 280-283, 281-282, 287-329, 288-327, 289-313, 292-294, 299, 299-310, 315-324, 317-323, 318-322, 319-321, 320, 326, 328, 331-333, 332, 332, 335-337, 336, 336, 340-349, 341-348, 344, 352-354, 353, 357-359, 358, 358, 362-368, 363, 363, 365-367, 370-399, 374, 374, 377-379, 378, 381-382, 382, 385-393, 388-390, 389, 392, 396, 1, 10, 12, 27, 45-46, 57, 62, 1-33, 1-48, 50
Generated in workflow #721 for commit 56f3fca by the Vitest Coverage Report Action

@maximilianoertel maximilianoertel self-assigned this Oct 14, 2024
@maximilianoertel maximilianoertel added the bug Something isn't working label Oct 14, 2024
@Emily-ejag Emily-ejag linked an issue Oct 14, 2024 that may be closed by this pull request
@maximilianoertel maximilianoertel merged commit aa1173f into ref/318/query-composables Oct 14, 2024
21 of 22 checks passed
@maximilianoertel maximilianoertel deleted the ref/318/query-composables-admin-selection branch October 14, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Returning to the same administration selected after the game
3 participants