Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enh/Auto Add Pull Requests to QA Template #911

Merged
merged 12 commits into from
Oct 28, 2024
Merged

enh/Auto Add Pull Requests to QA Template #911

merged 12 commits into from
Oct 28, 2024

Conversation

ksmontville
Copy link
Collaborator

@ksmontville ksmontville commented Oct 25, 2024 •
edited
Loading

Proposed changes

This pull request introduces a GitHub action which automatically assigns pull requests to a given project based on label.

A new set of QA labels have been added to the dashboard repo. When a pull request is marked with one of:

  • [qa] low priority
  • [qa] medium priority
  • [qa] high priority

That pull request will be automatically added to a QA project for review. This is a useful automation that will help the QA analysts organize their list of pull request that need testing.

The project URL and personal access token with scoped permissions are stored as repository secrets.

Types of changes

What types of changes does this pull request introduce?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (non-breaking change that does not add functionality but makes code cleaner or more efficient)
  • Documentation Update
  • Tests (new or updated tests)
  • Style (changes to code styling)
  • CI (continuous integration changes)
  • Repository Maintenance
  • Other (please describe below)

Checklist

  • I have read the guidelines for contributing.
  • The changes in this PR are as small as they can be. They represent one and only one fix or enhancement.
  • Linting checks pass with my changes.
  • Any existing unit tests pass with my changes.
  • Any existing end-to-end tests pass with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • If this PR fixes an existing issue, I have added a unit or end-to-end test that will detect if this issue reoccurs.
  • I have added JSDoc comments as appropriate.
  • I have added the necessary documentation to the roar-docs repository.
  • I have shared this PR on the roar-pr-reviews channel (if I have access)
  • I have linked relevant issues (if any)

Justification of missing checklist items

Further comments

@ksmontville ksmontville requested a review from a team as a code owner October 25, 2024 20:39
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 25, 2024 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 5.07% 390 / 7687
🔵 Statements 4.97% 421 / 8462
🔵 Functions 6.09% 115 / 1888
🔵 Branches 2.41% 110 / 4552
File CoverageNo changed files found.
Generated in workflow #804 for commit 10d69dd by the Vitest Coverage Report Action

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 25, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit 10d69dd):

https://roar-staging--pr911-enh-auto-add-prs-to-htkb7bxx.web.app

(expires Mon, 04 Nov 2024 18:45:19 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2631e9c58fd0104ecbfddd72a62245ddac467460

@cypress Cypress
Copy link

cypress bot commented Oct 25, 2024 •
edited
Loading

roar-dashboard-e2e    Run #8708

Run Properties:  status check passed Passed #8708  •  git commit 10d69ddff9: Component Tests for PR 911 "enh/Auto Add Pull Requests to QA Template" from comm...
Project roar-dashboard-e2e
Branch Review enh/auto-add-prs-to-qa-template
Run status status check passed Passed #8708
Run duration 02m 04s
Commit git commit 10d69ddff9: Component Tests for PR 911 "enh/Auto Add Pull Requests to QA Template" from comm...
Committer Kyle
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 17
View all changes introduced in this branch ↗︎

@ksmontville ksmontville added [qa] low priority This is a low priority QA item and removed [qa] low priority This is a low priority QA item labels Oct 25, 2024
@ksmontville ksmontville changed the title Auto Add Pull Requests to QA Template wip/Auto Add Pull Requests to QA Template Oct 25, 2024
@ksmontville ksmontville marked this pull request as draft October 25, 2024 21:28
@ksmontville ksmontville added [qa] low priority This is a low priority QA item and removed [qa] low priority This is a low priority QA item labels Oct 25, 2024
@ksmontville ksmontville self-assigned this Oct 25, 2024
@ksmontville ksmontville added enhancement New feature or request urgency: low This issue can be resolved when time allows impact: medium Medium impact on the project as a whole [qa] low priority This is a low priority QA item [qa] medium priority This is a medium priority QA item [qa] high priority This is a high priority QA item and removed [qa] low priority This is a low priority QA item [qa] medium priority This is a medium priority QA item [qa] high priority This is a high priority QA item labels Oct 25, 2024
@ksmontville ksmontville marked this pull request as ready for review October 28, 2024 17:33
@ksmontville ksmontville changed the title wip/Auto Add Pull Requests to QA Template enh/Auto Add Pull Requests to QA Template Oct 28, 2024
@ksmontville ksmontville added [qa] low priority This is a low priority QA item [qa] high priority This is a high priority QA item and removed [qa] medium priority This is a medium priority QA item labels Oct 28, 2024
@ksmontville ksmontville removed the [qa] high priority This is a high priority QA item label Oct 28, 2024
Emily-ejag
Emily-ejag previously approved these changes Oct 28, 2024
View reviewed changes
@ksmontville ksmontville removed the [qa] low priority This is a low priority QA item label Oct 28, 2024
kellyel
kellyel previously approved these changes Oct 28, 2024
View reviewed changes
Copy link
Collaborator

@kellyel kellyel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat!

@ksmontville ksmontville dismissed stale reviews from kellyel and Emily-ejag via 356ce6c October 28, 2024 18:09
@ksmontville ksmontville added [qa] low priority This is a low priority QA item and removed [qa] low priority This is a low priority QA item labels Oct 28, 2024
@ksmontville ksmontville force-pushed the enh/auto-add-prs-to-qa-template branch from fd19d8f to 7977e87 Compare October 28, 2024 18:24
@ksmontville ksmontville removed the [qa] low priority This is a low priority QA item label Oct 28, 2024
@ksmontville ksmontville force-pushed the enh/auto-add-prs-to-qa-template branch from 7977e87 to 10d69dd Compare October 28, 2024 18:41
@ksmontville ksmontville merged commit 66ef399 into main Oct 28, 2024
24 checks passed
@ksmontville ksmontville deleted the enh/auto-add-prs-to-qa-template branch October 28, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Emily-ejag Emily-ejag Emily-ejag left review comments

@kellyel kellyel kellyel left review comments

Assignees

@ksmontville ksmontville

Labels
enhancement New feature or request impact: medium Medium impact on the project as a whole urgency: low This issue can be resolved when time allows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ksmontville @Emily-ejag @kellyel