Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import PvChart on the card administration component #920

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Import PvChart on the card administration component #920

merged 1 commit into from
Oct 30, 2024

Conversation

kellyel
Copy link
Collaborator

@kellyel kellyel commented Oct 30, 2024

Proposed changes

Fix missing import

Types of changes

What types of changes does this pull request introduce?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (non-breaking change that does not add functionality but makes code cleaner or more efficient)
  • Documentation Update
  • Tests (new or updated tests)
  • Style (changes to code styling)
  • CI (continuous integration changes)
  • Repository Maintenance
  • Other (please describe below)

Checklist

  • I have read the guidelines for contributing.
  • The changes in this PR are as small as they can be. They represent one and only one fix or enhancement.
  • Linting checks pass with my changes.
  • Any existing unit tests pass with my changes.
  • Any existing end-to-end tests pass with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • If this PR fixes an existing issue, I have added a unit or end-to-end test that will detect if this issue reoccurs.
  • I have added JSDoc comments as appropriate.
  • I have added the necessary documentation to the roar-docs repository.
  • I have shared this PR on the roar-pr-reviews channel (if I have access)
  • I have linked relevant issues (if any)

Justification of missing checklist items

Further comments

@kellyel kellyel requested a review from a team as a code owner October 30, 2024 17:57
@github-actions GitHub Actions
Copy link

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 5.11% 390 / 7619
🔵 Statements 5.01% 421 / 8392
🔵 Functions 6.12% 115 / 1879
🔵 Branches 2.41% 110 / 4552
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/components/CardAdministration.vue 0% 0% 0% 0% 182, 184, 196-197, 199, 201-238, 206-228, 211, 213-218, 221-226, 235, 240-244, 241-243, 242, 246-250, 247, 249, 252, 252-253, 253, 255-257, 256, 256, 259-261, 260, 264, 264, 267-268, 270-271, 273-278, 274-276, 275, 277, 280-285, 281-283, 282, 284, 287-290, 288-289, 292-294, 293, 296, 298-300, 302-304, 303, 306-309, 308, 311-313, 312, 312, 315-403, 317-402, 318, 320, 320-321, 321, 323, 325, 329-335, 337-353, 339, 341, 341, 343-350, 355, 359-380, 361-377, 362-372, 367-369, 368, 370, 373, 375-377, 376, 379, 388-398, 389-397, 390-396, 391-395, 392, 392-393, 393-394, 400-401, 405-406, 408-419, 408-419, 421-442, 422-423, 425-426, 428-441, 444-449, 445-448, 446-447, 2, 7-9, 27, 29, 34, 1, 44
Generated in workflow #816 for commit ebcd45b by the Vitest Coverage Report Action

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 30, 2024 •
edited by unfurl-links bot
Loading

Visit the preview URL for this PR (updated for commit ebcd45b):

https://roar-staging--pr920-fix-donut-chart-438worcj.web.app

(expires Wed, 06 Nov 2024 18:01:34 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2631e9c58fd0104ecbfddd72a62245ddac467460

@cypress Cypress
Copy link

cypress bot commented Oct 30, 2024 •
edited
Loading

roar-dashboard-e2e    Run #8765

Run Properties:  status check passed Passed #8765  •  git commit ebcd45bdfb: E2E Tests for PR 920 "Import PvChart on the card administration component" from ...
Project roar-dashboard-e2e
Branch Review fix/donut-chart
Run status status check passed Passed #8765
Run duration 05m 41s
Commit git commit ebcd45bdfb: E2E Tests for PR 920 "Import PvChart on the card administration component" from ...
Committer Elijah Kelly
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 14
View all changes introduced in this branch ↗︎

maximilianoertel
maximilianoertel approved these changes Oct 30, 2024
View reviewed changes
Copy link
Collaborator

@maximilianoertel maximilianoertel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, good catch!

Opening a separate PR to ensure this doesn't happen again: #921

@Emily-ejag Emily-ejag added the bug Something isn't working label Oct 30, 2024
@Emily-ejag Emily-ejag merged commit 9426154 into main Oct 30, 2024
25 checks passed
@Emily-ejag Emily-ejag deleted the fix/donut-chart branch October 30, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximilianoertel maximilianoertel maximilianoertel approved these changes

@Emily-ejag Emily-ejag Emily-ejag approved these changes

Assignees

@kellyel kellyel

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kellyel @maximilianoertel @Emily-ejag