Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simplify assent/consent title #932

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

simplify assent/consent title #932

wants to merge 1 commit into from

Conversation

lucasxsong
Copy link
Collaborator

Proposed changes

Types of changes

What types of changes does this pull request introduce?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (non-breaking change that does not add functionality but makes code cleaner or more efficient)
  • Documentation Update
  • Tests (new or updated tests)
  • Style (changes to code styling)
  • CI (continuous integration changes)
  • Repository Maintenance
  • Other (please describe below)

Checklist

  • I have read the guidelines for contributing.
  • The changes in this PR are as small as they can be. They represent one and only one fix or enhancement.
  • Linting checks pass with my changes.
  • Any existing unit tests pass with my changes.
  • Any existing end-to-end tests pass with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • If this PR fixes an existing issue, I have added a unit or end-to-end test that will detect if this issue reoccurs.
  • I have added JSDoc comments as appropriate.
  • I have added the necessary documentation to the roar-docs repository.
  • I have shared this PR on the roar-pr-reviews channel (if I have access)
  • I have linked relevant issues (if any)

Justification of missing checklist items

Further comments

@lucasxsong lucasxsong requested a review from a team as a code owner November 4, 2024 21:26
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 4, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 5.11% 390 / 7620
🔵 Statements 5.01% 421 / 8393
🔵 Functions 6.12% 115 / 1879
🔵 Branches 2.41% 110 / 4552
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/components/ConsentModal.vue 0% 0% 0% 0% 33-4
Generated in workflow #844 for commit 397708c by the Vitest Coverage Report Action

@cypress Cypress
Copy link

cypress bot commented Nov 4, 2024 •
edited
Loading

roar-dashboard-e2e    Run #8863

Run Properties:  status check passed Passed #8863  •  git commit 397708c249: E2E Tests for PR 932 "simplify assent/consent title" from commit "397708c2499e2e...
Project roar-dashboard-e2e
Branch Review fix/assent-title
Run status status check passed Passed #8863
Run duration 04m 09s
Commit git commit 397708c249: E2E Tests for PR 932 "simplify assent/consent title" from commit "397708c2499e2e...
Committer Lucas Song
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 14
View all changes introduced in this branch ↗︎

@Emily-ejag Emily-ejag added the bug Something isn't working label Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lucasxsong lucasxsong

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucasxsong @Emily-ejag