Update for latest JuliaGeo/GDAL

[yeesian]

No description provided.

[visr]

Should your StringList be updated to match JuliaGeo/GDAL.jl@5069a75?

And supposedly some of your at-gdal lib calls can now be replaced with a GDAL.jl function call? Doesn't have to be part of it, but would be nice if you can drop workarounds :)

It curiously fails locally for me, but haven't found the problem yet.

ArchGDAL: Error During Test
  Got an exception of type LoadError outside of a @test
  LoadError: GDALError (CE_Failure, code 3):
        VSIFReadL(00000000360018E0,6*4) @ 86498296 failed in HFAEntry().
  No error

  Stacktrace:
   [1] gdaljl_errorhandler(::GDAL.CPLErr, ::Int32, ::Cstring) at C:\Users\visser_mn\.julia\v0.6\GDAL\src\error.jl:26
   [2] #unsafe_read#17(::ArchGDAL.GDALOpenFlag, ::Ptr{Ptr{UInt8}}, ::Ptr{Ptr{UInt8}}, ::Ptr{Ptr{UInt8}}, ::Function, ::String) at C:\Users\visser_mn\.julia\v0.6\ArchGDAL\src\dataset.jl:248
   [3] unsafe_read(::String) at C:\Users\visser_mn\.julia\v0.6\ArchGDAL\src\dataset.jl:248
   [4] #read#92(::Array{Any,1}, ::Function, ::##192#204, ::String, ::Vararg{String,N} where N) at C:\Users\visser_mn\.julia\v0.6\ArchGDAL\src\context.jl:81
   [5] #registerdrivers#39(::Array{Any,1}, ::Array{Any,1}, ::Function, ::##191#203) at C:\Users\visser_mn\.julia\v0.6\ArchGDAL\src\context.jl:21
   [6] registerdrivers(::Function) at C:\Users\visser_mn\.julia\v0.6\ArchGDAL\src\context.jl:5

[visr]

Even though AppVeyor is green, it does fail this test, but it's just floating point fuzziness. Maybe good to replace it with something less sensitive? The result is different on different platforms.

Otherwise, LGTM!

[yeesian]

Even though AppVeyor is green, it does fail this test, but it's just floating point fuzziness. Maybe good to replace it with something less sensitive? The result is different on different platforms.

Which test are you referring to?

[visr]

Ah sorry I forgot the link:
https://ci.appveyor.com/project/NgYeeSian/archgdal-jl/build/job/vfuw912r0ke8xkx8#L59

ArchGDAL.jl/test/test_cookbook_geometry.jl

Line 776 in f25b470

@test AG.toJSON(poly) == "{ \"type\": \"Polygon\", \"coordinates\": [ [ [ 1179091.164690328761935, 712782.883845978067257 ], [ 1161053.021822647424415, 667456.268434881232679 ], [ 1214704.933941904921085, 641092.828859039116651 ], [ 1228580.428455505985767, 682719.312399842427112 ], [ 1218405.065812198445201, 721108.180554138729349 ], [ 1179091.164690328761935, 712782.883845978067257 ] ] ] }"

[visr]

I'm still getting the VSIFReadL error above. At first I thought it was unrelated, but on ArchGDAL master I'm not getting it. AppVeyor doesn't see it though. @evetion, do you get the same error locally on Windows?

[evetion]

I'm getting the AG.toJSON failing test. But no VSIFReadL or any other errors.

[visr]

Ok thanks. So lets ignore VSIFReadL and attribute it to my pc being wonky for now. If it keeps popping up or I can reproduce elsewhere (or others reading this see it), we can make an issue.

[yeesian]

Thanks for the review and fixes!