Inconsistent, non-OO or non-declarative tests should be improved

[victornoel]

I noticed during my last PR that the quality standards of cactoos-http's tests are not at their best.

In particular we have many different ways of asserting facts depending on the test class:

• Matchers.equalTo() or new EqualTo() to check equality while most of the time InputHasContent or TextHasString would be perfect (see also Matchers that take String should also take Text cactoos#836).
• assertions on Map.get while Matchers.hasEntry (or its OO equivalent IsMapContaining) could make things more declarative.
• calls to Scalar.value() while SclaraHasValue could be used.
• we should prefer using the Matcher's class constructor instead of the static factory method from Matchers. For example use new StringEndsWith() instead of Matchers.endsWith().

I propose to fix this as soon as possible before cactoos-http becomes bigger and it becomes cumbersome to fix all those problems.

[0crat]

@llorllale/z please, pay attention to this issue

[llorllale]

@victornoel let's follow the same path as in yegor256/cactoos#588

[llorllale]

@0crat in

[0crat]

@0crat in (here)

@llorllale Job #48 is now in scope, role is DEV

[0crat]

Bug was reported, see §29: +15 point(s) just awarded to @victornoel/z

[paulodamaso]

@llorllale I'd like to do this.

[0crat]

The job #48 assigned to @Vatavuk/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this

[Vatavuk]

@0crat wait until llorllale/cactoos-matchers#9 (comment) is merged

[0crat]

@0crat wait until llorllale/cactoos-matchers#9 (comment) is ... (here)

@Vatavuk The impediment for #48 was registered successfully by @Vatavuk/z

[Vatavuk]

@victornoel please close this issue. It was solved in #58

[0crat]

@elenavolokhova/z please review this job completed by @Vatavuk/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

[0crat]

The job #48 is now out of scope

[elenavolokhova]

@0crat quality good

[0crat]

Order was finished, quality is "good": +35 point(s) just awarded to @Vatavuk/z

[0crat]

Quality review completed: +8 point(s) just awarded to @elenavolokhova/z