#1649 MagicNumberCheck removed

pom.xml

@@ -250,7 +250,7 @@ SOFTWARE.
           <plugin>
             <groupId>com.qulice</groupId>
             <artifactId>qulice-maven-plugin</artifactId>
-            <version>0.21.0</version>
+            <version>0.21.1</version>
             <configuration>
               <excludes combine.children="append">
                 <exclude>checkstyle:/src/site/resources/.*</exclude>

src/main/java/org/cactoos/bytes/DigestEnvelope.java

@@ -63,7 +63,6 @@ public abstract class DigestEnvelope implements Bytes {
      * @param algrthm The algorithm
      */
     public DigestEnvelope(final Input input, final String algrthm) {
-        // @checkstyle MagicNumber (1 line)
         this(input, 16 << 10, algrthm);
     }
 

src/main/java/org/cactoos/bytes/HexOf.java

@@ -36,7 +36,6 @@
  * Decodes origin {@link Text} using the hexadecimal encoding scheme.
  *
  * @since 0.30
- * @checkstyle MagicNumberCheck (500 lines)
  */
 public final class HexOf implements Bytes {
     /**

src/main/java/org/cactoos/bytes/InputAsBytes.java

@@ -55,7 +55,6 @@ public final class InputAsBytes implements Bytes {
      * @param input The input
      */
     InputAsBytes(final Input input) {
-        // @checkstyle MagicNumber (1 line)
         this(input, 16 << 10);
     }
 

src/main/java/org/cactoos/bytes/Md5DigestOf.java

@@ -48,7 +48,6 @@ public Md5DigestOf(final Input input) {
      * @param max Buffer size
      */
     public Md5DigestOf(final Input input, final int max) {
-        // @checkstyle MagicNumber (1 line)
         super(input, max, "MD5");
     }
 }

src/main/java/org/cactoos/bytes/ReaderAsBytes.java

@@ -70,7 +70,6 @@ final class ReaderAsBytes implements Bytes {
      * @param cset Charset
      */
     ReaderAsBytes(final Reader rdr, final Charset cset) {
-        // @checkstyle MagicNumber (1 line)
         this(rdr, cset, 16 << 10);
     }
 
@@ -82,7 +81,6 @@ final class ReaderAsBytes implements Bytes {
      * @since 0.13.2
      */
     ReaderAsBytes(final Reader rdr, final CharSequence cset) {
-        // @checkstyle MagicNumber (1 line)
         this(rdr, cset, 16 << 10);
     }
 

src/main/java/org/cactoos/bytes/Sha1DigestOf.java

@@ -48,7 +48,6 @@ public Sha1DigestOf(final Input input) {
      * @param max Buffer size
      */
     public Sha1DigestOf(final Input input, final int max) {
-        // @checkstyle MagicNumber (1 line)
         super(input, max, "SHA-1");
     }
 }

src/main/java/org/cactoos/bytes/Sha256DigestOf.java

@@ -48,7 +48,6 @@ public Sha256DigestOf(final Input input) {
      * @param max Buffer size
      */
     public Sha256DigestOf(final Input input, final int max) {
-        // @checkstyle MagicNumber (1 line)
         super(input, max, "SHA-256");
     }
 }

src/main/java/org/cactoos/func/Retry.java

@@ -57,7 +57,6 @@ public final class Retry<X, Y> implements Func<X, Y> {
      * @param fnc Func original
      */
     public Retry(final Func<X, Y> fnc) {
-        // @checkstyle MagicNumberCheck (1 line)
         this(fnc, 3);
     }
 

src/main/java/org/cactoos/io/GzipInput.java

@@ -50,7 +50,6 @@ public final class GzipInput implements Input {
      * @param input The input.
      */
     public GzipInput(final Input input) {
-        // @checkstyle MagicNumberCheck (1 line)
         this(input, 16 << 10);
     }
 

src/main/java/org/cactoos/io/GzipOutput.java

@@ -50,7 +50,6 @@ public final class GzipOutput implements Output {
      * @param output The output
      */
     public GzipOutput(final Output output) {
-        // @checkstyle MagicNumberCheck (1 line)
         this(output, 16 << 10);
     }
 

src/main/java/org/cactoos/io/TailOf.java

@@ -59,7 +59,6 @@ public final class TailOf implements Input {
      * @param bytes Number of last bytes to show from input
      */
     public TailOf(final Input inpt, final int bytes) {
-        // @checkstyle MagicNumber (1 line)
         this(inpt, bytes, 16384);
     }
 

src/main/java/org/cactoos/io/TempFolder.java

@@ -78,7 +78,6 @@ public TempFolder() {
                             new RangeOf<>('a', 'z', ch -> ++ch)
                         )
                     ),
-                    // @checkstyle MagicNumber (1 line)
                     () -> 5
                 )
             )

src/main/java/org/cactoos/io/WriterAsOutput.java

@@ -70,7 +70,6 @@ final class WriterAsOutput implements Output {
      * @param cset Charset
      */
     WriterAsOutput(final Writer wtr, final Charset cset) {
-        // @checkstyle MagicNumber (1 line)
         this(wtr, cset, 16 << 10);
     }
 

src/main/java/org/cactoos/io/WriterAsOutputStream.java

@@ -80,7 +80,6 @@ final class WriterAsOutputStream extends OutputStream {
      * @param charset Charset
      */
     WriterAsOutputStream(final Writer wtr, final CharSequence charset) {
-        // @checkstyle MagicNumber (1 line)
         this(wtr, charset, 16 << 10);
     }
 
@@ -90,7 +89,6 @@ final class WriterAsOutputStream extends OutputStream {
      * @param charset Charset
      */
     WriterAsOutputStream(final Writer wtr, final Charset charset) {
-        // @checkstyle MagicNumber (1 line)
         this(wtr, charset.name());
     }
 

src/main/java/org/cactoos/iterable/IterableOf.java

@@ -117,7 +117,6 @@ public boolean equals(final Object other) {
         ).value();
     }
 
-    // @checkstyle MagicNumberCheck (30 lines)
     @Override
     public int hashCode() {
         return new Unchecked<>(

src/main/java/org/cactoos/scalar/HashCode.java

@@ -68,7 +68,6 @@ public final class HashCode implements Scalar<Integer> {
      * <p>The {@code initial} and {@code multiplier} values are arbitrarily
      * set to 17 and 31 respectively.
      * @param attributes The object's attributes
-     * @checkstyle MagicNumber (3 lines)
      */
     public HashCode(final Object... attributes) {
         this(new IterableOf<>(attributes));
@@ -80,7 +79,6 @@ public HashCode(final Object... attributes) {
      * <p>The {@code initial} and {@code multiplier} values are arbitrarily
      * set to 17 and 31 respectively.
      * @param attributes The object's attributes
-     * @checkstyle MagicNumber (3 lines)
      */
     public HashCode(final Iterable<?> attributes) {
         this(17, 31, attributes);

src/main/java/org/cactoos/scalar/LengthOf.java

@@ -71,7 +71,6 @@ public LengthOf(final Text text) {
      * @param input The input
      */
     public LengthOf(final Input input) {
-        // @checkstyle MagicNumber (1 line)
         this(input, 16 << 10);
     }
 

src/main/java/org/cactoos/scalar/Retry.java

@@ -84,7 +84,6 @@ public Retry(final Scalar<? extends T> scalar) {
      * @param wait The {@link Duration} to wait between attempts
      */
     public Retry(final Scalar<? extends T> scalar, final Duration wait) {
-        // @checkstyle MagicNumberCheck (1 line)
         this(scalar, 3, wait);
     }
 

src/main/java/org/cactoos/text/HexOf.java

@@ -54,7 +54,6 @@ public HexOf(final Bytes bytes) {
                     final char[] hex = new char[bts.length * 2];
                     int chr = -1;
                     for (int idx = 0; idx < bts.length; ++idx) {
-                        // @checkstyle MagicNumber (3 line)
                         final int value = 0xff & bts[idx];
                         hex[++chr] = HexOf.HEX_CHARS[value >>> 4];
                         hex[++chr] = HexOf.HEX_CHARS[value & 0x0f];

src/test/java/org/cactoos/bytes/BytesOfTest.java

@@ -105,7 +105,6 @@ void readsFromReader() throws Exception {
                         new BytesOf(
                             new StringReader(source),
                             StandardCharsets.UTF_8,
-                            // @checkstyle MagicNumberCheck (1 line)
                             16 << 10
                         )
                     )

src/test/java/org/cactoos/bytes/HexOfTest.java

@@ -36,7 +36,6 @@
  * Test case for {@link HexOf}.
  *
  * @since 0.29
- * @checkstyle MagicNumberCheck (500 line)
  * @checkstyle JavadocMethodCheck (500 line)
  * @checkstyle ClassDataAbstractionCouplingCheck (500 lines)
  */

src/test/java/org/cactoos/collection/ImmutableTest.java

@@ -34,7 +34,6 @@
  * Test case for {@link Immutable}.
  *
  * @since 1.16
- * @checkstyle MagicNumber (500 lines)
  * @checkstyle ClassDataAbstractionCouplingCheck (500 lines)
  */
 @SuppressWarnings("PMD.TooManyMethods")

src/test/java/org/cactoos/collection/NoNullsTest.java

@@ -46,7 +46,6 @@
  *
  * @since 0.35
  * @checkstyle JavadocMethodCheck (500 lines)
- * @checkstyle MagicNumberCheck (500 lines)
  * @checkstyle ClassDataAbstractionCouplingCheck (500 lines)
  */
 @SuppressWarnings("PMD.TooManyMethods")

src/test/java/org/cactoos/experimental/ThreadsTest.java

@@ -42,7 +42,6 @@
  *
  * @since 1.0.0
  * @checkstyle ClassDataAbstractionCouplingCheck (500 lines)
- * @checkstyle MagicNumberCheck (500 lines)
  */
 @SuppressWarnings("PMD.AvoidDuplicateLiterals")
 final class ThreadsTest {

src/test/java/org/cactoos/func/ChainedTest.java

@@ -37,7 +37,6 @@
  *
  * @since 0.7
  * @checkstyle JavadocMethodCheck (500 lines)
- * @checkstyle MagicNumber (500 line)
  */
 final class ChainedTest {
 

src/test/java/org/cactoos/func/FallbackFromTest.java

@@ -35,7 +35,6 @@
  *
  * @since 0.31
  * @checkstyle JavadocMethodCheck (500 lines)
- * @checkstyle MagicNumberCheck (500 lines)
  */
 @SuppressWarnings("unchecked")
 final class FallbackFromTest {

src/test/java/org/cactoos/func/RepeatedTest.java

@@ -38,7 +38,6 @@
  *
  * @since 0.13.1
  * @checkstyle JavadocMethodCheck (500 lines)
- * @checkstyle MagicNumberCheck (500 line)
  */
 final class RepeatedTest {
 

src/test/java/org/cactoos/func/RetryTest.java

@@ -35,7 +35,6 @@
  *
  * @since 0.8
  * @checkstyle JavadocMethodCheck (500 lines)
- * @checkstyle MagicNumberCheck (500 line)
  */
 @SuppressWarnings("PMD.AvoidDuplicateLiterals")
 final class RetryTest {

src/test/java/org/cactoos/io/DirectoryTest.java

@@ -55,7 +55,6 @@ public void listsFilesAndFoldersInDirectory() throws IOException {
         new Assertion<>(
             "must list files in a directory represented by a path",
             new Directory(dir),
-            // @checkstyle MagicNumber (1 line)
             new HasSize(4)
         ).affirm();
     }
@@ -69,7 +68,6 @@ public void listsFilesInDirectoryByFile() throws Exception {
         new Assertion<>(
             "must list files in a directory represented by a file",
             new Directory(file),
-            // @checkstyle MagicNumber (1 line)
             new HasSize(4)
         ).affirm();
     }

src/test/java/org/cactoos/io/HeadInputStreamTest.java

@@ -35,7 +35,6 @@
  *
  * @since 0.31
  * @checkstyle JavadocMethodCheck (500 lines)
- * @checkstyle MagicNumberCheck (500 lines)
  * @checkstyle ClassDataAbstractionCouplingCheck (500 lines)
  */
 @SuppressWarnings("PMD.AvoidDuplicateLiterals")

src/test/java/org/cactoos/io/HeadOfTest.java

@@ -33,7 +33,6 @@
  *
  * @since 0.31
  * @checkstyle JavadocMethodCheck (500 lines)
- * @checkstyle MagicNumberCheck (500 lines)
  */
 final class HeadOfTest {
 

src/test/java/org/cactoos/io/LoggingInputStreamTest.java

@@ -69,7 +69,6 @@ void readEmptyStream() throws IOException {
         new Assertion<>(
             "Empty stream did not return -1",
             stream.read(),
-            // @checkstyle MagicNumberCheck (1 line)
             new IsEqual<>(-1)
         ).affirm();
     }
@@ -79,7 +78,6 @@ void readByteByByte() throws IOException {
         final LoggingInputStream stream = new LoggingInputStream(
             new ByteArrayInputStream(
                 new byte[] {
-                    // @checkstyle MagicNumberCheck (2 lines)
                     (byte) 20,
                     (byte) 10,
                 }
@@ -89,19 +87,16 @@ void readByteByByte() throws IOException {
         new Assertion<>(
             "First byte was not 20",
             stream.read(),
-            // @checkstyle MagicNumberCheck (1 line)
             new IsEqual<>(20)
         ).affirm();
         new Assertion<>(
             "Second byte was not 10",
             stream.read(),
-            // @checkstyle MagicNumberCheck (1 line)
             new IsEqual<>(10)
         ).affirm();
         new Assertion<>(
             "When stream is exhausted it didn't return -1",
             stream.read(),
-            // @checkstyle MagicNumberCheck (1 line)
             new IsEqual<>(-1)
         ).affirm();
     }

src/test/java/org/cactoos/io/LoggingInputTest.java

@@ -156,7 +156,6 @@ void logSkipFromLargeTextFile() throws Exception {
             new ResourceOf("org/cactoos/large-text.txt"),
             "text file",
             logger
-        // @checkstyle MagicNumber (1 line)
         ).stream().skip(100);
         new Assertion<>(
             "Must log skip from text file",
@@ -191,7 +190,6 @@ void logResetFromLargeTextFile() throws Exception {
             "text file",
             logger
         ).stream();
-        // @checkstyle MagicNumber (1 line)
         input.mark(150);
         input.reset();
         new Assertion<>(

src/test/java/org/cactoos/io/ResourceOfTest.java

@@ -54,13 +54,11 @@ public void readsBinaryResource() throws Exception {
                         "org/cactoos/io/ResourceOfTest.class"
                     )
                 ).asBytes(),
-                // @checkstyle MagicNumber (2 lines)
                 0,
                 4
             ),
             new IsEqual<>(
                 new byte[]{
-                    // @checkstyle MagicNumber (1 line)
                     (byte) 0xCA, (byte) 0xFE, (byte) 0xBA, (byte) 0xBE,
                 }
             )

src/test/java/org/cactoos/io/SlowInputStreamTest.java

@@ -32,7 +32,6 @@
  * Test for {@link SlowInputStream}.
  *
  * @since 0.47
- * @checkstyle MagicNumberCheck (40 lines)
  */
 final class SlowInputStreamTest {
 

src/test/java/org/cactoos/io/StickyTest.java

@@ -55,7 +55,6 @@ void readsFileContent() {
                 new Repeated<>(
                     input -> new BytesOf(
                         new TeeInput(input, new DeadOutput())
-                    // @checkstyle MagicNumber (2 lines)
                     ).asBytes().length == 74_536,
                     10
                 )

src/test/java/org/cactoos/io/WriterAsOutputStreamTest.java

@@ -68,7 +68,6 @@ public void writesToByteArray() {
                             baos, StandardCharsets.UTF_8
                         ),
                         StandardCharsets.UTF_8,
-                        // @checkstyle MagicNumber (1 line)
                         13
                     )
                 )
@@ -95,7 +94,6 @@ public void writesLargeContentToFile() throws IOException {
                         new WriterAsOutputStream(
                             writer,
                             StandardCharsets.UTF_8,
-                            // @checkstyle MagicNumber (1 line)
                             345
                         )
                     )
@@ -122,7 +120,6 @@ public void writesToFileAndRemovesIt() throws Exception {
                         new WriterAsOutputStream(
                             writer,
                             StandardCharsets.UTF_8,
-                            // @checkstyle MagicNumber (1 line)
                             345
                         )
                     )