-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
org.cactoos.io.Joined: add a Ctor of Iterable<Input> #1035
Comments
@llorllale/z please, pay attention to this issue |
I disagree. What makes you think this? We do this constantly in secondary constructors. You can think of them as "adapter constructors".
If that's something you need, we can surely implement it. |
@llorllale There is more than one way to look at this.
Using new in a constructor, relying on a concrete implementation rather than interface violates the D in SOLID principles. |
@ilyakharlamov the implementation of the class itself can depend just on the highest abstraction, while having secondary ctors for usability ("user experience") |
…(tests formatting)
…(Input of bytes test)
…(Input of bytes test)
…(Ctor arg rename)
@llorllale can we get a new release of cactoos? The work done for this issue is needed in yegor256/cactoos-http#69 |
@rultor release, tag is |
@llorllale OK, I will release it now. Please check the progress here |
@llorllale Done! FYI, the full log is here (took me 14min) |
@llorllale thx |
@ilyakharlamov this was done by you in PR #1038 |
Job |
This job is not in scope |
org.cactoos.io.Joined in a constructor uses
new ..
.This is valid but calling
new
in a Ctor have a sign of a code smell.I suggest adding a constructor that only takes
Iterable<Input>
The text was updated successfully, but these errors were encountered: