-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
All collections/iterable/etc constructor should accept wildcarded values #1169
Comments
@llorllale/z please, pay attention to this issue |
@0crat in Let's do that, first for iterable and iterator. |
@victornoel Argument "Let's" doesn't match regex |
@0crat in |
@0crat in |
@0crat refuse |
@0crat status |
@fabriciofx The user @fabriciofx/z resigned from #1169, please stop working. Reason for job resignation: Order was cancelled |
@victornoel This is what I know about this job in C63314D6Z, as in §32: |
@fabriciofx Job refused in 5 hours - no penalty, see §6 |
@0crat status |
1 similar comment
@0crat status |
@victornoel This is what I know about this job in C63314D6Z, as in §32:
|
@victornoel This is what I know about this job in C63314D6Z, as in §32:
|
@sereshqua/z please review this job completed by @andreoss/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed |
@0crat quality good |
@rultor release, tag is |
@victornoel OK, I will release it now. Please check the progress here |
@victornoel Oops, I failed. You can see the full log here (spent 5min)
|
@yegor256 it seems rultor in cactoos was setup to execute the build with sonar but I get the error above. I suppose it has worked in the past because I don't remember changing anything about this... do you know if this is expected and what should be done to solve it, either:
|
@yegor256 actually it seems it was meant to send the reports to https://sonarcloud.io/dashboard?id=org.cactoos%3Acactoos (according to the previous working release: https://www.rultor.com/t/21864-624598768) but it is not doing that anymore, so I will investigate a bit first. |
@paulodamaso it seems you removed the sonar configuration in the commit 1e8f4d0, do you know why? |
@rultor release, tag is |
@paulodamaso @yegor256 I've tried to fix this with 51f8686 |
@victornoel OK, I will release it now. Please check the progress here |
@victornoel Oops, I failed. You can see the full log here (spent 9min)
|
@rultor release, tag is |
@victornoel OK, I will release it now. Please check the progress here |
@victornoel Oops, I failed. You can see the full log here (spent 8min)
|
@yegor256 it seems the |
@victornoel @yegor256 The problem seems to be similar to jcabi/jcabi-jdbc#86 |
@andreoss yes, totally, thx |
The following code has two problems with typing:
The problem is that collections are covariant with their parameter (at least) but the current declaration of the constructors of classes like
Joined
, or evenListOf
andIterableOf
fail to capture that:If they were declared as:
Then they could be usable more generally and without incurring any problem.
The same problem can happen with say
And
:I believe all of our constructors should accept covariant version of the collection they take, especially those that mixes collections with a single item (as in
Joined
) so as to help Java inference, and those that mixes collection with say aScalar
or aProc
(as inAnd
) to ease composition.The text was updated successfully, but these errors were encountered: