-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unnecessary code to create SSL conection in InputOfTest #1443
Comments
@fabriciofx indeed, I'm not sure why it was setup like that... |
@0crat in |
@fabriciofx let's use takes here to serve an https file without relying on an external web resource that requires internet connectivity to work. |
@victornoel as I said here we can do it the same thing just using socket classes in JDK. Takes isn't necessary. |
@fabriciofx as concluded in #1444, since we will keep takes, let's try to use it to replace calls to external urls. In |
@victornoel ok |
@andreoss sorry, I missed that the goal of the story was also to get rid of any call to external URLs by replacing them with using takes (or deleting them when unneeded as you did for HTTPS) as in the comment above (from me ^^). Could you check that there are no more of those or if there are, to fix them before we close this issue? |
@victornoel It was the only one |
@andreoss excellent, thx |
Job |
InputOfTest#readsSecureUrlContent()
uses the code bellow to create a SSL conection but isn't necessary and can be deleted.The text was updated successfully, but these errors were encountered: