Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LengthOf must represents Text length #1489

Closed
fabriciofx opened this issue Oct 24, 2020 · 6 comments
Closed

LengthOf must represents Text length #1489

fabriciofx opened this issue Oct 24, 2020 · 6 comments
Labels
0crat/role/DEV

Comments

@fabriciofx
Copy link
Contributor

LengthOf must represents the length of a Text, performing a #asString().length().
@victornoel
Copy link
Collaborator

@fabriciofx do you mean adding a constructor to the existing LengthOf?

@fabriciofx
Copy link
Contributor Author

fabriciofx commented Oct 31, 2020 •
edited
Loading

@victornoel Yeah. Do you think better change the issue's title to reflects it?

@victornoel
Copy link
Collaborator

@fabriciofx now that it is clarified I think it's ok :)

@victornoel
Copy link
Collaborator

@0crat in

andreoss added a commit to andreoss/cactoos that referenced this issue Nov 1, 2020
@andreoss
(yegor256#1489) Add test
d788d88
andreoss added a commit to andreoss/cactoos that referenced this issue Nov 1, 2020
@andreoss
(yegor256#1489) Suppress Qulice complain
ac207da
andreoss pushed a commit to andreoss/cactoos that referenced this issue Nov 5, 2020
(yegor256#1489) Add test for unicode
3c564b1
andreoss pushed a commit to andreoss/cactoos that referenced this issue Nov 5, 2020
(yegor256#1489) Add javadoc
672e6ab
andreoss added a commit to andreoss/cactoos that referenced this issue Nov 5, 2020
@andreoss
(yegor256#1489) Add test for unicode
293b2ce
andreoss added a commit to andreoss/cactoos that referenced this issue Nov 5, 2020
@andreoss
(yegor256#1489) Add javadoc
9f3fa11
andreoss added a commit to andreoss/cactoos that referenced this issue Nov 5, 2020
@andreoss
(yegor256#1489) Return character-length instead of byte-length
b9f4448
andreoss added a commit to andreoss/cactoos that referenced this issue Nov 5, 2020
@andreoss
(yegor256#1489) Return character-length instead of byte-length
e55c217
@andreoss andreoss mentioned this issue Nov 5, 2020
Merged
@victornoel
Copy link
Collaborator

@fabriciofx apparently it has been done, closing this.

@andreoss in the future, when you tackle jobs, can you ping the reporter or me to close the ticket after the PR is merged?

@0crat
Copy link
Collaborator

0crat commented Jan 16, 2021

Job gh:yegor256/cactoos#1489 is not assigned, can't get performer

@0crat 0crat removed the 0crat/scope label Jan 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0crat/role/DEV
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@victornoel @fabriciofx @0crat