Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NumberEnvelope should not implement Scalar<Double> #1496

Closed
andreoss opened this issue Nov 3, 2020 · 4 comments
Closed

NumberEnvelope should not implement Scalar<Double> #1496

andreoss opened this issue Nov 3, 2020 · 4 comments
Assignees
Milestone

Comments

@andreoss
Copy link
Contributor

andreoss commented Nov 3, 2020

There is no reason for NumberEnvelope to have extra method for double value.

https://github.com/yegor256/cactoos/blob/master/src/main/java/org/cactoos/scalar/NumberEnvelope.java#L115

@0crat 0crat added the 0crat/new label Nov 3, 2020
@andreoss andreoss changed the title NumberEnvelope should not implement Scalar NumberEnvelope should not implement Scalar<Double> Nov 3, 2020
@victornoel
Copy link
Collaborator

victornoel commented Nov 7, 2020

@andreoss please see #1335: once it is done, number envelope will simply delegate all the public methods of number to the wrapped number I believe

@victornoel
Copy link
Collaborator

@0crat assign me

@victornoel
Copy link
Collaborator

@0crat status

@0crat
Copy link
Collaborator

0crat commented Jun 10, 2021

@0crat status (here)

@victornoel This is what I know about this job in C63314D6Z, as in §32:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants