IterableAsList is very ineffective

[yegor256]

The implementation of IterableAsList is very wrong, performance wise. Let's implement it similar to what IterableAsMap is doing.

[Timmeey]

@yegor256 how would you change it, if it should still be able to reflect changes in the underlying Iterable?

IterableAsMap suffers from the same problem. It initializes itself on the first call, but any change after that, will not be reflected anymore

    @Test
    public void iterableAsMapReflectsUnderlyingChanges() {
        Map<String, String> underlyingMap = new HashMap<String, String>();
        Map<String, String> map = new IterableAsMap<String, String>
            (underlyingMap.entrySet());

        map.get("");
        underlyingMap.put("TestKey", "TestValue");
        MatcherAssert.assertThat("Did not contain Key",
            map.get("TestKey"), Matchers.is("TestValue"));
    }

[akryvtsun]

Currently IterableAsMap is immutable. Was this design done intentionally?

[yegor256]

@Timmeey yes, this is how it should be -- they must be immutable.

[Timmeey]

@yegor256 are you arguing that you should not be able to add/remove elements from lists, but only create new lists?

From what i see here, the underlying list is not part of the state of the IterableAsList but rather part of its behaviour.

[yegor256]

fixed in #175

[yegor256]

@Timmeey you were right, see #180