Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

String vs CharSequence inconsitencies #1579

Closed
andreoss opened this issue Apr 1, 2021 · 4 comments
Closed

String vs CharSequence inconsitencies #1579

andreoss opened this issue Apr 1, 2021 · 4 comments
Labels
0crat/role/DEV

Comments

@andreoss
Copy link
Contributor

andreoss commented Apr 1, 2021

TextOf uses CharSequence as parameter, but many other implementations of Text use only String.

Proposal:
Interface CharSequence should be favored as a parameter type instead of final class String.
@0crat 0crat added the 0crat/new label Apr 1, 2021
@victornoel
Copy link
Collaborator

@andreoss that's a great idea

@victornoel
Copy link
Collaborator

@0crat in

andreoss added a commit to andreoss/cactoos that referenced this issue Apr 7, 2021
@andreoss
(yegor256#1579) Accept CharSequence instead of String
a265215
andreoss added a commit to andreoss/cactoos that referenced this issue Apr 7, 2021
@andreoss
(yegor256#1579) Change type in ctors
8b67ca5
andreoss added a commit to andreoss/cactoos that referenced this issue Apr 7, 2021
@andreoss
(yegor256#1579) Add ctors
ec63222
@andreoss andreoss mentioned this issue Apr 7, 2021
Merged
andreoss added a commit to andreoss/cactoos that referenced this issue Apr 7, 2021
@andreoss
(yegor256#1579) Qulice compliance
7259326
andreoss added a commit to andreoss/cactoos that referenced this issue Apr 15, 2021
@andreoss
(yegor256#1579) Improve javadoc
a19ec50
andreoss added a commit to andreoss/cactoos that referenced this issue Apr 19, 2021
@andreoss
(yegor256#1579) Remove ctor
344ea11
andreoss added a commit to andreoss/cactoos that referenced this issue Apr 22, 2021
@andreoss
(yegor256#1579) Remove ctor
ed23927
@andreoss
Copy link
Contributor Author

andreoss commented Apr 29, 2021 •
edited
Loading

Done in #1582

@0crat 0crat removed the 0crat/scope label Apr 29, 2021
@0crat
Copy link
Collaborator

0crat commented Apr 29, 2021

Job gh:yegor256/cactoos#1579 is not assigned, can't get performer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0crat/role/DEV
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@victornoel @0crat @andreoss