Test matchers location

[akryvtsun]

At this moment some successors of org.hamcrest.TypeSafeMatcher are located at root org.cactoos package among important high level interfaces. I think the new matchers should be removed from this place somewhere.

1. The best options is to put them into a new library e.g. cactoos-test is dependent from cactoos. In this case these classes will not be located in client prod code if it's used prod cactoos lib. The client has to use cactoos-test only for it's tests via test scope dependency (<scope>test</scope> in Maven). This idea is used e.g. Spring Framework: it has 'spring-core' and 'spring-test'.

2. The easiest option is to move them at least into specialized org.cactoos.match package don't to pollute the root package.

WDYT?

[0crat]

@Englishman I'm not managing this repo, remove the webhook or contact me in Slack //cc @yegor256

[fabriciofx]

@Englishman At the moment, we have only two matchers, right? So, I think we can follow the 2nd option, move them to a org.cactoos.math for a while. When the classes number grow up, we can think in move them to another library. WDYT?

[akryvtsun]

@fabriciofx 3 of them. But there is another problem: dependencies. Marchers use some entities from prod cactoos code but tests for prod lib code need matchers. So...

[fabriciofx]

@Englishman Well, so the simplest solution is just create a new package and put the matchers there. WDYT?

[yegor256]

@Englishman looks like cactoos-test is the best option. Maybe we can create our own alternative to Hamcrest there?

[akryvtsun]

@yegor256 let me think about cactoos-test more... As I wrote earlier the main problem here is cyclic dependency. BTW why do we use Hamcrest but not AssertJ?

[yegor256]

@Englishman didn't know about AssertJ :( Will take a look now.

[yegor256]

@Englishman AssertJ syntax looks nicer that Hamcrest, but it's less object-oriented :) We need something that will be more declarations and less about procedures/instructions/commands.

[llorllale]

@Englishman we're going to separate the matchers into their own project as discussed in #751

Please close this issue

[llorllale]

@Englishman closing

[0crat]

The job is not in WBS, won't close the order