Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hamcrest matchers should be in separate module #751

Closed
neonailol opened this issue Mar 27, 2018 · 30 comments
Closed

hamcrest matchers should be in separate module #751

neonailol opened this issue Mar 27, 2018 · 30 comments
Assignees

Comments

@neonailol
Copy link
Contributor

It's nice that cactoos have its own set of hamcrest matchers, but it pollutes classpath, and ideologically should be in separate module eg cactoos-matchers

@0crat
Copy link
Collaborator

0crat commented Mar 27, 2018

@yegor256/z please, pay attention to this issue

@ghost
Copy link

ghost commented Apr 17, 2018

alternatively, you could use Tacinga which already does this

@yegor256
Copy link
Owner

@llorllale I think it's a reasonable request, to be honest...

@llorllale
Copy link
Contributor

@yegor256 sounds reasonable. I believe the new project, cactoos-matchers, should be brought under the same ZC umbrella C63314D6Z.

My doubts revolve around the new project's CD: the ARC is responsible for this, but this one would seem like it needs your keys.

Please confirm.

@yegor256
Copy link
Owner

@llorllale two options 1) I create it in my GitHub account and deploy to Maven Central into org.cactoos group; 2) you create it in your GitHub account and deploy it to Maven yourself, if you a group there. In either case we add it to ZC project (you remain the ARC). Which option you prefer?

@llorllale
Copy link
Contributor

llorllale commented Apr 18, 2018

@yegor256 I'll take care of it with option 2

My reasoning for future reference: I think this way things will move faster, since you have too many things on your plate already.

@llorllale
Copy link
Contributor

@0crat in

@llorllale
Copy link
Contributor

@0crat assign @llorllale

@0crat 0crat added the scope label Apr 20, 2018
@0crat
Copy link
Collaborator

0crat commented Apr 20, 2018

@0crat in (here)

@llorllale Job #751 is now in scope, role is DEV

@0crat
Copy link
Collaborator

0crat commented Apr 20, 2018

Bug was reported, see §29: +15 point(s) just awarded to @neonailol/z

@0crat
Copy link
Collaborator

0crat commented Apr 20, 2018

@0crat assign @llorllale (here)

@llorllale The job #751 assigned to @llorllale/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this

@0crat
Copy link
Collaborator

0crat commented Apr 20, 2018

Manual assignment of issues is discouraged, see §19: -5 point(s) just awarded to @llorllale/z

@0crat
Copy link
Collaborator

0crat commented Apr 26, 2018

@llorllale/z this job was assigned to you 5days ago. It will be taken away from you soon, unless you close it, see §8. Read this and this, please.

@llorllale
Copy link
Contributor

llorllale commented Apr 29, 2018

@0crat waiting taking longer than anticipated

@0crat
Copy link
Collaborator

0crat commented Apr 29, 2018

@0crat waiting taking longer than anticipated (here)

@llorllale The impediment for #751 was registered successfully by @llorllale/z

@llorllale
Copy link
Contributor

@yegor256 do you wish to include it in ZC project C63314D6Z?

@yegor256
Copy link
Owner

yegor256 commented May 6, 2018

@llorllale you can do it yourself in Slack

@llorllale
Copy link
Contributor

llorllale commented May 6, 2018

@yegor256 that's correct, but it says here that rultor pulls secrets/keys from GH repos. Unfortunately, I don't have private repos and can't currently commit to spending those $7/mo due to special circumstances.

I believe having this non-rultor project next to the others would be awkward. I can assign this task to you so you can set it up with rultor. WDYT?

@llorllale
Copy link
Contributor

@yegor256 forget it. I've thought about it a bit more and I've decided to get the subscription. Thanks for your patience.

@llorllale
Copy link
Contributor

@0crat waiting on yegor256/rultor#1256

@0crat
Copy link
Collaborator

0crat commented May 8, 2018

@0crat waiting on yegor256/rultor#1256 (here)

@llorllale Job #751 is already on hold

@llorllale
Copy link
Contributor

@neonailol fixed in 6a2e210

@llorllale
Copy link
Contributor

@rultor release, tag is 0.33

@llorllale
Copy link
Contributor

@yegor256 @neonailol the new project is llorllale/cactoos-matchers.

@llorllale
Copy link
Contributor

@yegor256 please checkout the license on the new project and feel free to open an issue in that project if applicable

@rultor
Copy link
Collaborator

rultor commented May 12, 2018

@rultor release, tag is 0.33

@llorllale OK, I will release it now. Please check the progress here

@rultor
Copy link
Collaborator

rultor commented May 12, 2018

@rultor release, tag is 0.33

@llorllale Done! FYI, the full log is here (took me 10min)

@0crat 0crat removed the scope label May 12, 2018
@0crat
Copy link
Collaborator

0crat commented May 12, 2018

Order was finished: +30 point(s) just awarded to @llorllale/z

@0crat
Copy link
Collaborator

0crat commented May 12, 2018

The job #751 is now out of scope

@yegor256
Copy link
Owner

@llorllale looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants