Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReaderOf test class is incomplete #630

Closed
driver733 opened this issue Feb 11, 2018 · 14 comments
Closed

ReaderOf test class is incomplete #630

driver733 opened this issue Feb 11, 2018 · 14 comments
Labels

Comments

@driver733
Copy link
Contributor

Let's fully test the class ReaderOf. Currently, this class test coverage of 27%, so I suggest that we test this class using all of it's constructors and methods to achieve 100% coverage.

@0crat
Copy link
Collaborator

0crat commented Feb 11, 2018

@yegor256/z please, pay attention to this issue

@driver733 driver733 changed the title ReaderOf test is incomplete ReaderOf test class is incomplete Feb 11, 2018
@yegor256 yegor256 added the bug label Feb 12, 2018
@0crat 0crat added the scope label Feb 12, 2018
@0crat
Copy link
Collaborator

0crat commented Feb 12, 2018

Job #630 is now in scope, role is DEV

@0crat
Copy link
Collaborator

0crat commented Feb 12, 2018

Bug was reported, see §29: +15 points just awarded to @driver733/z, total is +90

@0crat
Copy link
Collaborator

0crat commented Feb 15, 2018

The job #630 assigned to @proshin-roman/z, here is why. The budget is 30 minutes, see §4. Please, read §8 and §9. If the task is not clear, read this and this.

@0crat
Copy link
Collaborator

0crat commented Feb 20, 2018

@proshin-roman/z this job was assigned to you 5 days ago. It will be taken away from you soon, unless you close it, see §8. Read this and this, please.

@0crat
Copy link
Collaborator

0crat commented Feb 23, 2018

@proshin-roman/z this job was assigned to you 8 days ago. It will be taken away from you soon, unless you close it, see §8. Read this and this, please.

@proshin-roman
Copy link
Contributor

@0crat waiting for pull request merging (it's already approved by PR)

@0crat
Copy link
Collaborator

0crat commented Feb 24, 2018

@0crat waiting for pull request merging (it's already approved by PR) (here)

@proshin-roman The impediment for #630 was registered successfully by @proshin-roman/z

@proshin-roman
Copy link
Contributor

@driver733 the issue was fixed in a pull request #676 that is already merged. So the issue can be closed now.

@0crat
Copy link
Collaborator

0crat commented Feb 28, 2018

@ypshenychka/z please review this job, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

@ypshenychka
Copy link

@0crat quality good

@0crat
Copy link
Collaborator

0crat commented Mar 2, 2018

QA review completed: +8 points just awarded to @ypshenychka/z

@0crat 0crat removed the scope label Mar 2, 2018
@0crat
Copy link
Collaborator

0crat commented Mar 2, 2018

Order was finished, quality was "good": +35 points just awarded to @proshin-roman/z

@0crat
Copy link
Collaborator

0crat commented Mar 2, 2018

@0crat quality good (here)

@ypshenychka The job #630 is now out of scope

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants