equals() and hashCode() of MapEnvelope should be tolerant to nulls

[butenkos]

Methods equals() and hashCode() of abstract class MapEnvelope fail with NullPointerException when enveloped Map contains null values.
There are unit-tests covering this behaviour: test case MapEnvelopeTest, methods hashCodeFailsOnNull() and equalFailsOnNull().
Is it really a desired behaviour? A lot of Map implementations (including standard implementations from jdk) support null keys or/and values. With the current implementation we cannot compare instances of MapEnvelope which incapsulate Maps with nulls and store them in collections.

equals() and hashCode() of MapEnvelope should be tolerant to nulls in order to be able to work correctly with enveloped Maps which may contain null keys or/and values, and to be able to be stored in collections

[0crat]

@llorllale/z please, pay attention to this issue

[llorllale]

@butenkos thanks, you're right.

We have MapNoNulls decorator that users can use if null is not tolerated.

[llorllale]

@0crat in

[0crat]

@0crat in (here)

@llorllale Job #922 is now in scope, role is DEV

[0crat]

Bug was reported, see §29: +15 point(s) just awarded to @butenkos/z

[0crat]

The job #922 assigned to @dennis00010011b/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; there will be no monetary reward for this job

[0crat]

The job #922 assigned to @victornoel/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; there will be no monetary reward for this job

[victornoel]

@0crat refuse

[0crat]

@0crat refuse (here)

@victornoel The user @victornoel/z resigned from #922, please stop working. Reason for job resignation: Order was cancelled

[0crat]

Tasks refusal is discouraged, see §6: -15 point(s) just awarded to @victornoel/z

[0crat]

The job #922 assigned to @umbrah/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; there will be no monetary reward for this job

[vladhss]

@llorllale Can we close it? PR was merged

[llorllale]

@Umbrah always as the ticket reporter first

[vladhss]

@butenkos Can we close it?

[0crat]

@sereshqua/z please review this job completed by @umbrah/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

[0crat]

The job #922 is now out of scope

[0crat]

Job #922 is not in the agenda of @umbrah/z, can't inspect

[sereshqua]

@0crat quality good

[0crat]

Quality review completed: +4 point(s) just awarded to @sereshqua/z

[0crat]

Order was finished, quality is "good": +35 point(s) just awarded to @umbrah/z