Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What is the expected behaviour of BehavesAsMap? #927

Closed
victornoel opened this issue Jul 7, 2018 · 17 comments
Closed

What is the expected behaviour of BehavesAsMap? #927

victornoel opened this issue Jul 7, 2018 · 17 comments
Labels

Comments

@victornoel
Copy link
Collaborator

victornoel commented Jul 7, 2018

The behaviour of BehavesAsMap is ambiguous.

If I write new BehavesAsMap("a", "b"), I am not expecting b to be anything else than the value of the key a.

But many tests makes this assumption:

SyncMapTest#behavesAsMap()
SyncMapTest#worksInThreads()
StickyMapTest#behavesAsMap()
SolidMapTest#behavesAsMap()
SolidMapTest#worksInThreads()
MapOfTest#behavesAsMap()

It should mean that b is indeed the value of a and the tests should be modified to comply with this.

@0crat
Copy link
Collaborator

0crat commented Jul 7, 2018

@llorllale/z please, pay attention to this issue

@llorllale
Copy link
Contributor

@victornoel which tests don't assume that b is the value of a?

@victornoel
Copy link
Collaborator Author

@llorllale

SyncMapTest#behavesAsMap()
SyncMapTest#worksInThreads()
StickyMapTest#behavesAsMap()
SolidMapTest#behavesAsMap()
SolidMapTest#worksInThreads()
MapOfTest#behavesAsMap()

Also note that I edited the description, I won't take care of this in #903, I already worked too much on it :)

@llorllale
Copy link
Contributor

@victornoel you're right, the problem is in BehavesAsMap.matchesSafely

@llorllale llorllale added the bug label Jul 7, 2018
@0crat 0crat added the scope label Jul 7, 2018
@llorllale
Copy link
Contributor

@victornoel can you rephrase this ticket as a bug ?

@0crat
Copy link
Collaborator

0crat commented Jul 7, 2018

Job #927 is now in scope, role is DEV

@0crat
Copy link
Collaborator

0crat commented Jul 7, 2018

Bug was reported, see §29: +15 point(s) just awarded to @victornoel/z

@victornoel
Copy link
Collaborator Author

@llorllale I rewrote the description

@0crat
Copy link
Collaborator

0crat commented Mar 18, 2019

The job #927 assigned to @dennis00010011b/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; there will be no monetary reward for this job

@0crat
Copy link
Collaborator

0crat commented Apr 2, 2019

The job #927 assigned to @umbrah/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; there will be no monetary reward for this job

@vladhss
Copy link
Contributor

vladhss commented Apr 18, 2019

@victornoel Can we close it? PR was merged

@victornoel
Copy link
Collaborator Author

@Umbrah thanks

@0crat 0crat removed the scope label Apr 18, 2019
@0crat
Copy link
Collaborator

0crat commented Apr 18, 2019

@sereshqua/z please review this job completed by @umbrah/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

@0crat
Copy link
Collaborator

0crat commented Apr 18, 2019

The job #927 is now out of scope

@sereshqua
Copy link

@0crat quality good

@0crat
Copy link
Collaborator

0crat commented Apr 18, 2019

Quality review completed: +4 point(s) just awarded to @sereshqua/z

@0crat
Copy link
Collaborator

0crat commented Apr 18, 2019

Order was finished, quality is "good": +35 point(s) just awarded to @umbrah/z

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants