Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SumOf does not work on Iterable<Integer> #950

Closed
piotrkot opened this issue Sep 19, 2018 · 15 comments
Closed

SumOf does not work on Iterable<Integer> #950

piotrkot opened this issue Sep 19, 2018 · 15 comments
Labels

Comments

@piotrkot
Copy link

SumOf does not use bounded type parameters. For that it doesn't work when called

new Collection<Integer> ints;
new SumOf(ints); // doesn't compile

If SumOf was implemented like:

    public <T extends Number> SumOf(final Iterable<T> src)

instead of

    public SumOf(final Iterable<Number> src)

that would compile.
Please, fix it.

@0crat
Copy link
Collaborator

0crat commented Sep 19, 2018

@llorllale/z please, pay attention to this issue

@0crat
Copy link
Collaborator

0crat commented Sep 19, 2018

@piotrkot/z this project will fix the problem faster if you donate a few dollars to it; just click here and pay via Stripe, it's very fast, convenient and appreciated; thanks a lot!

llorllale pushed a commit that referenced this issue Sep 20, 2018
Arg for SumOf(Iterable) now specifies upper bound of Number
@llorllale
Copy link
Contributor

@piotrkot fixed in 32c96d9. Can we close this issue?

@llorllale llorllale added the bug label Sep 20, 2018
@0crat 0crat added the scope label Sep 20, 2018
@0crat
Copy link
Collaborator

0crat commented Sep 20, 2018

Job #950 is now in scope, role is DEV

@0crat
Copy link
Collaborator

0crat commented Sep 20, 2018

Thanks for your contribution, @piotrkot/z! If you would be a member of the project, you would now earn +15 reputation points, as explained in §29. You can join and apply to it, see §2.

@piotrkot
Copy link
Author

@llorllale Thanks for the fix.
@0crat Thanks for the invitation to join but I prefer to work for you for free.

@0crat
Copy link
Collaborator

0crat commented Sep 21, 2018

Are you speaking to me or about me here; you must always start your message with my name if you want to address it to me, see §1

@0crat
Copy link
Collaborator

0crat commented Sep 21, 2018

Job gh:yegor256/cactoos#950 is not assigned, can't get performer

@0crat 0crat removed the scope label Sep 21, 2018
@0crat
Copy link
Collaborator

0crat commented Sep 21, 2018

The job #950 is now out of scope

@llorllale
Copy link
Contributor

@piotrkot let me know if you need this released

@piotrkot
Copy link
Author

@llorllale Definitely. Please, release it. But now I wonder if you make a fix to the Latest release version (0.11) or to the latest Pre-release version (0.36). And by the way, can you explain the difference between the two?

@llorllale
Copy link
Contributor

@piotrkot this will be a pre release (pre 1.0)

@llorllale
Copy link
Contributor

@rultor release, tag is 0.37

@rultor
Copy link
Collaborator

rultor commented Sep 24, 2018

@rultor release, tag is 0.37

@llorllale OK, I will release it now. Please check the progress here

@rultor
Copy link
Collaborator

rultor commented Sep 24, 2018

@rultor release, tag is 0.37

@llorllale Done! FYI, the full log is here (took me 13min)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants