-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
For #942: Fixed TextEnvelope.equals()
misbehavior.
#952
Conversation
Job #952 is now in scope, role is |
if (this == obj) { | ||
return true; | ||
} | ||
if (!(obj instanceof TextEnvelope)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@paulodamaso let's make program against the Text
interface, not the implementation
@paulodamaso left you a comment Also, fix the puzzle's format. |
…fixed todo.
@llorllale Thanks for the review, corrections applied, please take a look |
@rultor merge |
@llorllale OK, I'll try to merge now. You can check the progress of the merge here |
@llorllale Done! FYI, the full log is here (took me 12min) |
Job |
The job #952 is now out of scope |
@rultor release, tag is |
@llorllale OK, I will release it now. Please check the progress here |
@llorllale Done! FYI, the full log is here (took me 13min) |
For #942:
TextEnvelope.equals()
misbehavior;TextEnvelopeTests
tests regardingTextEnvelope.equals()
;