Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For #942: Fixed TextEnvelope.equals() misbehavior. #952

Merged
merged 2 commits into from
Sep 26, 2018

Conversation

paulodamaso
Copy link
Contributor

For #942:

  • Fixed TextEnvelope.equals() misbehavior;
  • Fixed TextEnvelopeTests tests regarding TextEnvelope.equals();
  • Added puzzle for refactoring and making code more elegant.

@0crat 0crat added the scope label Sep 24, 2018
@0crat
Copy link
Collaborator

0crat commented Sep 24, 2018

Job #952 is now in scope, role is REV

if (this == obj) {
return true;
}
if (!(obj instanceof TextEnvelope)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@paulodamaso let's make program against the Text interface, not the implementation

@llorllale
Copy link
Contributor

@paulodamaso left you a comment

Also, fix the puzzle's format.

@paulodamaso
Copy link
Contributor Author

@llorllale Thanks for the review, corrections applied, please take a look

@llorllale
Copy link
Contributor

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Sep 26, 2018

@rultor merge

@llorllale OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit d38aa54 into yegor256:master Sep 26, 2018
@rultor
Copy link
Collaborator

rultor commented Sep 26, 2018

@rultor merge

@llorllale Done! FYI, the full log is here (took me 12min)

@0crat 0crat removed the scope label Sep 26, 2018
@0crat
Copy link
Collaborator

0crat commented Sep 26, 2018

Job gh:yegor256/cactoos#952 is not assigned, can't get performer

@0crat
Copy link
Collaborator

0crat commented Sep 26, 2018

The job #952 is now out of scope

@paulodamaso paulodamaso deleted the 942 branch October 3, 2018 18:27
@paulodamaso paulodamaso mentioned this pull request Oct 3, 2018
@llorllale
Copy link
Contributor

@rultor release, tag is 0.38

@rultor
Copy link
Collaborator

rultor commented Oct 3, 2018

@rultor release, tag is 0.38

@llorllale OK, I will release it now. Please check the progress here

@rultor
Copy link
Collaborator

rultor commented Oct 3, 2018

@rultor release, tag is 0.38

@llorllale Done! FYI, the full log is here (took me 13min)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants