Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

996: Making ListEnvelope public #1073

Closed
wants to merge 5 commits into from
Closed

Conversation

piotrkot
Copy link

Making ListEnvelope public

@codecov-io
Copy link

codecov-io commented Feb 15, 2019

Codecov Report

Merging #1073 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1073      +/-   ##
============================================
+ Coverage     87.63%   87.63%   +<.01%     
  Complexity     1529     1529              
============================================
  Files           269      270       +1     
  Lines          3929     3931       +2     
  Branches        215      216       +1     
============================================
+ Hits           3443     3445       +2     
  Misses          437      437              
  Partials         49       49
Impacted Files Coverage Δ Complexity Δ
src/main/java/org/cactoos/list/ListEnvelope.java 100% <ø> (ø) 12 <0> (ø) ⬇️
src/main/java/org/cactoos/func/Async.java 100% <0%> (ø) 6% <0%> (-3%) ⬇️
...ava/org/cactoos/collection/CollectionEnvelope.java 100% <0%> (ø) 26% <0%> (-1%) ⬇️
src/main/java/org/cactoos/text/TrimmedText.java
src/main/java/org/cactoos/text/JoinedText.java
src/main/java/org/cactoos/text/NormalizedText.java
src/main/java/org/cactoos/text/Normalized.java 100% <0%> (ø) 3% <0%> (?)
src/main/java/org/cactoos/text/Trimmed.java 100% <0%> (ø) 2% <0%> (?)
src/main/java/org/cactoos/scalar/Binary.java 100% <0%> (ø) 4% <0%> (?)
src/main/java/org/cactoos/text/Joined.java 100% <0%> (ø) 6% <0%> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77aa19a...b56b027. Read the comment docs.

@0crat
Copy link
Collaborator

0crat commented Feb 15, 2019

@piotrkot/z this pull request is too small, just 5 lines changed (less than 10), there will be no formal code review, see §53 and §28; in the future, try to make sure your pull requests are not too small; @llorllale/z please review this and merge or reject

@llorllale
Copy link
Contributor

@piotrkot please fix your commit msgs (a47be69 is unacceptable)

@piotrkot
Copy link
Author

@llorllale what do you mean? The first two messages were not acceptable. The third one was fine for Travis.

@llorllale
Copy link
Contributor

@piotrkot the message on a47be69 is not acceptable

@llorllale
Copy link
Contributor

@piotrkot ping

@piotrkot
Copy link
Author

piotrkot commented Mar 3, 2019

@llorllale Can you explain what should be in the commit message?
Normally, I put message describing what I actually did in the commit. So, the first one is fixing the issue, The second is fixing qulice warning, and as sole purpose of the third change was to satisfy travis' regex check, that's what is says.
Now, if you don't like it I will make a rollback of the previous commit (a47be69), which will still be a dummy commit. How should I name it?

@llorllale
Copy link
Contributor

@piotrkot you can just squash them all into a single commit with a sensible message

@piotrkot
Copy link
Author

piotrkot commented Mar 5, 2019

@llorllale OMG, I hate git. I couldn't make it with rebase and squash. Instead, tried with git reset --soft HEAD~3 and git commit. Any better?

@piotrkot
Copy link
Author

piotrkot commented Mar 8, 2019

@llorllale ping

@llorllale
Copy link
Contributor

@piotrkot they're still visible here

@piotrkot
Copy link
Author

piotrkot commented Mar 8, 2019

@llorllale Well, I don't know how to do it, then.

@piotrkot piotrkot closed this Mar 8, 2019
@0crat
Copy link
Collaborator

0crat commented Mar 8, 2019

Job gh:yegor256/cactoos#1073 is not assigned, can't get performer

@0crat
Copy link
Collaborator

0crat commented Mar 8, 2019

This job is not in scope

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants