-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
996: Making ListEnvelope public #1073
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1073 +/- ##
============================================
+ Coverage 87.63% 87.63% +<.01%
Complexity 1529 1529
============================================
Files 269 270 +1
Lines 3929 3931 +2
Branches 215 216 +1
============================================
+ Hits 3443 3445 +2
Misses 437 437
Partials 49 49
Continue to review full report at Codecov.
|
@llorllale what do you mean? The first two messages were not acceptable. The third one was fine for Travis. |
@piotrkot ping |
@llorllale Can you explain what should be in the commit message? |
@piotrkot you can just squash them all into a single commit with a sensible message |
@llorllale OMG, I hate git. I couldn't make it with rebase and squash. Instead, tried with |
@llorllale ping |
@llorllale Well, I don't know how to do it, then. |
Job |
This job is not in scope |
Making ListEnvelope public