(#1039) Replaced @Rule with Throws matcher #1100
Conversation
|
Job #1100 is now in scope, role is |
Codecov Report
@@ Coverage Diff @@
## master #1100 +/- ##
========================================
Coverage 88.6% 88.6%
Complexity 1576 1576
========================================
Files 275 275
Lines 3931 3931
Branches 214 214
========================================
Hits 3483 3483
Misses 396 396
Partials 52 52Continue to review full report at Codecov.
|
|
This pull request #1100 is assigned to @victornoel/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @llorllale/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be no monetary reward for this job |
There was a problem hiding this comment.
@atapin I've left you a "few" comments (like a hundred time the same one ;)
|
@atapin thanks @llorllale seems good to merge. Not sure why appveyor fails, it is not related to this PR apparently… |
|
@llorllale done |
|
@atapin there are merge conflicts |
|
@llorllale fixed |
|
@atapin just one more minor comment :) |
|
@llorllale resolved |
|
@rultor merge |
@llorllale OK, I'll try to merge now. You can check the progress of the merge here |
@llorllale Done! FYI, the full log is here (took me 13min) |
|
@sereshqua/z please review this job completed by @victornoel/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed |
|
Job #1100 is not in the agenda of @victornoel/z, can't inspect |
|
The job #1100 is now out of scope |
|
Payment to |
|
@0crat quality good |
|
Quality review completed: +4 point(s) just awarded to @sereshqua/z |
|
Order was finished, quality is "good": +20 point(s) just awarded to @victornoel/z |
It updates the
TextTestby usingThrowsmatcher instead of@Rule-marked exception check.