(#1116) Extends TextEnvelope when possible #1131

victornoel · 2019-05-25T14:46:12Z

This is for #1116.

I've applied the new pattern for 3 classes and added a todo to continue the work.

0crat · 2019-05-25T14:48:03Z

Job #1131 is now in scope, role is REV

0crat · 2019-05-25T14:50:38Z

This pull request #1131 is assigned to @vzurauskas /z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @llorllale /z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be no monetary reward for this job

codecov-io · 2019-05-25T14:53:41Z

Codecov Report

Merging #1131 into master will not change coverage.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master    #1131   +/-   ##
=========================================
  Coverage     88.83%   88.83%           
  Complexity     1581     1581           
=========================================
  Files           272      272           
  Lines          3931     3931           
  Branches        215      215           
=========================================
  Hits           3492     3492           
  Misses          386      386           
  Partials         53       53

Impacted Files	Coverage Δ	Complexity Δ
src/main/java/org/cactoos/text/Randomized.java	`100% <ø> (ø)`	`13 <0> (ø)`	⬇️
src/main/java/org/cactoos/text/FormattedText.java	`100% <100%> (ø)`	`8 <1> (ø)`	⬇️
src/main/java/org/cactoos/text/NoNulls.java	`100% <100%> (ø)`	`1 <1> (ø)`	⬇️
src/main/java/org/cactoos/text/Synced.java	`100% <100%> (ø)`	`2 <1> (ø)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74a9a55...4a301a9. Read the comment docs.

victornoel · 2019-05-28T21:14:51Z

@vzurauskas ping ? :)

vzurauskas

@victornoel Review done.

vzurauskas · 2019-05-29T14:29:11Z

src/main/java/org/cactoos/text/FormattedText.java

-            );
-        }
-        return out.toString();
+        super((Scalar<String>) () -> {


@victornoel Since type casting is discouraged in EO, consider adding a private constructor which would take Scalar<String> (or just Text) and call super from there.

vzurauskas · 2019-05-29T14:30:51Z

src/main/java/org/cactoos/text/NoNulls.java

-            );
-        }
-        return string;
+        super((Scalar<String>) () -> {


@victornoel Same comment about type casting.

vzurauskas · 2019-05-29T14:33:28Z

src/main/java/org/cactoos/text/Synced.java

@@ -58,15 +48,10 @@ public Synced(final Text text) {
     * @param lck The lock
     */
    public Synced(final Text text, final Object lck) {
-        this.origin = text;
-        this.lock = lck;
+        super((Scalar<String>) () -> {


@victornoel Same comment about type casting.

victornoel · 2019-05-30T10:32:19Z

@vzurauskas thanks you, in the end I went with using anonymous classes (which is exactly equivalent to a lambda apart from being explicit in the type) to solve this issue because for example NoNulls, I couldn't use another constructor since it would be ambiguous with the one taking a Text.

vzurauskas

@llorllale Looks good.

llorllale · 2019-05-31T21:10:47Z

@rultor merge

rultor · 2019-05-31T21:11:54Z

@rultor merge

@llorllale OK, I'll try to merge now. You can check the progress of the merge here

rultor · 2019-05-31T21:25:30Z

@rultor merge

@llorllale Done! FYI, the full log is here (took me 13min)

0crat · 2019-05-31T21:46:22Z

@sereshqua /z please review this job completed by @vzurauskas /z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

0crat · 2019-05-31T21:46:27Z

Job #1131 is not in the agenda of @vzurauskas /z, can't inspect

0crat · 2019-05-31T21:46:38Z

The job #1131 is now out of scope

0crat · 2019-05-31T21:53:16Z

Payment to ARC for a closed pull request, as in §28: +10 point(s) just awarded to @llorllale /z

sereshqua · 2019-06-01T05:51:24Z

@0crat quality good

0crat · 2019-06-01T06:04:15Z

Order was finished, quality is "good": +20 point(s) just awarded to @vzurauskas /z

0crat · 2019-06-01T06:04:38Z

Quality review completed: +4 point(s) just awarded to @sereshqua /z

scristalli · 2019-07-01T10:39:25Z

@llorllale is it possible to make a release from master, or at least one including these changes? The new structure of FormattedText is much better, and I would prefer to use it in cases like this issue, instead of using the old version and refactor later.
Thanks.

llorllale · 2019-07-02T23:34:53Z

@scristalli I don't see the difference?

scristalli · 2019-07-03T15:20:22Z

@llorllale if I'm not mistaken, in 0.41 FormattedText only has a asString() throws Exception method, while with new modifications it will expose both asString() throws IOException, and un unchecked toString() wrapping asString().
In the project I linked we have some methods that already throw IOException and I think it's less confusing if we don't enlarge the range of exceptions just for a string formatting operation.

llorllale · 2019-07-04T01:29:07Z

@rultor release, tag is 0.42

rultor · 2019-07-04T01:40:23Z

@rultor release, tag is 0.42

@llorllale OK, I will release it now. Please check the progress here

rultor · 2019-07-04T01:48:31Z

@rultor release, tag is 0.42

@llorllale @victornoel Oops, I failed. You can see the full log here (spent 8min)

	at org.apache.maven.cli.MavenCli.execute(MavenCli.java:863)
	at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:288)
	at org.apache.maven.cli.MavenCli.main(MavenCli.java:199)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
	at org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
	at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
	at org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 06:01 min
[INFO] Finished at: 2019-07-04T01:47:48+00:00
[INFO] Final Memory: 50M/530M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.codehaus.mojo:exec-maven-plugin:1.6.0:exec (default) on project cactoos: Command execution failed. Process exited with an error: 1 (Exit value: 1) -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.codehaus.mojo:exec-maven-plugin:1.6.0:exec (default) on project cactoos: Command execution failed.
	at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:212)
	at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
	at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
	at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116)
	at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80)
	at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
	at org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
	at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:307)
	at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:193)
	at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:106)
	at org.apache.maven.cli.MavenCli.execute(MavenCli.java:863)
	at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:288)
	at org.apache.maven.cli.MavenCli.main(MavenCli.java:199)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
	at org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
	at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
	at org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
Caused by: org.apache.maven.plugin.MojoExecutionException: Command execution failed.
	at org.codehaus.mojo.exec.ExecMojo.execute(ExecMojo.java:326)
	at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134)
	at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:207)
	... 20 more
Caused by: org.apache.commons.exec.ExecuteException: Process exited with an error: 1 (Exit value: 1)
	at org.apache.commons.exec.DefaultExecutor.executeInternal(DefaultExecutor.java:404)
	at org.apache.commons.exec.DefaultExecutor.execute(DefaultExecutor.java:166)
	at org.codehaus.mojo.exec.ExecMojo.executeCommandLine(ExecMojo.java:804)
	at org.codehaus.mojo.exec.ExecMojo.executeCommandLine(ExecMojo.java:751)
	at org.codehaus.mojo.exec.ExecMojo.execute(ExecMojo.java:313)
	... 22 more
[ERROR] 
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
container ed0292f131d2004bc9d2aacd7fb7c95f0a589bee2d9b3b1e2f868823f92fc4d7 is dead
Thu Jul  4 03:48:24 CEST 2019

victornoel · 2019-07-06T17:00:15Z

@llorllale release failed...

llorllale · 2019-07-07T14:27:24Z

@rultor release, tag is 0.42

rultor · 2019-07-07T14:27:48Z

@rultor release, tag is 0.42

@llorllale OK, I will release it now. Please check the progress here

rultor · 2019-07-07T14:41:24Z

@rultor release, tag is 0.42

@llorllale Done! FYI, the full log is here (took me 13min)

victornoel mentioned this pull request May 25, 2019

FormattedText.java:39-42: All classes implementing Text... #1116

Closed

0crat added the scope label May 25, 2019

vzurauskas suggested changes May 29, 2019

View reviewed changes

(yegor256#1116) Extends TextEnvelope when possible

4a301a9

victornoel force-pushed the 1116-textenvelope-subclasses branch from ba66fa7 to 4a301a9 Compare May 30, 2019 10:30

vzurauskas approved these changes May 30, 2019

View reviewed changes

rultor merged commit 4a301a9 into yegor256:master May 31, 2019

0crat removed the scope label May 31, 2019

scristalli mentioned this pull request Jul 1, 2019

FkGitHubAuthRedirection.java:33-34: Replace the call to... g4s8/ghman#40

Closed

victornoel deleted the 1116-textenvelope-subclasses branch July 1, 2019 11:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

(#1116) Extends TextEnvelope when possible #1131

(#1116) Extends TextEnvelope when possible #1131

victornoel commented May 25, 2019

0crat commented May 25, 2019

0crat commented May 25, 2019

codecov-io commented May 25, 2019 •

edited

Loading

victornoel commented May 28, 2019

vzurauskas left a comment

vzurauskas May 29, 2019

vzurauskas May 29, 2019

vzurauskas May 29, 2019

victornoel commented May 30, 2019

vzurauskas left a comment

llorllale commented May 31, 2019

rultor commented May 31, 2019

rultor commented May 31, 2019

0crat commented May 31, 2019

0crat commented May 31, 2019

0crat commented May 31, 2019

0crat commented May 31, 2019

sereshqua commented Jun 1, 2019

0crat commented Jun 1, 2019

0crat commented Jun 1, 2019

scristalli commented Jul 1, 2019

llorllale commented Jul 2, 2019

scristalli commented Jul 3, 2019

llorllale commented Jul 4, 2019

rultor commented Jul 4, 2019

rultor commented Jul 4, 2019

victornoel commented Jul 6, 2019

llorllale commented Jul 7, 2019

rultor commented Jul 7, 2019

rultor commented Jul 7, 2019

(#1116) Extends TextEnvelope when possible #1131

(#1116) Extends TextEnvelope when possible #1131

Conversation

victornoel commented May 25, 2019

0crat commented May 25, 2019

0crat commented May 25, 2019

codecov-io commented May 25, 2019 • edited Loading

Codecov Report

victornoel commented May 28, 2019

vzurauskas left a comment

Choose a reason for hiding this comment

vzurauskas May 29, 2019

Choose a reason for hiding this comment

vzurauskas May 29, 2019

Choose a reason for hiding this comment

vzurauskas May 29, 2019

Choose a reason for hiding this comment

victornoel commented May 30, 2019

vzurauskas left a comment

Choose a reason for hiding this comment

llorllale commented May 31, 2019

rultor commented May 31, 2019

rultor commented May 31, 2019

0crat commented May 31, 2019

0crat commented May 31, 2019

0crat commented May 31, 2019

0crat commented May 31, 2019

sereshqua commented Jun 1, 2019

0crat commented Jun 1, 2019

0crat commented Jun 1, 2019

scristalli commented Jul 1, 2019

llorllale commented Jul 2, 2019

scristalli commented Jul 3, 2019

llorllale commented Jul 4, 2019

rultor commented Jul 4, 2019

rultor commented Jul 4, 2019

victornoel commented Jul 6, 2019

llorllale commented Jul 7, 2019

rultor commented Jul 7, 2019

rultor commented Jul 7, 2019

codecov-io commented May 25, 2019 •

edited

Loading