(#1182) Remove some more static call to assert

[victornoel]

This is for #1182

I had to increment cactoos-matchers version to benefit from bugfixes (llorllale/cactoos-matchers#132) that were preventing tests to pass with Assertion.

[0crat]

Job #1209 is now in scope, role is REV

[0crat]

This pull request #1209 is assigned to @fabriciofx/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @paulodamaso/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be no monetary reward for this job

[victornoel]

@fabriciofx ping

[paulodamaso]

@fabriciofx please go on

[victornoel]

@paulodamaso can you refuse it for @fabriciofx so that someone else is assigned?

[paulodamaso]

@0crat assign me

[0crat]

@0crat assign me (here)

@paulodamaso There is an unrecoverable failure on my side. Please, submit it here:

PID: 12@b7e726625068, thread: PQ-C63314D6Z
com.zerocracy.claims.ClaimIn[214] java.lang.IllegalArgumentException: Parameter "age" not found in "Order was canceled" among: [comment, job, issue, repo, cause, _parent_sig, flow, login]

0.50.34: CID: c6ab51d4-04b2-46b3-b2f9-b1568467eab9, Type: "Order was canceled"

[paulodamaso]

@victornoel Why change the message for all assertions? Also,there is one comment, please take a look

[paulodamaso]

@victornoel I think that would be better to create a constant with the "" (empty string), WDYT?

[victornoel]

@paulodamaso you mean a variable in the test for the empty string? I can do that yes

[0crat]

@0crat assign me (here)

@paulodamaso This pull request #1209 is assigned to @paulodamaso/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @paulodamaso/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be no monetary reward for this job

[0crat]

Manual assignment of issues is discouraged, see §19: -5 point(s) just awarded to @paulodamaso/z

[victornoel]

@paulodamaso thank you. I changed the messages because it seems it is the accepted way of describing an assertion with a positive sentence starting with "must". It has been asked to me many times in previous PRs.

[paulodamaso]

@victornoel Could you please change these messages back? As I understand, this message would be as like the error message for the assertion failure. This behavior is consistent with many other EO projects, so I think that we should stick to the standard

[victornoel]

@paulodamaso that's my point: I understood the standard in EO projects was to use a positive sentence starting with must.

[paulodamaso]

@victornoel It seems that we have both cases in cactoos, so we have two standards. There is really no problem on this, since the messages fulfill their purpose of informing the assertion result. Taking this into account you can leave the messages as you reworded them, but please just capitalize the first word in each sentence then.

[victornoel]

@paulodamaso sorry for the delay, it is done and rebased on master

[codecov-io]

Codecov Report

Merging #1209 into master will decrease coverage by 0.05%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1209      +/-   ##
============================================
- Coverage     89.22%   89.17%   -0.06%     
+ Complexity     1660     1659       -1     
============================================
  Files           279      279              
  Lines          3992     3992              
  Branches        213      213              
============================================
- Hits           3562     3560       -2     
- Misses          396      398       +2     
  Partials         34       34

Impacted Files	Coverage Δ	Complexity Δ
src/main/java/org/cactoos/io/ReaderOf.java	96.55% <0%> (-3.45%)	28% <0%> (-1%)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e0da30...de831b8. Read the comment docs.

[paulodamaso]

@victornoel thanks for the fixes

[paulodamaso]

@rultor merge

[rultor]

@rultor merge

@paulodamaso OK, I'll try to merge now. You can check the progress of the merge here

[rultor]

@rultor merge

@paulodamaso Done! FYI, the full log is here (took me 12min)

[paulodamaso]

@0crat status

[0crat]

@0crat status (here)

@paulodamaso This is what I know about this job in C63314D6Z, as in §32:

• The job #1209 is in scope for 25days
• The role is REV
• The job is assigned to @paulodamaso/z for 5days
• There is no monetary reward attached, it's a free job
• The job doesn't have any impediments
• The budget is 15 minutes/points
• These users are banned and won't be assigned:
  • @victornoel/z: This user reported the ticket
  • @fabriciofx/z: User was resigned from the ticket
• Job footprint (restricted area)

[paulodamaso]

@0crat quality acceptable

[0crat]

@0crat quality acceptable (here)

@paulodamaso There is no quality review for #1209, no performer

[0crat]

Code review was too long (10 days), architects (@paulodamaso) were penalized, see §55

[0crat]

The job #1209 is now out of scope

[0crat]

Order was finished: +15 point(s) just awarded to @paulodamaso/z

[0crat]

Payment to ARC for a closed pull request, as in §28: +10 point(s) just awarded to @paulodamaso/z