README documentation for SetOf was added #1250
Conversation
|
Job #1250 is now in scope, role is |
|
This pull request #1250 is assigned to @iakunin/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @paulodamaso/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be no monetary reward for this job |
There was a problem hiding this comment.
@fanifieiev just a few cosmetic changes. Could you have a look?
README.md
Outdated
| @@ -208,6 +208,33 @@ int total = new LengthOf( | |||
| ).intValue(); | |||
| ``` | |||
|
|
|||
| To get a set of unique elements by providing varargs: | |||
There was a problem hiding this comment.
@fanifieiev To get a set sounds a little bit vague, in my opinion. Maybe it's better to start with To create a set?
There was a problem hiding this comment.
@fanifieiev
To get a setsounds a little bit vague, in my opinion. Maybe it's better to start withTo create a set?
@iakunin Agree, will fix.
README.md
Outdated
| ); | ||
| ``` | ||
|
|
||
| To get a set of unique elements from existing iterable: |
There was a problem hiding this comment.
@fanifieiev To get a set sounds a little bit vague, in my opinion. Maybe it's better to start with To create a set?
There was a problem hiding this comment.
@iakunin Agree, will fix.
README.md
Outdated
| ); | ||
| ``` | ||
|
|
||
| To get sorted iterable with unique elements from existing iterable: |
There was a problem hiding this comment.
@fanifieiev just by analogy with the previous sentences we can start this one with To create sorted iterable
README.md
Outdated
| @@ -208,6 +208,33 @@ int total = new LengthOf( | |||
| ).intValue(); | |||
| ``` | |||
|
|
|||
| To get a set of unique elements by providing varargs: | |||
There was a problem hiding this comment.
@fanifieiev a phrase set of unique elements could be a little bit excessive one, because the definition of Set already implies that:
set is an abstract data type that can store unique values
@fanifieiev what do you think?
There was a problem hiding this comment.
@iakunin Agree.
README.md
Outdated
| ); | ||
| ``` | ||
|
|
||
| To get a set of unique elements from existing iterable: |
There was a problem hiding this comment.
@fanifieiev a phrase set of unique elements could be a little bit excessive one, because the definition of Set already implies that:
set is an abstract data type that can store unique values
@fanifieiev what do you think?
There was a problem hiding this comment.
@iakunin Will fix that.
Codecov Report
@@ Coverage Diff @@
## master #1250 +/- ##
=========================================
Coverage 89.32% 89.32%
Complexity 1686 1686
=========================================
Files 280 280
Lines 4028 4028
Branches 212 212
=========================================
Hits 3598 3598
Misses 396 396
Partials 34 34Continue to review full report at Codecov.
|
|
@fanifieiev thank you for your fixes |
|
@paulodamaso looks good to merge |
@paulodamaso ping |
|
@paulodamaso ping |
|
@iakunin @fanifieiev Sorry for the delay, guys |
|
@rultor merge |
@paulodamaso OK, I'll try to merge now. You can check the progress of the merge here |
@paulodamaso Done! FYI, the full log is here (took me 19min) |
|
@sereshqua/z please review this job completed by @iakunin/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed |
|
The job #1250 is now out of scope |
|
Payment to |
|
@iakunin please make you comments during next CR would be mostly about design problems, not just cosmetic issues |
|
@sereshqua got it. I’ll try my best. |
|
@0crat quality acceptable |
|
Quality review completed: +4 point(s) just awarded to @sereshqua/z |
This PR is for issue 1246.
This includes an additional documentation description for SetOf.