(#1259) Sorted Set with custom comparator #1279

fanifieiev · 2020-02-03T19:01:48Z

This PR is for #1259

fanifieiev · 2020-02-03T19:16:21Z

@paulodamaso
Question:

Do you now where that test org.cactoos.experimental.TimedTest is located ?? The repo does not contain it.

paulodamaso · 2020-02-03T19:29:27Z

@fanifieiev Please update your branch, Timed was introduced in #1000

0crat · 2020-02-03T19:49:07Z

This pull request #1279 is assigned to @fabriciofx /z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @paulodamaso /z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be no monetary reward for this job

paulodamaso · 2020-02-03T20:06:53Z

@0crat assign me

0crat · 2020-02-03T20:18:33Z

@paulodamaso This pull request #1279 is assigned to @paulodamaso /z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @paulodamaso /z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be no monetary reward for this job

0crat · 2020-02-03T20:18:49Z

Manual assignment of issues is discouraged, see §19: -5 point(s) just awarded to @paulodamaso /z

0crat · 2020-02-03T20:32:21Z

@paulodamaso There is an unrecoverable failure on my side. Please, submit it here:

PID: 11@377a78bde909, thread: PQ-C63314D6Z
com.zerocracy.claims.ClaimIn[214] java.lang.IllegalArgumentException: Parameter "age" not found in "Order was canceled" among: [comment, job, issue, repo, cause, _parent_sig, flow, login]

0.51.0: CID: 22701f4d-5817-401c-8869-638368d49a1c, Type: "Order was canceled"

0crat · 2020-02-03T21:15:42Z

Job #1279 is already in the agenda of @paulodamaso /z

fanifieiev · 2020-02-04T01:45:17Z

@paulodamaso I have no idea why that build fails. It does not fail locally and the failure is related to TimedTest.

codecov-io · 2020-02-05T15:38:12Z

Codecov Report

@@             Coverage Diff              @@
##             master    #1279      +/-   ##
============================================
+ Coverage     89.24%   89.46%   +0.21%     
- Complexity     1690     1691       +1     
============================================
  Files           285      286       +1     
  Lines          4053     4061       +8     
  Branches        211      212       +1     
============================================
+ Hits           3617     3633      +16     
+ Misses          403      393      -10     
- Partials         33       35       +2

Impacted Files	Coverage Δ	Complexity Δ
src/main/java/org/cactoos/set/Sorted.java	`100% <100%> (ø)`	`3 <3> (?)`
src/main/java/org/cactoos/set/SetOf.java	`100% <100%> (ø)`	`3 <0> (ø)`	⬇️
src/main/java/org/cactoos/list/Shuffled.java	`60% <0%> (-15%)`	`2% <0%> (ø)`
src/main/java/org/cactoos/scalar/Solid.java	`90% <0%> (-10%)`	`3% <0%> (-1%)`
src/main/java/org/cactoos/list/Immutable.java	`94.44% <0%> (-5.56%)`	`38% <0%> (+11%)`
src/main/java/org/cactoos/list/Sticky.java	`100% <0%> (ø)`	`4% <0%> (+1%)`	⬆️
src/main/java/org/cactoos/list/Joined.java	`100% <0%> (ø)`	`3% <0%> (ø)`	⬇️
src/main/java/org/cactoos/list/Sorted.java	`83.33% <0%> (ø)`	`4% <0%> (ø)`	⬇️
src/main/java/org/cactoos/list/Solid.java	`100% <0%> (ø)`	`3% <0%> (ø)`	⬇️
...rc/main/java/org/cactoos/collection/Immutable.java	`94.73% <0%> (ø)`	`16% <0%> (ø)`	⬇️
... and 8 more

Continue to review full report at Codecov.

paulodamaso · 2020-02-05T18:14:21Z

@fanifieiev PLease solve these conflicts

paulodamaso · 2020-02-06T00:03:33Z

@fanifieiev Please merge with master, there are too much files being altered in this PR

fanifieiev · 2020-02-06T19:29:03Z

@paulodamaso Please have a look.

paulodamaso · 2020-02-08T03:12:55Z

@rultor merge

rultor · 2020-02-08T03:14:37Z

@paulodamaso OK, I'll try to merge now. You can check the progress of the merge here

rultor · 2020-02-08T03:17:20Z

@fanifieiev @paulodamaso Oops, I failed. You can see the full log here (spent 2min)

+ ls -al .
total 724
drwx--x--x  3 rultor rultor   4096 Feb  8 04:15 .
drwxrwxrwt 12 root   root   684032 Feb  8 04:15 ..
-rw-rw-r--  1 rultor rultor    444 Feb  8 04:15 end.sh
-rwxrwxr-x  1 rultor rultor    338 Feb  8 04:15 entry.sh
-rw-rw-r--  1 rultor rultor      5 Feb  8 04:15 pid
-rw-rw-r--  1 rultor rultor   1192 Feb  8 04:15 pubring.gpg
drwxrwxr-x  5 rultor rultor   4096 Feb  8 04:15 repo
-rwxrwxr-x  1 rultor rultor   6295 Feb  8 04:15 run.sh
-rw-rw-r--  1 rultor rultor    691 Feb  8 04:15 script.sh
-rw-rw-r--  1 rultor rultor   2570 Feb  8 04:15 secring.gpg
-rw-rw-r--  1 rultor rultor    831 Feb  8 04:15 settings.xml
-rw-rw-r--  1 rultor rultor   7542 Feb  8 04:15 stdout
++ pwd
++ pwd
+ docker run -t --rm -v /tmp/rultor-TD6H:/main --env=MAVEN_OPTS=-Xmx1g --env=JAVA_OPTS=-Xmx1g [email protected]:yegor256/cactoos.git --env=pull_id=1279 [email protected]:fanifieiev/cactoos.git --env=fork_branch=1259 --env=head_branch=master '--env=pull_title=(#1259) Sorted Set with custom comparator' --env=author=paulodamaso '--env=scripts=( '\''export '\''\'\'''\''MAVEN_OPTS=-Xmx1g'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''JAVA_OPTS=-Xmx1g'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''[email protected]:yegor256/cactoos.git'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''pull_id=1279'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''[email protected]:fanifieiev/cactoos.git'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''fork_branch=1259'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''head_branch=master'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''pull_title=(#1259) Sorted Set with custom comparator'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''author=paulodamaso'\''\'\'''\'''\'' '\'';'\'' '\''sudo gem install --no-rdoc --no-ri pdd'\'' '\'';'\'' '\''sudo gem install --no-rdoc --no-ri xcop'\'' '\'';'\'' '\''pdd --file=/dev/null'\'' '\'';'\'' '\''mvn clean install -Pqulice --errors --settings ../settings.xml'\'' '\'';'\'' '\''mvn clean site -Psite --errors --settings ../settings.xml'\'' '\'';'\'' )' --hostname=docker --privileged --memory=6g --memory-swap=16g --oom-kill-disable --cidfile=/tmp/rultor-TD6H/cid -w=/main -v /var/run/docker.sock:/var/run/docker.sock --entrypoint=/main/entry.sh --name=yegor256_cactoos_1279 yegor256/rultor-image /main/entry.sh
WARNING: Your kernel does not support swap limit capabilities or the cgroup is not mounted. Memory limited without swap.
+ set -e
+ set -o pipefail
+ shopt -s dotglob
+ useradd -m -G sudo r
+ echo '%sudo ALL=(ALL) NOPASSWD:ALL'
+ cp -R /root/.bashrc /root/.composer /root/.gem /root/.gnupg /root/.m2 /root/.profile /root/texmf /root/.wget-hsts /home/r
+ cp -R ./cid ./end.sh ./entry.sh ./pid ./pubring.gpg ./repo ./run.sh ./script.sh ./secring.gpg ./settings.xml ./stdout /home/r
+ rm -rf repo
+ chown -R r:r /home/r
+ chmod a+x /home/r/script.sh
+ su --login r --command /home/r/script.sh
mesg: change /dev/pts/0 mode failed: Operation not permitted
+ set -e
+ set -o pipefail
+ shopt -s expand_aliases
+ alias 'sudo=sudo -i'
+ export HOME=/home/r
+ HOME=/home/r
+ cd /home/r/repo
+ export MAVEN_OPTS=-Xmx1g
+ MAVEN_OPTS=-Xmx1g
+ export JAVA_OPTS=-Xmx1g
+ JAVA_OPTS=-Xmx1g
+ export [email protected]:yegor256/cactoos.git
+ [email protected]:yegor256/cactoos.git
+ export pull_id=1279
+ pull_id=1279
+ export [email protected]:fanifieiev/cactoos.git
+ [email protected]:fanifieiev/cactoos.git
+ export fork_branch=1259
+ fork_branch=1259
+ export head_branch=master
+ head_branch=master
+ export 'pull_title=(#1259) Sorted Set with custom comparator'
+ pull_title='(#1259) Sorted Set with custom comparator'
+ export author=paulodamaso
+ author=paulodamaso
+ sudo -i gem install --no-rdoc --no-ri pdd
ERROR:  While executing gem ... (OptionParser::InvalidOption)
    invalid option: --no-rdoc
container 61c76a7e46ceefb3615a2e7736ca93b129d653a4e811a2018cb6abb676473e00 is dead
Sat Feb  8 04:17:07 CET 2020

paulodamaso · 2020-02-08T03:37:38Z

@rultor merge

rultor · 2020-02-08T03:39:41Z

@paulodamaso OK, I'll try to merge now. You can check the progress of the merge here

rultor · 2020-02-08T03:42:27Z

@fanifieiev @paulodamaso Oops, I failed. You can see the full log here (spent 2min)

+ ls -al .
total 724
drwx--x--x  3 rultor rultor   4096 Feb  8 04:40 .
drwxrwxrwt 12 root   root   684032 Feb  8 04:40 ..
-rw-rw-r--  1 rultor rultor    444 Feb  8 04:40 end.sh
-rwxrwxr-x  1 rultor rultor    338 Feb  8 04:40 entry.sh
-rw-rw-r--  1 rultor rultor      6 Feb  8 04:40 pid
-rw-rw-r--  1 rultor rultor   1192 Feb  8 04:40 pubring.gpg
drwxrwxr-x  5 rultor rultor   4096 Feb  8 04:40 repo
-rwxrwxr-x  1 rultor rultor   6295 Feb  8 04:40 run.sh
-rw-rw-r--  1 rultor rultor    691 Feb  8 04:40 script.sh
-rw-rw-r--  1 rultor rultor   2570 Feb  8 04:40 secring.gpg
-rw-rw-r--  1 rultor rultor    831 Feb  8 04:40 settings.xml
-rw-rw-r--  1 rultor rultor   7543 Feb  8 04:40 stdout
++ pwd
++ pwd
+ docker run -t --rm -v /tmp/rultor-lvxS:/main --env=MAVEN_OPTS=-Xmx1g --env=JAVA_OPTS=-Xmx1g [email protected]:yegor256/cactoos.git --env=pull_id=1279 [email protected]:fanifieiev/cactoos.git --env=fork_branch=1259 --env=head_branch=master '--env=pull_title=(#1259) Sorted Set with custom comparator' --env=author=paulodamaso '--env=scripts=( '\''export '\''\'\'''\''MAVEN_OPTS=-Xmx1g'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''JAVA_OPTS=-Xmx1g'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''[email protected]:yegor256/cactoos.git'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''pull_id=1279'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''[email protected]:fanifieiev/cactoos.git'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''fork_branch=1259'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''head_branch=master'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''pull_title=(#1259) Sorted Set with custom comparator'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''author=paulodamaso'\''\'\'''\'''\'' '\'';'\'' '\''sudo gem install --no-rdoc --no-ri pdd'\'' '\'';'\'' '\''sudo gem install --no-rdoc --no-ri xcop'\'' '\'';'\'' '\''pdd --file=/dev/null'\'' '\'';'\'' '\''mvn clean install -Pqulice --errors --settings ../settings.xml'\'' '\'';'\'' '\''mvn clean site -Psite --errors --settings ../settings.xml'\'' '\'';'\'' )' --hostname=docker --privileged --memory=6g --memory-swap=16g --oom-kill-disable --cidfile=/tmp/rultor-lvxS/cid -w=/main -v /var/run/docker.sock:/var/run/docker.sock --entrypoint=/main/entry.sh --name=yegor256_cactoos_1279 yegor256/rultor-image /main/entry.sh
WARNING: Your kernel does not support swap limit capabilities or the cgroup is not mounted. Memory limited without swap.
+ set -e
+ set -o pipefail
+ shopt -s dotglob
+ useradd -m -G sudo r
+ echo '%sudo ALL=(ALL) NOPASSWD:ALL'
+ cp -R /root/.bashrc /root/.composer /root/.gem /root/.gnupg /root/.m2 /root/.profile /root/texmf /root/.wget-hsts /home/r
+ cp -R ./cid ./end.sh ./entry.sh ./pid ./pubring.gpg ./repo ./run.sh ./script.sh ./secring.gpg ./settings.xml ./stdout /home/r
+ rm -rf repo
+ chown -R r:r /home/r
+ chmod a+x /home/r/script.sh
+ su --login r --command /home/r/script.sh
mesg: change /dev/pts/0 mode failed: Operation not permitted
+ set -e
+ set -o pipefail
+ shopt -s expand_aliases
+ alias 'sudo=sudo -i'
+ export HOME=/home/r
+ HOME=/home/r
+ cd /home/r/repo
+ export MAVEN_OPTS=-Xmx1g
+ MAVEN_OPTS=-Xmx1g
+ export JAVA_OPTS=-Xmx1g
+ JAVA_OPTS=-Xmx1g
+ export [email protected]:yegor256/cactoos.git
+ [email protected]:yegor256/cactoos.git
+ export pull_id=1279
+ pull_id=1279
+ export [email protected]:fanifieiev/cactoos.git
+ [email protected]:fanifieiev/cactoos.git
+ export fork_branch=1259
+ fork_branch=1259
+ export head_branch=master
+ head_branch=master
+ export 'pull_title=(#1259) Sorted Set with custom comparator'
+ pull_title='(#1259) Sorted Set with custom comparator'
+ export author=paulodamaso
+ author=paulodamaso
+ sudo -i gem install --no-rdoc --no-ri pdd
ERROR:  While executing gem ... (OptionParser::InvalidOption)
    invalid option: --no-rdoc
container 9c6db31c06fb04661dfd6521c86279f377dde22d7d9594343aa979a7333f0d22 is dead
Sat Feb  8 04:42:14 CET 2020

paulodamaso · 2020-02-10T13:00:09Z

@rultor merge

rultor · 2020-02-10T13:01:22Z

@paulodamaso OK, I'll try to merge now. You can check the progress of the merge here

rultor · 2020-02-10T13:16:21Z

@paulodamaso Done! FYI, the full log is here (took me 14min)

0crat · 2020-02-10T14:03:54Z

Order was finished: +15 point(s) just awarded to @paulodamaso /z

0crat · 2020-02-10T14:09:50Z

Payment to ARC for a closed pull request, as in §28: +10 point(s) just awarded to @paulodamaso /z

0crat added scope role/REV labels Feb 3, 2020

0crat assigned paulodamaso Feb 3, 2020

fanifieiev mentioned this pull request Feb 3, 2020

SetOf with custom comparator #1259

Closed

fanifieiev added 3 commits February 6, 2020 13:54

(yegor256#1259) Sorted Set with custom comparator

4126b7e

(yegor256#1259) One more test for Sorted set

a330a20

(yegor256#1259) Documentation about sorted set was added

bf07fc2

fanifieiev force-pushed the 1259 branch from 943131b to bf07fc2 Compare February 6, 2020 18:55

(yegor256#1259) Fixed qulice violations

f3635ad

rultor merged commit f3635ad into yegor256:master Feb 10, 2020

0crat removed the scope label Feb 10, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

(#1259) Sorted Set with custom comparator #1279

(#1259) Sorted Set with custom comparator #1279

fanifieiev commented Feb 3, 2020

fanifieiev commented Feb 3, 2020

paulodamaso commented Feb 3, 2020

0crat commented Feb 3, 2020

paulodamaso commented Feb 3, 2020

0crat commented Feb 3, 2020

0crat commented Feb 3, 2020

0crat commented Feb 3, 2020

0crat commented Feb 3, 2020

fanifieiev commented Feb 4, 2020

codecov-io commented Feb 5, 2020 •

edited

Loading

paulodamaso commented Feb 5, 2020

paulodamaso commented Feb 6, 2020

fanifieiev commented Feb 6, 2020

paulodamaso commented Feb 8, 2020

rultor commented Feb 8, 2020

rultor commented Feb 8, 2020

paulodamaso commented Feb 8, 2020

rultor commented Feb 8, 2020

rultor commented Feb 8, 2020

paulodamaso commented Feb 10, 2020

rultor commented Feb 10, 2020

rultor commented Feb 10, 2020

0crat commented Feb 10, 2020

0crat commented Feb 10, 2020

(#1259) Sorted Set with custom comparator #1279

(#1259) Sorted Set with custom comparator #1279

Conversation

fanifieiev commented Feb 3, 2020

fanifieiev commented Feb 3, 2020

paulodamaso commented Feb 3, 2020

0crat commented Feb 3, 2020

paulodamaso commented Feb 3, 2020

0crat commented Feb 3, 2020

0crat commented Feb 3, 2020

0crat commented Feb 3, 2020

0crat commented Feb 3, 2020

fanifieiev commented Feb 4, 2020

codecov-io commented Feb 5, 2020 • edited Loading

Codecov Report

paulodamaso commented Feb 5, 2020

paulodamaso commented Feb 6, 2020

fanifieiev commented Feb 6, 2020

paulodamaso commented Feb 8, 2020

rultor commented Feb 8, 2020

rultor commented Feb 8, 2020

paulodamaso commented Feb 8, 2020

rultor commented Feb 8, 2020

rultor commented Feb 8, 2020

paulodamaso commented Feb 10, 2020

rultor commented Feb 10, 2020

rultor commented Feb 10, 2020

0crat commented Feb 10, 2020

0crat commented Feb 10, 2020

codecov-io commented Feb 5, 2020 •

edited

Loading