Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some collection decorators #1311

Merged
merged 3 commits into from
Feb 26, 2020

Conversation

victornoel
Copy link
Collaborator

This is for #1296, #1297 and #1303.

I did all at once because the changes are very limited to the removed classes.

@0crat
Copy link
Collaborator

0crat commented Feb 23, 2020

This pull request #1311 is assigned to @fanifieiev/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @paulodamaso/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be no monetary reward for this job

@fanifieiev
Copy link
Contributor

@victornoel Are there any other tickets related to removing those collection classes???
One of them #1294 is on me.
My question is: Why do not we remove them at once by one PR ????

@victornoel
Copy link
Collaborator Author

@fanifieiev this question should be asked to ARC, @paulodamaso, not me :)

I suspect there are cases where it entails more than just deleting the classes, but yes, most of them could be done in one go.

@paulodamaso
Copy link
Contributor

@fanifieiev @victornoel I think when we wrote these puzzles we didn't know how many classes depended on these ones. So, we chose to make several puzzles instead of just one. There is no problem to merge all of them in this specific case.

@paulodamaso
Copy link
Contributor

@rultor merge

@fanifieiev
Copy link
Contributor

@0crat status

@0crat
Copy link
Collaborator

0crat commented Feb 25, 2020

@0crat status (here)

@fanifieiev This is what I know about this job in C63314D6Z, as in §32:

@victornoel
Copy link
Collaborator Author

@fanifieiev can we merge this? or do you want me to change something?

Copy link
Contributor

@fanifieiev fanifieiev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@victornoel yes, we can merge it
@paulodamaso Please merge

@paulodamaso
Copy link
Contributor

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Feb 26, 2020

@rultor merge

@paulodamaso OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 051c24a into yegor256:master Feb 26, 2020
@rultor
Copy link
Collaborator

rultor commented Feb 26, 2020

@rultor merge

@paulodamaso Done! FYI, the full log is here (took me 13min)

@rultor
Copy link
Collaborator

rultor commented Feb 26, 2020

@rultor merge

@paulodamaso @victornoel The pull request is closed already, so I can't merge it

@rultor
Copy link
Collaborator

rultor commented Feb 26, 2020

@rultor merge

@paulodamaso I'm sorry, I don't understand you :( Check this page and try again please

@0crat
Copy link
Collaborator

0crat commented Feb 26, 2020

@sereshqua/z please review this job completed by @fanifieiev/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

@0crat 0crat removed the scope label Feb 26, 2020
@sereshqua
Copy link

@0crat quality bad

@0crat
Copy link
Collaborator

0crat commented Feb 26, 2020

Quality is low, no payment, see §31

@0crat
Copy link
Collaborator

0crat commented Feb 26, 2020

Payment to ARC for a closed pull request, as in §28: +10 point(s) just awarded to @paulodamaso/z

@0crat
Copy link
Collaborator

0crat commented Feb 26, 2020

Quality review completed: +4 point(s) just awarded to @sereshqua/z

@victornoel victornoel deleted the remove-some-collection-decorators branch February 29, 2020 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants