-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove some collection decorators #1311
Remove some collection decorators #1311
Conversation
This pull request #1311 is assigned to @fanifieiev/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @paulodamaso/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be no monetary reward for this job |
@victornoel Are there any other tickets related to removing those collection classes??? |
@fanifieiev this question should be asked to ARC, @paulodamaso, not me :) I suspect there are cases where it entails more than just deleting the classes, but yes, most of them could be done in one go. |
@fanifieiev @victornoel I think when we wrote these puzzles we didn't know how many classes depended on these ones. So, we chose to make several puzzles instead of just one. There is no problem to merge all of them in this specific case. |
@rultor merge |
@0crat status |
@fanifieiev This is what I know about this job in C63314D6Z, as in §32:
|
@fanifieiev can we merge this? or do you want me to change something? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@victornoel yes, we can merge it
@paulodamaso Please merge
@rultor merge |
@paulodamaso OK, I'll try to merge now. You can check the progress of the merge here |
@paulodamaso Done! FYI, the full log is here (took me 13min) |
@paulodamaso @victornoel The pull request is closed already, so I can't merge it |
@paulodamaso I'm sorry, I don't understand you :( Check this page and try again please |
@sereshqua/z please review this job completed by @fanifieiev/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed |
@0crat quality bad |
Quality is low, no payment, see §31 |
Payment to |
Quality review completed: +4 point(s) just awarded to @sereshqua/z |
This is for #1296, #1297 and #1303.
I did all at once because the changes are very limited to the removed classes.